diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2022-11-05 13:43:37 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-05 13:43:37 +0100 |
| commit | 9616f5bb2248b4bf8f1e51130af1f19a94abf6db (patch) | |
| tree | 2b6e7150dddf24514f1f8818da0a5ee8f562f54e /app/javascript/mastodon/features/compose/components/upload.js | |
| parent | 1e7ea50f4ccadee0a25db0d79840497bd0175589 (diff) | |
| download | mastodon-9616f5bb2248b4bf8f1e51130af1f19a94abf6db.tar mastodon-9616f5bb2248b4bf8f1e51130af1f19a94abf6db.tar.gz mastodon-9616f5bb2248b4bf8f1e51130af1f19a94abf6db.tar.bz2 mastodon-9616f5bb2248b4bf8f1e51130af1f19a94abf6db.zip | |
Fix compose form submission reloading web interface (#19762)
* Fix compose form submission reloading web interface
Fix regression introduced by #19742
* Fix various compose form buttons being handled like submit buttons
* Fix coding style issue
* Fix missing onClick prop check
Diffstat (limited to 'app/javascript/mastodon/features/compose/components/upload.js')
| -rw-r--r-- | app/javascript/mastodon/features/compose/components/upload.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/javascript/mastodon/features/compose/components/upload.js b/app/javascript/mastodon/features/compose/components/upload.js index 706824dc7..44bf9a24a 100644 --- a/app/javascript/mastodon/features/compose/components/upload.js +++ b/app/javascript/mastodon/features/compose/components/upload.js @@ -43,13 +43,13 @@ export default class Upload extends ImmutablePureComponent { {({ scale }) => ( <div className='compose-form__upload-thumbnail' style={{ transform: `scale(${scale})`, backgroundImage: `url(${media.get('preview_url')})`, backgroundPosition: `${x}% ${y}%` }}> <div className='compose-form__upload__actions'> - <button className='icon-button' onClick={this.handleUndoClick}><Icon id='times' /> <FormattedMessage id='upload_form.undo' defaultMessage='Delete' /></button> - {!isEditingStatus && (<button className='icon-button' onClick={this.handleFocalPointClick}><Icon id='pencil' /> <FormattedMessage id='upload_form.edit' defaultMessage='Edit' /></button>)} + <button type='button' className='icon-button' onClick={this.handleUndoClick}><Icon id='times' /> <FormattedMessage id='upload_form.undo' defaultMessage='Delete' /></button> + {!isEditingStatus && (<button type='button' className='icon-button' onClick={this.handleFocalPointClick}><Icon id='pencil' /> <FormattedMessage id='upload_form.edit' defaultMessage='Edit' /></button>)} </div> {(media.get('description') || '').length === 0 && ( <div className='compose-form__upload__warning'> - <button className='icon-button' onClick={this.handleFocalPointClick}><Icon id='info-circle' /> <FormattedMessage id='upload_form.description_missing' defaultMessage='No description added' /></button> + <button type='button' className='icon-button' onClick={this.handleFocalPointClick}><Icon id='info-circle' /> <FormattedMessage id='upload_form.description_missing' defaultMessage='No description added' /></button> </div> )} </div> |