diff options
author | Yuuta Liang <yuutaw@students.cs.ubc.ca> | 2023-10-14 05:35:17 +0800 |
---|---|---|
committer | Yuuta Liang <yuutaw@students.cs.ubc.ca> | 2023-10-14 05:35:17 +0800 |
commit | 28fa18278c1f3a87722d5e8b78f581526a30bb38 (patch) | |
tree | 2f23f6e2e222a78f40809ec37e8b28a29cba3d3c /src/main/model/x501 | |
parent | 0bcc057e741af3fbc108f42b75f9d42f48f6a51e (diff) | |
download | jca-28fa18278c1f3a87722d5e8b78f581526a30bb38.tar jca-28fa18278c1f3a87722d5e8b78f581526a30bb38.tar.gz jca-28fa18278c1f3a87722d5e8b78f581526a30bb38.tar.bz2 jca-28fa18278c1f3a87722d5e8b78f581526a30bb38.zip |
Fix lint
Signed-off-by: Yuuta Liang <yuutaw@students.cs.ubc.ca>
Diffstat (limited to 'src/main/model/x501')
-rw-r--r-- | src/main/model/x501/AttributeTypeAndValue.java | 13 | ||||
-rw-r--r-- | src/main/model/x501/Name.java | 4 | ||||
-rw-r--r-- | src/main/model/x501/RelativeDistinguishedName.java | 4 |
3 files changed, 10 insertions, 11 deletions
diff --git a/src/main/model/x501/AttributeTypeAndValue.java b/src/main/model/x501/AttributeTypeAndValue.java index d43d137..54b3352 100644 --- a/src/main/model/x501/AttributeTypeAndValue.java +++ b/src/main/model/x501/AttributeTypeAndValue.java @@ -5,7 +5,6 @@ import model.asn1.ObjectIdentifier; import model.asn1.Tag; import model.asn1.exceptions.ParseException; import model.asn1.parsing.BytesReader; -import model.csr.Values; import java.util.Arrays; import java.util.Collection; @@ -45,11 +44,11 @@ public class AttributeTypeAndValue extends ASN1Object { /** * EFFECTS: Parse input DER. Value is not checked against the type. - * Throws {@link ASN1Object} if invalid: - * - Any fields missing - * - Any fields having an incorrect tag (as seen in the ASN.1 definition) - * - Any fields with encoding instructions that violate implicit / explicit encoding rules - * - Other issues found during parsing the object, like early EOF (see {@link ASN1Object}) + * Throws {@link ASN1Object} if invalid: + * - Any fields missing + * - Any fields having an incorrect tag (as seen in the ASN.1 definition) + * - Any fields with encoding instructions that violate implicit / explicit encoding rules + * - Other issues found during parsing the object, like early EOF (see {@link ASN1Object}) * MODIFIES: this, encoded */ public AttributeTypeAndValue(BytesReader encoded, boolean hasParentTag) throws ParseException { @@ -66,7 +65,7 @@ public class AttributeTypeAndValue extends ASN1Object { @Override public Byte[] encodeValueDER() { return Stream.of(Arrays.asList(type.encodeDER()), - Arrays.asList(value.encodeDER())) + Arrays.asList(value.encodeDER())) .flatMap(Collection::stream) .toArray(Byte[]::new); } diff --git a/src/main/model/x501/Name.java b/src/main/model/x501/Name.java index dd2acb6..19cde56 100644 --- a/src/main/model/x501/Name.java +++ b/src/main/model/x501/Name.java @@ -35,13 +35,13 @@ public class Name extends ASN1Object { /** * EFFECT: Parse the Name from input DER bytes. For details on parsing, refer to {@link ASN1Object}. - * Throws {@link ParseException} for invalid input. + * Throws {@link ParseException} for invalid input. * MODIFIES: this, encoded */ public Name(BytesReader encoded, boolean hasParentTag) throws ParseException { super(encoded, hasParentTag); final List<RelativeDistinguishedName> list = new ArrayList<>(); - for (int i = 0; i < getLength();) { + for (int i = 0; i < getLength(); ) { int index = encoded.getIndex(); final RelativeDistinguishedName name = new RelativeDistinguishedName(encoded, false); name.getTag().enforce(TAG_SET); diff --git a/src/main/model/x501/RelativeDistinguishedName.java b/src/main/model/x501/RelativeDistinguishedName.java index 8edde09..c431f12 100644 --- a/src/main/model/x501/RelativeDistinguishedName.java +++ b/src/main/model/x501/RelativeDistinguishedName.java @@ -34,13 +34,13 @@ public class RelativeDistinguishedName extends ASN1Object { /** * EFFECT: Parse the list from input DER bytes. For details on parsing, refer to {@link ASN1Object}. - * Throws {@link ParseException} for invalid input. + * Throws {@link ParseException} for invalid input. * MODIFIES: this, encoded */ public RelativeDistinguishedName(BytesReader encoded, boolean hasParentTag) throws ParseException { super(encoded, hasParentTag); final List<AttributeTypeAndValue> list = new ArrayList<>(); - for (int i = 0; i < getLength();) { + for (int i = 0; i < getLength(); ) { int index = encoded.getIndex(); final AttributeTypeAndValue value = new AttributeTypeAndValue(encoded, false); value.getTag().enforce(TAG_SEQUENCE); |