aboutsummaryrefslogtreecommitdiff
path: root/sysdeps/unix
diff options
context:
space:
mode:
authorAdhemerval Zanella <azanella@linux.vnet.ibm.com>2015-01-06 07:59:04 -0500
committerAdhemerval Zanella <azanella@linux.vnet.ibm.com>2015-01-08 08:03:31 -0500
commitdd6e8af6ba1b8a95a7f1dc7422e5ea4ccc7fbd93 (patch)
tree10046fc1091a66245c81fe62ef62ef52b11413ca /sysdeps/unix
parent28c38448de826314c1d89b18a26042fee21d7c9c (diff)
downloadglibc-dd6e8af6ba1b8a95a7f1dc7422e5ea4ccc7fbd93.tar
glibc-dd6e8af6ba1b8a95a7f1dc7422e5ea4ccc7fbd93.tar.gz
glibc-dd6e8af6ba1b8a95a7f1dc7422e5ea4ccc7fbd93.tar.bz2
glibc-dd6e8af6ba1b8a95a7f1dc7422e5ea4ccc7fbd93.zip
powerpc: Fix compiler warning on some syscalls
GCC 5.0 emits an warning when using sizeof on array function parameters and powerpc internal syscall macros add a check for such cases. More specifically, on powerpc64 and powerpc32 sysdep.h: if (__builtin_classify_type (__arg3) != 5 && sizeof (__arg3) > 8) \ __illegally_sized_syscall_arg3 (); \ And for sysdeps/unix/sysv/linux/utimensat.c build GCC emits: error: ‘sizeof’ on array function parameter ‘tsp’ will return size of ‘const struct timespec *’ This patch uses the address of first struct member instead of the struct itself in syscall macro.
Diffstat (limited to 'sysdeps/unix')
-rw-r--r--sysdeps/unix/sysv/linux/futimens.c3
-rw-r--r--sysdeps/unix/sysv/linux/futimesat.c8
-rw-r--r--sysdeps/unix/sysv/linux/utimensat.c3
-rw-r--r--sysdeps/unix/sysv/linux/utimes.c3
4 files changed, 9 insertions, 8 deletions
diff --git a/sysdeps/unix/sysv/linux/futimens.c b/sysdeps/unix/sysv/linux/futimens.c
index c7d03a8f7c..5f2b8a56cd 100644
--- a/sysdeps/unix/sysv/linux/futimens.c
+++ b/sysdeps/unix/sysv/linux/futimens.c
@@ -37,7 +37,8 @@ futimens (int fd, const struct timespec tsp[2])
__set_errno (EBADF);
return -1;
}
- return INLINE_SYSCALL (utimensat, 4, fd, NULL, tsp, 0);
+ /* Avoid implicit array coercion in syscall macros. */
+ return INLINE_SYSCALL (utimensat, 4, fd, NULL, &tsp[0], 0);
#else
__set_errno (ENOSYS);
return -1;
diff --git a/sysdeps/unix/sysv/linux/futimesat.c b/sysdeps/unix/sysv/linux/futimesat.c
index ac96e2af39..27d68702e1 100644
--- a/sysdeps/unix/sysv/linux/futimesat.c
+++ b/sysdeps/unix/sysv/linux/futimesat.c
@@ -28,13 +28,11 @@
/* Change the access time of FILE relative to FD to TVP[0] and
the modification time of FILE to TVP[1]. */
int
-futimesat (fd, file, tvp)
- int fd;
- const char *file;
- const struct timeval tvp[2];
+futimesat (int fd, const char *file, const struct timeval tvp[2])
{
if (file == NULL)
return __futimes (fd, tvp);
- return INLINE_SYSCALL (futimesat, 3, fd, file, tvp);
+ /* Avoid implicit array coercion in syscall macros. */
+ return INLINE_SYSCALL (futimesat, 3, fd, file, &tvp[0]);
}
diff --git a/sysdeps/unix/sysv/linux/utimensat.c b/sysdeps/unix/sysv/linux/utimensat.c
index 5a5dec7f8e..81b565f2ea 100644
--- a/sysdeps/unix/sysv/linux/utimensat.c
+++ b/sysdeps/unix/sysv/linux/utimensat.c
@@ -35,7 +35,8 @@ utimensat (int fd, const char *file, const struct timespec tsp[2],
return -1;
}
#ifdef __NR_utimensat
- return INLINE_SYSCALL (utimensat, 4, fd, file, tsp, flags);
+ /* Avoid implicit array coercion in syscall macros. */
+ return INLINE_SYSCALL (utimensat, 4, fd, file, &tsp[0], flags);
#else
__set_errno (ENOSYS);
return -1;
diff --git a/sysdeps/unix/sysv/linux/utimes.c b/sysdeps/unix/sysv/linux/utimes.c
index 5423ff200f..2a1f2f90a1 100644
--- a/sysdeps/unix/sysv/linux/utimes.c
+++ b/sysdeps/unix/sysv/linux/utimes.c
@@ -29,7 +29,8 @@
int
__utimes (const char *file, const struct timeval tvp[2])
{
- return INLINE_SYSCALL (utimes, 2, file, tvp);
+ /* Avoid implicit array coercion in syscall macros. */
+ return INLINE_SYSCALL (utimes, 2, file, &tvp[0]);
}
weak_alias (__utimes, utimes)