diff options
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2015-05-26 22:27:23 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@redhat.com> | 2015-05-26 22:27:24 +0530 |
| commit | a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7 (patch) | |
| tree | 3a7ea26d683e6b18352dcc19e9204c34cb99b5b7 /sysdeps/nacl/bits | |
| parent | f534255e4d276ee7b20b45637d16a00b122e5df3 (diff) | |
| download | glibc-a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7.tar glibc-a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7.tar.gz glibc-a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7.tar.bz2 glibc-a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7.zip | |
struct stat is not posix conform
On 21/05/15 05:29, Siddhesh Poyarekar wrote:
> On Wed, May 20, 2015 at 06:55:02PM +0100, Szabolcs Nagy wrote:
>> i guess it's ok for consistency if i fix struct stat64
>> too to use __USE_XOPEN2K8.
>>
>> i will run some tests and come back with a patch
>
> I also think it would be appropriate to change this code in other
> architectures (microblaze and nacl IIRC) to make all of them
> consistent. It is a mechanical enough change IMO that all arch
> maintainer acks is not necessary.
>
here is the patch with consistent __USE_XOPEN2K8
ok to commit?
2015-05-21 Szabolcs Nagy <szabolcs.nagy@arm.com>
[BZ #18234]
* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
st_mtim and st_ctim members.
* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
(struct stat64): Likewise.
Diffstat (limited to 'sysdeps/nacl/bits')
| -rw-r--r-- | sysdeps/nacl/bits/stat.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sysdeps/nacl/bits/stat.h b/sysdeps/nacl/bits/stat.h index 0cd3500adb..9b89b15fcd 100644 --- a/sysdeps/nacl/bits/stat.h +++ b/sysdeps/nacl/bits/stat.h @@ -42,7 +42,7 @@ struct stat __off_t st_size; /* Size of file, in bytes. */ __blksize_t st_blksize; /* Optimal block size for I/O. */ __blkcnt_t st_blocks; /* Number 512-byte blocks allocated. */ -#if defined __USE_MISC || defined __USE_XOPEN2K8 +#if defined __USE_XOPEN2K8 /* Nanosecond resolution timestamps are stored in a format equivalent to 'struct timespec'. This is the type used whenever possible but the Unix namespace rules do not allow the @@ -81,7 +81,7 @@ struct stat64 __off_t st_size; /* Size of file, in bytes. */ __blksize_t st_blksize; /* Optimal block size for I/O. */ __blkcnt_t st_blocks; /* Number 512-byte blocks allocated. */ -# if defined __USE_MISC || defined __USE_XOPEN2K8 +# if defined __USE_XOPEN2K8 /* Nanosecond resolution timestamps are stored in a format equivalent to 'struct timespec'. This is the type used whenever possible but the Unix namespace rules do not allow the |