diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-07-13 16:43:24 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2018-10-02 10:01:56 -0300 |
| commit | 0b727ed4d605d9318cb0d323c88abb0d5a441a9b (patch) | |
| tree | 456efbab739f291b486ee8d937703cb0d4db5cef /sysdeps/generic/fd_to_filename.h | |
| parent | d0e91e8c4ef77997c940538eaa752799c9dda2d3 (diff) | |
| download | glibc-0b727ed4d605d9318cb0d323c88abb0d5a441a9b.tar glibc-0b727ed4d605d9318cb0d323c88abb0d5a441a9b.tar.gz glibc-0b727ed4d605d9318cb0d323c88abb0d5a441a9b.tar.bz2 glibc-0b727ed4d605d9318cb0d323c88abb0d5a441a9b.zip | |
libio: Flush stream at freopen (BZ#21037)
As POSIX states [1] a freopen call should first flush the stream as if by a
call fflush. C99 (n1256) and C11 (n1570) only states the function should
first close any file associated with the specific stream. Although current
implementation only follow C specification, current BSD and other libc
implementation (musl) are in sync with POSIX and fflush the stream.
This patch change freopen{64} to fflush the stream before actually reopening
it (or returning if the stream does not support reopen). It also changes the
Linux implementation to avoid a dynamic allocation on 'fd_to_filename'.
Checked on x86_64-linux-gnu.
[BZ #21037]
* libio/Makefile (tests): Add tst-memstream4 and tst-wmemstream4.
* libio/freopen.c (freopen): Sync stream before reopen and adjust to
new fd_to_filename interface.
* libio/freopen64.c (freopen64): Likewise.
* libio/tst-memstream.h: New file.
* libio/tst-memstream4.c: Likewise.
* libio/tst-wmemstream4.c: Likewise.
* sysdeps/generic/fd_to_filename.h (fd_to_filename): Change signature.
* sysdeps/unix/sysv/linux/fd_to_filename.h (fd_to_filename): Likewise
and remove internal dynamic allocation.
[1] http://pubs.opengroup.org/onlinepubs/9699919799/
Diffstat (limited to 'sysdeps/generic/fd_to_filename.h')
| -rw-r--r-- | sysdeps/generic/fd_to_filename.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sysdeps/generic/fd_to_filename.h b/sysdeps/generic/fd_to_filename.h index bacfe5bf52..d41b345a9d 100644 --- a/sysdeps/generic/fd_to_filename.h +++ b/sysdeps/generic/fd_to_filename.h @@ -16,10 +16,12 @@ License along with the GNU C Library; if not, see <http://www.gnu.org/licenses/>. */ +#define FD_TO_FILENAME_SIZE 0 + /* In general there is no generic way to query filename for an open file descriptor. */ static inline const char * -fd_to_filename (int fd) +fd_to_filename (int fd, char *buf) { return NULL; } |