diff options
| author | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-07-22 18:38:10 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-07-22 18:38:10 +0530 |
| commit | 0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd (patch) | |
| tree | baf150b3e1b728c6c13b95116241a61bff5f21ab /malloc/Makefile | |
| parent | b5bd5bfe88f496463ec9fab680a8edf64d7c2a42 (diff) | |
| download | glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.tar glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.tar.gz glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.tar.bz2 glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.zip | |
Move malloc_{g,s}et_state to libc_malloc_debug
These deprecated functions are only safe to call from
__malloc_initialize_hook and as a result, are not useful in the
general case. Move the implementations to libc_malloc_debug so that
existing binaries that need it will now have to preload the debug DSO
to work correctly.
This also allows simplification of the core malloc implementation by
dropping all the undumping support code that was added to make
malloc_set_state work.
One known breakage is that of ancient emacs binaries that depend on
this. They will now crash when running with this libc. With
LD_BIND_NOW=1, it will terminate immediately because of not being able
to find malloc_set_state but with lazy binding it will crash in
unpredictable ways. It will need a preloaded libc_malloc_debug.so so
that its initialization hook is executed to allow its malloc
implementation to work properly.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'malloc/Makefile')
| -rw-r--r-- | malloc/Makefile | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/malloc/Makefile b/malloc/Makefile index b89af21d19..96328da247 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -331,3 +331,8 @@ tst-compathooks-on-malloc-check-ENV = \ LD_PRELOAD=$(objpfx)libc_malloc_debug.so tst-mallocstate-ENV = LD_PRELOAD=$(objpfx)libc_malloc_debug.so tst-mallocstate-malloc-check-ENV = LD_PRELOAD=$(objpfx)libc_malloc_debug.so + +# The test needs malloc_get_state/malloc_set_state which is in +# libc_malloc_debug.so. +$(objpfx)tst-mallocstate: $(objpfx)libc_malloc_debug.so +$(objpfx)tst-mallocstate-malloc-check: $(objpfx)libc_malloc_debug.so |