diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2018-02-23 11:29:27 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2018-02-23 11:29:39 -0800 |
| commit | f5d1f629c693bc30ccc8ff1246cb37986c1adb1c (patch) | |
| tree | 7ab5aa175267326f4e8aeeb600034a52e3aaafbb /ChangeLog | |
| parent | 54412d20618b7b93f136a168e788573575f8a7a6 (diff) | |
| download | glibc-f5d1f629c693bc30ccc8ff1246cb37986c1adb1c.tar glibc-f5d1f629c693bc30ccc8ff1246cb37986c1adb1c.tar.gz glibc-f5d1f629c693bc30ccc8ff1246cb37986c1adb1c.tar.bz2 glibc-f5d1f629c693bc30ccc8ff1246cb37986c1adb1c.zip | |
Define GEN_AS_CONST_HEADERS when generating header files [BZ #22792]
Glibc build generates header files to define constants from special .sym
files. If a .sym file includes the same header file which it generates,
it leads to circular dependency which may lead to build hang on a
many-core machine. Define GEN_AS_CONST_HEADERS when generating header
files to avoid circular dependency.
<tcb-offsets.h> is needed for i686 and it isn't needed for x86-64 at
least since glibc 2.23.
Tested on i686 and x86-64.
[BZ #22792]
* Makerules ($(common-objpfx)%.h): Pass -DGEN_AS_CONST_HEADERS
to $(CC).
* sysdeps/unix/sysv/linux/i386/lowlevellock.h: Include
<tcb-offsets.h> only if GEN_AS_CONST_HEADERS isn't defined.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Don't include
<tcb-offsets.h>.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -1,3 +1,13 @@ +2018-02-23 H.J. Lu <hongjiu.lu@intel.com> + + [BZ #22792] + * Makerules ($(common-objpfx)%.h): Pass -DGEN_AS_CONST_HEADERS + to $(CC). + * sysdeps/unix/sysv/linux/i386/lowlevellock.h: Include + <tcb-offsets.h> only if GEN_AS_CONST_HEADERS isn't defined. + * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Don't include + <tcb-offsets.h>. + 2018-02-23 Joseph Myers <joseph@codesourcery.com> [BZ #15105] |