tunables: Avoid getenv calls and disable glibc.malloc.check by default

Builds with --enable-tunables failed on i686 because a call to getenv
got snuck into tunables, which pulled in strncmp.  This patch fixes
this build failure by making the glibc.malloc.check check even
simpler.  The previous approach was convoluted where the tunable was
disabled using an unsetenv and overwriting the tunable value with
colons.  The easier way is to simply mark the tunable as insecure by
default (i.e. won't be read for AT_SECURE programs) and then enabled
only when the /etc/suid-debug file is found.

This also ends up removing a bunch of functions that were specially
reimplemented (strlen, unsetenv) to avoid calling into string
routines.

Tested on x86_64 and i686.

	* elf/dl-tunables.c (tunables_unsetenv): Remove function.
	(min_strlen): Likewise.
	(disable_tunable): Likewise.
	(maybe_disable_malloc_check): Rename to
	maybe_enable_malloc_check.
	(maybe_enable_malloc_check): Enable glibc.malloc.check tunable
	if /etc/suid-debug file exists.
	(__tunables_init): Update caller.
	* elf/dl-tunables.list (glibc.malloc.check): Don't mark as
	secure.

1 files changed, 13 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index 1e2e478580..ce632d70fd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2016-01-10  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+	* elf/dl-tunables.c (tunables_unsetenv): Remove function.
+	(min_strlen): Likewise.
+	(disable_tunable): Likewise.
+	(maybe_disable_malloc_check): Rename to
+	maybe_enable_malloc_check.
+	(maybe_enable_malloc_check): Enable glibc.malloc.check tunable
+	if /etc/suid-debug file exists.
+	(__tunables_init): Update caller.
+	* elf/dl-tunables.list (glibc.malloc.check): Don't mark as
+	secure.
+
 2016-01-10  Torvald Riegel  <triegel@redhat.com>
 
 	* nptl/DESIGN-rwlock.txt: Remove.