diff options
author | Joseph Myers <joseph@codesourcery.com> | 2015-10-07 00:40:12 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2015-10-07 00:40:12 +0000 |
commit | b75bc69cdfe5247b2156ce249518f1c1df4d797d (patch) | |
tree | 7cbc51c7f8a7954e5394fcd873f42f7abeaa22df /ChangeLog | |
parent | a68dec3b03b9c163ad79192cbe837208b2f90de1 (diff) | |
download | glibc-b75bc69cdfe5247b2156ce249518f1c1df4d797d.tar glibc-b75bc69cdfe5247b2156ce249518f1c1df4d797d.tar.gz glibc-b75bc69cdfe5247b2156ce249518f1c1df4d797d.tar.bz2 glibc-b75bc69cdfe5247b2156ce249518f1c1df4d797d.zip |
Don't use dbl-64/wordsize-64 lround based on llround for ILP32 (bug 19079).
The implementation of lround in dbl-64/wordsize-64 as an alias or
wrapper for llround is always incorrect when long is not 64-bit,
because it misses required exceptions in overflow cases, as shown by
my recently added tests. This patch removes that alias / wrapper in
the non-LP64 case, together with the REGISTER_CAST_INT32_TO_INT64
macro, restoring the previous version of lround for dbl-64/wordsize-64
(newly conditioned on !_LP64).
Tested for x86_64, and for mips64 with use of dbl-64/wordsize-64
enabled.
[BZ #19079]
* sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c: Restore previous
file, conditioned on [!_LP64].
* sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c
[!_LP64] (__lround): Do not define as function or alias.
[!_LP64] (lround): Likewise.
[!_LP64] (__lroundl): Likewise.
[!_LP64] (lroundl): Likewise.
* sysdeps/tile/sysdep.h (REGISTER_CAST_INT32_TO_INT64): Remove
macro.
* sysdeps/x86_64/x32/sysdep.h (REGISTER_CAST_INT32_TO_INT64):
Likewise.
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 15 |
1 files changed, 15 insertions, 0 deletions
@@ -1,3 +1,18 @@ +2015-10-07 Joseph Myers <joseph@codesourcery.com> + + [BZ #19079] + * sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c: Restore previous + file, conditioned on [!_LP64]. + * sysdeps/ieee754/dbl-64/wordsize-64/s_llround.c + [!_LP64] (__lround): Do not define as function or alias. + [!_LP64] (lround): Likewise. + [!_LP64] (__lroundl): Likewise. + [!_LP64] (lroundl): Likewise. + * sysdeps/tile/sysdep.h (REGISTER_CAST_INT32_TO_INT64): Remove + macro. + * sysdeps/x86_64/x32/sysdep.h (REGISTER_CAST_INT32_TO_INT64): + Likewise. + 2015-10-06 Joseph Myers <joseph@codesourcery.com> * math/libm-test.inc (lrint_test_data): Add more tests. |