diff options
author | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2022-06-21 14:43:30 +0100 |
---|---|---|
committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2022-10-27 14:46:46 +0100 |
commit | 36cb53c9c848cba09e609f136689943e445d6d36 (patch) | |
tree | f48f19a5bb811b2fc7b77af13cb68939e1b47417 | |
parent | d549598009b8f9b795b8d6359f0b2b27418221e3 (diff) | |
download | glibc-36cb53c9c848cba09e609f136689943e445d6d36.tar glibc-36cb53c9c848cba09e609f136689943e445d6d36.tar.gz glibc-36cb53c9c848cba09e609f136689943e445d6d36.tar.bz2 glibc-36cb53c9c848cba09e609f136689943e445d6d36.zip |
Fix invalid pointer dereference in wcscpy_chk
The src pointer is const and points to a different object, so accessing
dest via src is invalid.
-rw-r--r-- | debug/wcscpy_chk.c | 34 |
1 files changed, 7 insertions, 27 deletions
diff --git a/debug/wcscpy_chk.c b/debug/wcscpy_chk.c index 8ef03f81e4..d2dc769181 100644 --- a/debug/wcscpy_chk.c +++ b/debug/wcscpy_chk.c @@ -24,36 +24,16 @@ wchar_t * __wcscpy_chk (wchar_t *dest, const wchar_t *src, size_t n) { wint_t c; - wchar_t *wcp; + wchar_t *wcp = dest; - if (__alignof__ (wchar_t) >= sizeof (wchar_t)) + do { - const ptrdiff_t off = dest - src - 1; - - wcp = (wchar_t *) src; - - do - { - if (__glibc_unlikely (n-- == 0)) - __chk_fail (); - c = *wcp++; - wcp[off] = c; - } - while (c != L'\0'); - } - else - { - wcp = dest; - - do - { - if (__glibc_unlikely (n-- == 0)) - __chk_fail (); - c = *src++; - *wcp++ = c; - } - while (c != L'\0'); + if (__glibc_unlikely (n-- == 0)) + __chk_fail (); + c = *src++; + *wcp++ = c; } + while (c != L'\0'); return dest; } |