diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2018-02-05 06:07:54 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2018-02-05 06:08:07 -0800 |
| commit | 06fbebfff79abaa825ec8ad846deb05887e34f37 (patch) | |
| tree | 43715ef186a1f2934e388adc2372b2ee5afc0355 | |
| parent | 371b220f6208968d5f4bffc9f66bf885930a42a5 (diff) | |
| download | glibc-06fbebfff79abaa825ec8ad846deb05887e34f37.tar glibc-06fbebfff79abaa825ec8ad846deb05887e34f37.tar.gz glibc-06fbebfff79abaa825ec8ad846deb05887e34f37.tar.bz2 glibc-06fbebfff79abaa825ec8ad846deb05887e34f37.zip | |
x86-64: Use __glibc_likely/__glibc_likely in dl-machine.h
The differences in elf/dl-reloc.os are
--- before 2018-02-05 03:52:32.803125207 -0800
+++ after 2018-02-05 03:52:14.913711879 -0800
@@ -1129,7 +1129,7 @@ _dl_relocate_object:
leaq __PRETTY_FUNCTION__.9767(%rip), %rcx
leaq .LC11(%rip), %rsi
leaq .LC12(%rip), %rdi
- movl $540, %edx
+ movl $539, %edx
call __GI___assert_fail
.p2align 4,,10
.p2align 3
* sysdeps/x86_64/dl-machine.h (elf_machine_rela): Replace
__builtin_expect with __glibc_likely and __glibc_likely.
(elf_machine_lazy_rel): Likewise.
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | sysdeps/x86_64/dl-machine.h | 14 |
2 files changed, 13 insertions, 7 deletions
@@ -1,5 +1,11 @@ 2018-02-05 H.J. Lu <hongjiu.lu@intel.com> + * sysdeps/x86_64/dl-machine.h (elf_machine_rela): Replace + __builtin_expect with __glibc_likely and __glibc_likely. + (elf_machine_lazy_rel): Likewise. + +2018-02-05 H.J. Lu <hongjiu.lu@intel.com> + [BZ #22638] * sysdeps/sparc/sparc32/start.S (_start): Check PIC instead of SHARED. diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h index f525600071..2201818aa6 100644 --- a/sysdeps/x86_64/dl-machine.h +++ b/sysdeps/x86_64/dl-machine.h @@ -310,10 +310,9 @@ elf_machine_rela (struct link_map *map, const ElfW(Rela) *reloc, : (ElfW(Addr)) sym_map->l_addr + sym->st_value); if (sym != NULL - && __builtin_expect (ELFW(ST_TYPE) (sym->st_info) == STT_GNU_IFUNC, - 0) - && __builtin_expect (sym->st_shndx != SHN_UNDEF, 1) - && __builtin_expect (!skip_ifunc, 1)) + && __glibc_unlikely (ELFW(ST_TYPE) (sym->st_info) == STT_GNU_IFUNC) + && __glibc_likely (sym->st_shndx != SHN_UNDEF) + && __glibc_likely (!skip_ifunc)) { # ifndef RTLD_BOOTSTRAP if (sym_map != map @@ -500,8 +499,8 @@ elf_machine_rela (struct link_map *map, const ElfW(Rela) *reloc, break; memcpy (reloc_addr_arg, (void *) value, MIN (sym->st_size, refsym->st_size)); - if (__builtin_expect (sym->st_size > refsym->st_size, 0) - || (__builtin_expect (sym->st_size < refsym->st_size, 0) + if (__glibc_unlikely (sym->st_size > refsym->st_size) + || (__glibc_unlikely (sym->st_size < refsym->st_size) && GLRO(dl_verbose))) { fmt = "\ @@ -554,7 +553,8 @@ elf_machine_lazy_rel (struct link_map *map, /* Check for unexpected PLT reloc type. */ if (__glibc_likely (r_type == R_X86_64_JUMP_SLOT)) { - if (__builtin_expect (map->l_mach.plt, 0) == 0) + /* Prelink has been deprecated. */ + if (__glibc_likely (map->l_mach.plt == 0)) *reloc_addr += l_addr; else *reloc_addr = |