summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYuutaW <17158086+trumeet@users.noreply.github.com>2019-04-13 15:06:39 -0700
committerYuutaW <17158086+Trumeet@users.noreply.github.com>2019-04-13 15:06:39 -0700
commit36fa091e301decac3ad77ca8dd219d77bcd73613 (patch)
tree8d39be6e9f5a3ed4d9801cf2482ce82612c56847
parentaee4c4f0f4c644dd024cef2c5fa084af0684c1ac (diff)
downloadFlow-36fa091e301decac3ad77ca8dd219d77bcd73613.tar
Flow-36fa091e301decac3ad77ca8dd219d77bcd73613.tar.gz
Flow-36fa091e301decac3ad77ca8dd219d77bcd73613.tar.bz2
Flow-36fa091e301decac3ad77ca8dd219d77bcd73613.zip
feat(app/library): now no need to place mInfo init sentence in the constructor block
Signed-off-by: YuutaW <17158086+Trumeet@users.noreply.github.com>
-rw-r--r--app/src/main/java/moe/yuuta/flow/MainActivity.java16
-rw-r--r--library/src/main/java/moe/yuuta/flow/FlowFragment.java2
2 files changed, 11 insertions, 7 deletions
diff --git a/app/src/main/java/moe/yuuta/flow/MainActivity.java b/app/src/main/java/moe/yuuta/flow/MainActivity.java
index d827aa6..e432ee5 100644
--- a/app/src/main/java/moe/yuuta/flow/MainActivity.java
+++ b/app/src/main/java/moe/yuuta/flow/MainActivity.java
@@ -39,13 +39,11 @@ public class MainActivity extends AppCompatActivity {
}
public static class Page1 extends PageFragment {
- public Page1() {
- mInfo = new FlowInfo(new HeaderConfig("Page 1", "lol", false), null);
- }
@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
+ mInfo = new FlowInfo(new HeaderConfig("Page 1", "lol", false), null);
}
@Nullable
@@ -58,7 +56,9 @@ public class MainActivity extends AppCompatActivity {
}
public static class Page2 extends PageFragment {
- public Page2() {
+ @Override
+ public void onCreate(@Nullable Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
mInfo = new FlowInfo(new HeaderConfig("Page 2", "built with love", false), null);
}
@@ -76,7 +76,9 @@ public class MainActivity extends AppCompatActivity {
}
public static class Page3 extends PageFragment {
- public Page3() {
+ @Override
+ public void onCreate(@Nullable Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
mInfo = new FlowInfo(new HeaderConfig("Page 3", "zzz~", true), null);
}
@@ -97,7 +99,9 @@ public class MainActivity extends AppCompatActivity {
}
public static class Page4 extends PageFragment {
- public Page4() {
+ @Override
+ public void onCreate(@Nullable Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
mInfo = new FlowInfo(new HeaderConfig("Page 4", "just a counter", false), null);
}
diff --git a/library/src/main/java/moe/yuuta/flow/FlowFragment.java b/library/src/main/java/moe/yuuta/flow/FlowFragment.java
index 87deaf2..060e1a3 100644
--- a/library/src/main/java/moe/yuuta/flow/FlowFragment.java
+++ b/library/src/main/java/moe/yuuta/flow/FlowFragment.java
@@ -42,7 +42,7 @@ public final class FlowFragment extends Fragment implements IFlowFragment, View.
}
mPages = pages;
// Because this method can be called before setting up the layout, so we need to schedule it until the layout is set up.
- notifyCurrentFlowInfoUpdated();
+ // notifyCurrentFlowInfoUpdated();
}
/**