summaryrefslogtreecommitdiff
path: root/vp8
AgeCommit message (Collapse)Author
2012-10-16Fix a mismatch if a keyframe contains skip-blocks.Ronald S. Bultje
Change-Id: I0681d3183f51627be8c2bb76f343b7270f9116d8
2012-10-15Merge "Remove test from B_MODE_INFO." into experimentalRonald S. Bultje
2012-10-15Merge "Remove mode_rdopt from MB_MODE_INFO." into experimentalRonald S. Bultje
2012-10-15Merge "Properly use chroma block object for chroma coefficient costing." ↵Ronald S. Bultje
into experimental
2012-10-15Merge "Changed to use real pixels only for evaluating MVs" into experimentalYaowu Xu
2012-10-15Changed to use real pixels only for evaluating MVsYaowu Xu
The commit changed to avoid using pixels from extended border in in evaluating and select best reference motion vector. Change-Id: I39b758889373e42ed2889d59744388e5b9c1a20a
2012-10-15Remove test from B_MODE_INFO.Ronald S. Bultje
It is essentially a duplicate of mode for RD-only purposes. Removing it saves us 4 bytes per B_MODE_INFO, or ~0.5MB for a 1080p video encode. Change-Id: I0a54db5f51658b3946d7efb1ca6e8cfbda0cdf88
2012-10-15Remove mode_rdopt from MB_MODE_INFO.Ronald S. Bultje
The variable is essentially a duplicate of mode for RD-only purposes. Removing it gives identical results, and saves 4 bytes per macroblock (i.e. 32.5kB for a 1080p HD video encode). Change-Id: I22d5058fdb80ab0b69862caee825e9d86bb148b3
2012-10-15Properly use chroma block object for chroma coefficient costing.Ronald S. Bultje
Change-Id: Ieb38c7aae91dbaca4a8add204fa84e1cfc459933
2012-10-15Add a new token stuffing function vp8_stuff_mb().Ronald S. Bultje
This way a caller doesn't need to implement the logic for which (and how many) tokens to write out to stuff one macroblock worth of EOBs. Make the actual function implementations static, since they are now only used in tokenize.c; also do some minor stylistic changes so it follows the style guide a little more closely; use PLANE_TYPE where appropriate, remove old (stale) frame_type function arguments; hardcode plane type where only a single one is possible (2nd order DC or U/V EOB stuffing); support stuffing 8x8/4x4 transform EOBs with no 2nd order DC. Change-Id: Ia448e251d19a4e3182eddeb9edd034bd7dc16fa3
2012-10-15Add and consistently use PLANE_TYPE.Ronald S. Bultje
Change the macros PLANE_TYPE_{Y_NO_DC,Y2,UV,Y_WITH_DC} to a typed enum, and use this typed enum consistently across all places where relevant. In places where the type is implied (e.g. in functions that only handle second order planes or chroma planes), remove it as a function argument and instead hardcode the proper enum in the code directly. Change-Id: I93652b4a36aa43163d49c732b0bf5c4442738c47
2012-10-15Merge duplicate loops in tokenization code.Ronald S. Bultje
Also merge the three occurrences of 4x4 chroma block writing into a single function, and call that function instead of duplicating the 4x4 chroma tokenization code in 3 places. Change-Id: I7913538d1029f709b0e3ae49fff1148d3be9eeb9
2012-10-14Minor refactoring in encodeintra.c.Ronald S. Bultje
Merge code blocks for different transform sizes; use MACROBLOCKD as a temp variable where that leads to smaller overall source code; remove duplicate code under #if CONFIG_HYBRIDTRANSFORM/#else blocks. Some style changes to make it follow the style guide a little better. Change-Id: I1870a06dae298243db46e14c6729c96c66196525
2012-10-14Make optimize_mb_16x16() static.Ronald S. Bultje
It is not used outside this file. Change-Id: Id0947180edab4c5f1f50589863350b21e97c25f1
2012-10-14Remove assignment in vp8_optimize_mby_16x16().Ronald S. Bultje
The result of the assignment is unused. Change-Id: Id94b790baa6451f24e9aeda6f036390388d93921
2012-10-14Remove duplicate code in optimize_mb_NxN vs. vp8_optimize_mby/uv_NxN().Ronald S. Bultje
Instead, just call vp8_optimize_mby/uv_NxN() inside optimize_mb_NxN(). Change-Id: Ief941064d86db4277ba02e990a26819144b55f7c
2012-10-14Remove duplicate or unused code in encoder/encodemb.c.Ronald S. Bultje
Also make some minor stylistic changes to bring the code closer to the style guide. Remove distinction between inter and intra transform functions, since both do exactly the same thing except for the check against SPLITMV for the second-order transform. Remove some commented out debug code. Remove 8x8/16x16 transform code in encode_inter16x16y(), since the first-pass only uses 4x4 anyway. Change-Id: Ife54816ff759825b9141f95dc2ba43c253c14dba
2012-10-14Remove duplicate or unused code in encoder/quantize.c.Ronald S. Bultje
Also make some minor stylistic changes to bring the code closer to the style guide. Remove checks against i8x8/bpred in the mb-codepath, since these do individual block reconstruction and thus don't go through this codepath. Change-Id: I4dfcf8f78746f4647a206475acf731837aa4fd47
2012-10-14Remove duplicate or unused code in common/invtrans.c.Ronald S. Bultje
Also make some minor stylistic changes to bring the code closer to the style guide. Change-Id: Idafa280724f49868ed6b7d65b7fd9227d781994b
2012-10-14Add a _4x4 sufix to all 4x4-transform-related functions.Ronald S. Bultje
This includes trellis optimization, forward/inverse transform, quantization, tokenization and stuffing functions. Change-Id: Ibd34132e1bf0cd667671a57b3f25b3d361b9bf8a
2012-10-14Replace vp8_inverse_htransform_b() by direct call to vp8_ihtllm_c().Ronald S. Bultje
Change-Id: I55ee7566341b04d7e7340fdab95189f82231a792
2012-10-13Revert "removed the recon. rtcd invoke macro code"Jim Bankoski
This reverts commit 2113a831575d81faeadd9966e256d58b6b2b1633
2012-10-13removed the recon. rtcd invoke macro codeJim Bankoski
Code clean up - removed rtcd Change-Id: Id963ecf53c370b1d99484ef18d6befeed7e0c748
2012-10-12Merge "Remove reverting of tx-select if only a single txfm-size is used." ↵Adrian Grange
into experimental
2012-10-12removed the dependency cross key frame boundaryYaowu Xu
This allowed decoding from any key frame after skipping the frames prior. Change-Id: I096fccad5346d75ae50a017c94eb8d772a7e8b00
2012-10-12Remove reverting of tx-select if only a single txfm-size is used.Ronald S. Bultje
Entropy coding takes care of this anyway, and this causes changes to the txfm size assigned to skip blocks, which can affect the loopfilter output, thus causing encoder/decoding mismatches. Change-Id: I591a8d8a4758a507986b751a9f83e6d76e406998
2012-10-12Remove CONFIG_TX16X16, since the experiment was merged.Ronald S. Bultje
Change-Id: Ib74824c824f7ebb279e7df8eb32440d4d65fbd79
2012-10-11Use transform-size selection for i8x8_pred also.Ronald S. Bultje
Change-Id: Iecb282fc89f9b5145ef31c5eda294ad42bc32a5d
2012-10-10Merge of the TX_16X16 experimentDeb Mukherjee
Change-Id: I22aa803ffff330622cdb77277e7b196a9766f882
2012-10-10Merge "Removing dr[16] from VP8D_COMP" into experimentalScott LaVarnway
2012-10-10Merge "write_kfmodes: use update_skip_probs()" into experimentalJohn Koleszar
2012-10-10Merge "convert copy16x16 to rtcd" into experimentalPaul Wilkins
2012-10-09convert copy16x16 to rtcdJim Bankoski
Convert copy16x16 from invoke to rtcd. The first in a long string of converts. Change-Id: I296b0aa32f40e9fb649f7a3cb914a4e5300cad63
2012-10-09Removing dr[16] from VP8D_COMPScott LaVarnway
Currently not used. Also using this as a test commit into the experimental branch. Change-Id: I68c479461ae02f1c7a7f75fa02d1fc0db84bf198
2012-10-09write_kfmodes: use update_skip_probs()John Koleszar
Use the common update_skip_probs() function rather than duplicating its logic in write_kf_modes(). Change-Id: I2890a28f6907cb79ffe0fb21d20f0ef98b85cdd9
2012-10-09Selectable transform size try 2.Ronald S. Bultje
Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16 or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2% and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx) about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%. Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
2012-10-05Merge "Mismatch bug-fix when transform expts are off" into experimentalDeb Mukherjee
2012-10-05Mismatch bug-fix when transform expts are offDeb Mukherjee
A variety of issues related to tangling of various hybrid transform experiments. Change-Id: I84dac65ff513f8b024407760df55fffa95e198de
2012-10-05Fix SIMD unsafe use of floating point.Paul Wilkins
This commit fixes unsafe simd / floating point interactions arising from the current hybrid and 16x16 transform implementation. These led to a raft of bugs and issues when the project was built using VS2008 for Win32 though they did not show up with the unix builds. Gerrit makes a meal out of presenting the fix but all I have actually done is indent the body of each function that uses floating point by one level and bracket with emms instructions using the function vp8_clear_system_state(). See below. function () { vp8_clear_system_state(); { ... function body } vp8_clear_system_state(); } This is almost certainly over the top in terms of number of emms instructions but is a temporary measure pending implementation of integer variants of each function to replace the floating point. Limited testing suggests that this fixes the problems that arose for Win32 VS2008 when the hybrid or 16x16 transforms were enabled. Change-Id: I7c9a72bd79315246ed880578dec51e2b7c178442
2012-09-27Entropy coding for hybrid transformDeb Mukherjee
Separates the entropy coding context models for 4x4, 8x8 and 16x16 ADST variants. There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%. Results on derf/yt are about the same, probably because there is not enough statistics. Results may improve somewhat once the initial probability tables are updated for the hybrid transforms which is coming soon. Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
2012-09-21Separating 8x8DCT use from hybridtransform8x8Deb Mukherjee
With this change, even if hybridtransform8x8 experiment is off, 8x8 dct is used for the I8x8 mode. However note that the gains observed with the hybridtransform8x8 experiment will now be less, since part of the gain is now merged in. Change-Id: I9afb3880906fd0a1368a374041fc08efcf060c54
2012-09-20fixed inconsistency of transform size decisionYaowu Xu
for MBs using i8x8 prediciton mode when hybridtransform8x8 is not enabled in configure. Change-Id: I3e3c8bb1c0261108c1c71213ca9557b0ce558036
2012-09-17Added default return value to transform selectorAdrian Grange
The non-void function didn't return a value in the default case. Change-Id: Ie4c965315bedc189d2080dd65cf29d3347661946
2012-09-14removed redundant initializationYaowu Xu
Change-Id: I34569375e520759860504c3dfb17a2c27ceb9aed
2012-09-14Use 3 rows and cols of pixels for ref_mv scoringYaowu Xu
The commit changed to use 3 rows above and 3 cols from left for SAD scoring for selecting the best reference motion vector. The change helped std-hd set by >.2% on psnr/ssim metrics. Change-Id: Ifad3b528d0b4b6e3c22518af789d76eff23c1520
2012-09-13Removed redundant line.Adrian Grange
Removed spurious line that has no effect. Change-Id: I9dc90babbbfcaca049d4a40dc996edc7de123e01
2012-09-12Adds feature for companded MV encodingDeb Mukherjee
The high-precision (1/8) pel bit is turned off if the reference MV is larger than a threshold. The motivation for this patch is the intuition that if motion is likely large (as indicated by the reference), there is likley to be more motion blur, and as a result 1/8 pel precision would be wasteful both in rd sense as well as computationally. The feature is incorporated as part of the newmventropy experiment. There is a modest RD improvement with the patch. Overall the results with the newmventropy experiment with the threshold being 16 integer pels are: derf: +0.279% std-hd: +0.617% hd: +1.299% yt: +0.822% With threshold 8 integer pels are: derf: +0.295% std-hd: +0.623% hd: +1.365% yt: +0.847% Patch: rebased Patch: rebase fixes Change-Id: I4ed14600df3c457944e6541ed407cb6e91fe428b
2012-09-11Cleanups for hybrid transformDeb Mukherjee
Some cleanups on the transform size and type selection logic. Change-Id: If2e9675459482242cf83b4f7de7634505e3f6dac
2012-09-11Merge "Revert "Hybrid transform cleanups"" into experimentalYaowu Xu
2012-09-11Revert "Hybrid transform cleanups"Debargha Mukherjee
This reverts commit c5af82b7ed6d89a4a12003b8d1c6b4befcadce92 There was a mismatch bug introduced by this patch. Hence reverting until it is fixed.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-14 23:32:56 +0000