summaryrefslogtreecommitdiff
path: root/vp8/encoder
AgeCommit message (Collapse)Author
2011-01-31Removed last_auto_filter_prediction_errorScott LaVarnway
last_auto_filter_prediction_error is not really used. Change-Id: Ic6e56c4076bbd250ef783ee1be46964c85f62864
2011-01-31Possible bug in vp8cx_encode_intra_macro_blockScott LaVarnway
vp8_pick_intra4x4mby_modes uses the passed in distortion for an early breakout. The best distortion was never saved and the distortion for TM_PRED was always used. Change-Id: Idbaf73027408a4bba26601713725191a5d7b325e
2011-01-31Merge "Performance improvement of first pass"Scott LaVarnway
2011-01-31Merge "change the threshold of DC check for encode breakout"Yaowu Xu
2011-01-31Merge "Changed condition for using RD in Intra Mode"Adrian Grange
2011-01-28change the threshold of DC check for encode breakoutYaowu Xu
Previously, the DC check is to make sure there is no code-able DC shift for quantizer Q0, which has been verified rather conservative. This commit changes the criteria to have two components, DC and AC, to address the conservativeness. First, it checks if all AC energy is enough to contribute a single non-zero quantized AC coefficient. Second, for DC, the decision to skip further considers two possible scenarios: 1. There is no code-able 2nd order DC coefficient at all; 2 The residue is relatively flat, but the uniform DC change is very small, i.e. less than 1/2 gray level per pixel. Comparing to previous criteria, the new criteria is about 10% to 15% faster in encoding time with a very small quality loss. (threshold ~1000 and quality range 33db-45db) It should be noted that this commit enables "automatic" static threshold for encodebreakout if a non-zero small value is passed in to encoder. Change-Id: I0f77719a1ac2c2dfddbd950d84920df374515ce3
2011-01-28Merge "Adds "armvX-none-rvct" targets"Johann
2011-01-28Changed condition for using RD in Intra ModeAdrian Grange
The condition for using RD when selecting the intra coding mode for a MB is that the RD flag is set AND we're not in real-time mode. Previously the code used RD if either the RD flag was set OR we were not using real-time mode. Change-Id: Ic711151298468a3f99babad39ba8375f66d55a08
2011-01-28Inconsistent distortion metric in vp8_rd_pick_intra_mbuv_modePaul Wilkins
This function was using a variance metric compared to and SSE metric in other places (eg. vp8_rd_inter_uv) Change-Id: I9109fcc5a13bca9db1d7ead500fe14999ab233eb
2011-01-28Adds "armvX-none-rvct" targetsTero Rintaluoma
Adds following targets to configure script to support RVCT compilation without operating system support (for Profiler or bare metal images). - armv5te-none-rvct - armv6-none-rvct - armv7-none-rvct To strip OS specific parts from the code "os_support"-config was added to script and CONFIG_OS_SUPPORT flag is used in the code to exclude OS specific parts such as OS specific includes and function calls for timers and threads etc. This was done to enable RVCT compilation for profiling purposes or running the image on bare metal target with Lauterbach. Removed separate AREA directives for READONLY data in armv6 and neon assembly files to fix the RVCT compilation. Otherwise "ldr <reg>, =label" syntax would have been needed to prevent linker errors. This syntax is not supported by older gnu assemblers. Change-Id: I14f4c68529e8c27397502fbc3010a54e505ddb43
2011-01-27warning: pointer targets differ in signednessJohann
vp8/encoder/rdopt.c:728: warning: pointer targets in passing argument 3 of 'macro_block_yrd' differ in signedness vp8/encoder/rdopt.c:541: note: expected 'int *' but argument is of type 'unsigned int *' distortion is signed when calling macro_block_yrd is both other cases, as well as for RDCOST Change-Id: I5e22358b7da76a116f498793253aac8099cb3461
2011-01-27clean up implicit declaration warnings for neonJohann
Change-Id: I6ca2d89f355839c4c770773c09fc69dcea7c1406 warning: implicit declaration of function 'vp8_variance_halfpixvar16x16_[h|v|hv]_neon' 'vp8_sub_pixel_variance16x16_neon_func'
2011-01-27Merge "Removed unused members from VP8_COMP"Scott LaVarnway
2011-01-27Merge "Remove copies of same functions"Yunqing Wang
2011-01-27Merge "Refine motion vector prediction for NEWMV mode"Yunqing Wang
2011-01-26Performance improvement of first passScott LaVarnway
Improved the performance of the first pass only (~6% on 720p test clip) by making use of LUT instead of the float calculations. Might try a SIMD version later. Also started to make use of int_mv instead of MV. Change-Id: If2a217c7d6b59cd2c25c5553e0ca7e0502403af8
2011-01-26Remove copies of same functionsYunqing Wang
Reduce the code size. Change-Id: I2e1998557a3c8776e262c442fd758c25e17aff7a
2011-01-26Removed unused members from VP8_COMPScott LaVarnway
Change-Id: I8f3f2642b02975fbdb14982984a29821f80d30d3
2011-01-26Rationalize vp8_rd_pick_intra16x16mby_mode()Paul Wilkins
Use the function macro_block_yrd() to calculate error and distortion in keeping with what is done for inter frames. The old code was using a variance metric for once case and an SSE function for measuring distortion in the other case. The function vp8_encode_intra16x16mbyrd() is no longer used. Change-Id: Ic228cb00a78ff637f4365b43f58fbe5a9273d36f
2011-01-26Merge "Correction to buffer update for non-viewable frames."Paul Wilkins
2011-01-26Merge "cap the best quantizer for 2nd order DC"Yaowu Xu
2011-01-26Correction to buffer update for non-viewable frames.Paul Wilkins
The code previously tested cpi->common.refresh_alt_ref_frame but there are situations where this flag may be set for viewable frames. The correct test should be !cm->show_frame. Change-Id: Ia1a600622992a4a68fe1d38ac23bf6b34b133688
2011-01-26Merge "Fix for incorrect variable declaration."Paul Wilkins
2011-01-25cap the best quantizer for 2nd order DCYaowu Xu
This commit also removes artificial RDMULT cap for low quantizers. The intention is to address some abnormal behavior of mode selections at the low quantizer end, where many macroblocks were coded with SPLITMV with all partitions using same motion vector including (0,0). This change improves the compression quality substantially for high quality encodings in both PSNR and SSIM terms. Overall effect on mid/low rate range is also positive for all metrics, but smaller in magnitude. Change-Id: I864b29c4bd9ff610d2545fa94a19cc7e80c02667
2011-01-25Fix for incorrect variable declaration.Fritz Koenig
Commit 336aa0b7da8a35ba57400ce92fc016fc7fb35233 incorrectly declared current_pos as and int, when it should have been a FIRSTPASS_STATS pointer. Change-Id: I0a51c7a86ebba8546c95dd5d9d1c1143d4613e40
2011-01-25Merge "update sse2 regular quantizer"Johann
2011-01-25Merge "move new neon subpixel function"Johann
2011-01-25Refine motion vector prediction for NEWMV modeYunqing Wang
Adjust checking points in motion vector prediction to better cover possible movements, and get a better prediction. Tests on test clips showed a 0.1% improvement in SSIM, and no change in PSNR and performance. Change-Id: Ifdab05d35e10faea1445c61bb73debf888c9d2f8
2011-01-25Merge "Fix issue 262, vp8cx_pack_tokens_into_partitions_armv5"Johann
2011-01-25move new neon subpixel functionJohann
previously wasn't guarded with ifdef ARMV7, causing a link error with ARMV6 Change-Id: I0526858be0b5f49b2bf11e9090180b2a6c48926d
2011-01-25Merge "Modify calling of NEON code in sub-pixel search"Yunqing Wang
2011-01-25Fix issue 262, vp8cx_pack_tokens_into_partitions_armv5Attila Nagy
http://code.google.com/p/webm/issues/detail?id=262 Function was asuming that partitions have equal amount of mb_rows, which is not always true. Change-Id: I59ed40117fd408392a85c633beeb5340ed2f4b25
2011-01-25Merge "Incorrect bit allocation in forced KF groups."Paul Wilkins
2011-01-25Incorrect bit allocation in forced KF groups.Paul Wilkins
The old 2 pass code estimated error distribution when coding a forced (by interval) key frame. The result of this was that in some cases, when allocating bits at the GF group level within a KF group there was either a glut of bits or starvation of bits at the end of the KF group. Added code to rescan and get the correct data once the position of a forced key frame has been determined. Change-Id: I0c811675ef3f9e4109d14bd049d7641682ffcf11
2011-01-24Added vp8_update_zbin_extraScott LaVarnway
vp8cx_mb_init_quantizer was being called for every mode checked in vp8_rd_pick_inter_mode. zbin_extra is the only value that really needs to be recalculated. This calculation is disabled when using the fast quantizer for mode selection. This gave a small performance boost (~.5% to 1%). Note: This needs to be verified with segmentation_enabled. Change-Id: I62716a870b3c82b4a998bdf95130ff0b02106f1e
2011-01-21Merge "Modify sub-pixel filters to eliminate unnecessary calculations"Yunqing Wang
2011-01-21Modify sub-pixel filters to eliminate unnecessary calculationsYunqing Wang
In sub-pixel calculation, xoffset and yoffset mostly take some specific values. Modified sub-pixel filter functions according to these possible values to improve performance. Change-Id: I83083570af8b00ff65093467914fbb97a4e9ea21
2011-01-21Modified static scene check.Paul Wilkins
Added code to scan ahead a few frames when we see what we think is a static scene in the two pass GF loop to see if the conditions persist. Moved calculation of decay rate out into a fuunction. Change-Id: I6e9c67e01ec9f555144deafc8ae67ef25bffb449
2011-01-20Further work to reduce pulsing.Paul Wilkins
These changes are specifically targeted at fade transitions to static scenes. Here we want to place a GF/ARF immediately after the fade and prevent an ARF just before the fade. Also some code lines and comment lines shortened to 80 chars while I was there. Change-Id: Iefdc09a4fa7b265048fc017246b73e138693950f
2011-01-20Fixed use of motion percentage in KF/GF group calcAdrian Grange
In both vp8_find_next_key_frame and define_gf_group, motion_pct was initialised at the top of the loop before next_frame stats had been read in. This fix sets motion_pct after next_frame stats have been read. Change-Id: I8c0bebf372ef8aa97b97fd35b42973d1d831ee73
2011-01-19First pass loop bug.Paul Wilkins
Incorrect value loop_decay_rate used in GF loop. The intent was to test the cumulative value decay_accumulator. Change-Id: I62928c63eb09f4f6936a45ebd1c23784d1c9681b
2011-01-18Modify calling of NEON code in sub-pixel searchYunqing Wang
In vp8_find_best_sub_pixel_step_iteratively(), many times xoffset and yoffset are specific values - (4,0) (0,4) and (4,4). Modified code to call simplified NEON version at these specific offsets to help with the performance. Change-Id: Iaf896a0f7aae4697bd36a49e182525dd1ef1ab4d
2011-01-18vp8e -removed undefined max callJim Bankoski
Change-Id: I42a86b0488f44115f09551fc5ad6d711fd470f0d
2011-01-18Merge "Further CQ, Key frame and ARF changes"Paul Wilkins
2011-01-18Further CQ, Key frame and ARF changesPaul Wilkins
This code fixes a bug in the calculation of the minimum Q for alt ref frames. It also allows an extended gf/arf interval for sections of clips that completely static (or nearly so). Change-Id: I1a21aaa16d4f0578e5f99b13bebd78d59403c73b
2011-01-18Fix encoder real-time only configuration.Attila Nagy
Remove allocation/deallocation of stats storage. Remove full search functions in machine specific encoder inits. Remove last pass validation in validate_config. Change-Id: I7f29be69273981a4fef6e80ecdb6217c68cbad4e
2011-01-17Fix CQ range and experimental KF sizing changes.Paul Wilkins
The CQ level was not using the q_trans[] array to convert to a 0-127 range as per min and maxq Experimental change to try and match the reconstruction error for forced key frames approximately to that of the previous frame by means of the recode loop. Though this may cause extra recodes and the recode behavior has not been optimized, it can only happen on forced key frames. Change-Id: I1f7e42d526f1b1cb556dd461eff1a692bd1b5b2f
2011-01-14update sse2 regular quantizerJohann
about ~5% gain on 32bit. disabled for 64bit unset executable bit on ssse3 version (cosmetic) Change-Id: I1a5860839eb294ce4261f819caea2dcfa78e57ca
2011-01-14Merge "KF/GF Pulsing"Paul Wilkins
2011-01-14Merge "Testing of modes with Alt Ref frame"Paul Wilkins