summaryrefslogtreecommitdiff
path: root/vp8/decoder
AgeCommit message (Collapse)Author
2012-10-24Fix bad merge of coef_probs updateJohn Koleszar
Stray CONFIG_HYBRIDTRANSFORM caused decode mismatch. Change-Id: I1d77bad9b366f7a6ceb3cb45269ed5badb5c4c53
2012-10-24coef_probs: remove duplicate read/update codeJohn Koleszar
Refactor per-transform copy & paste into a common function update_coef_probs_common() and read_coef_probs_common(). The dry-run and bit-writing loops in the encoder are still obvious candidates to be made common, but they start to diverge a bit in the next commit, so are left as-is for now. Change-Id: I896bd3f4a073a6296eab7e92463fef79d8c6c08c
2012-10-23Merging in the Switchable interp experimentDeb Mukherjee
There is a macro DEFAULT_INTERP_FILTER defined in encoder/onyx_if.c that is set as EIGHTTAP for now - so SWITCHABLE is not really used. Ideally, this should be SWITCHABLE but that would make the encoder quite a bit slower. We will change the default filter to SWITCHABLE once we find a faster way to search for switchable filters. Change-Id: Iee91832cdc07e6e14108d9b543130fdd12fc9874
2012-10-22Merge "Change entropy context assignment style from *(x + y) = z to x[y] = ↵Ronald S. Bultje
z." into experimental
2012-10-22Merging in the TX_SELECT experimentDeb Mukherjee
Change-Id: I0d306b0062be59bc785b65882691c956c8b5e7c8
2012-10-22Merge of the newmventropy experimentDeb Mukherjee
Removes the old mv encoding code. Change-Id: I1026d48cc5ac15ccb776f98463e929254c3dc7da
2012-10-22Change entropy context assignment style from *(x + y) = z to x[y] = z.Ronald S. Bultje
Change-Id: Ibc4425bb6e01606751021e57c93106c365a2da21
2012-10-22Merge changes I02e7f64a,Ide954b00,Idc8b5977 into experimentalRonald S. Bultje
* changes: Fix another typo in 4x4-transform-for-i8x8-intra-pred coeff contexts. 8x8 transform support in splitmv. Use SPLITMV_PARTITIONING instead of a plain integer type.
2012-10-22Merging the hybrid transform experimentsDeb Mukherjee
Change-Id: I99f1982b30a630a9a070a8326d83b34a33cba14c
2012-10-228x8 transform support in splitmv.Ronald S. Bultje
For splitmv, where partitioning is 8x16, 16x8 or 8x8, this patch uses the 8x8 transform (instead of the 4x4) if txfm_mode is ALLOW_8X8 or ALLOW_16X16. For TX_MODE_SELECT, splitmv can indicate which of the 2 transform sizes (4x4 or 8x8) it wants to use. Gains (with hybridtx4x4/8x8/16x16 and tx_select experiments enabled) on derf: +0.9%, HD: +0.4%, STD/HD: +0.8% (SSIM or overall PSNR, both metrics show similar improvements). Change-Id: Ide954b000b415548ed92a7ac78e24f36e60fcf06
2012-10-21Merge "Allow B_VL_PRED & B_LD_PRED modes with Superblocks" into experimentalDeb Mukherjee
2012-10-20Allow B_VL_PRED & B_LD_PRED modes with SuperblocksDeb Mukherjee
Allows B_VL_PRED & B_LD_PRED modes to be used for all blocks within a MB in B_PRED mode. These modes were temporarily disabled with super-block coding. Change-Id: I973b9bdb82c3da5f12d7cc963162a28805f25303
2012-10-19Remove bc, bc2 from pbi,cpi,xdJohn Koleszar
Pass the bool coder to be used explicitly. This avoids cases where two different bool coders can be addressed from the same function. Also be more consistent with bool coder variable naming, start to standardize on 'bc'. Change-Id: I1c95e2fdbe24ebe8c0f84924daa1728e3b054a31
2012-10-19Some cleanups and fixes.Deb Mukherjee
Separates the logic on transform type selection previously spread out over a number of files into a separate function. Currently the tx_type field in b_mode_info is not used, but still left in there to eventually use for signaling the transform type in the bitstream. Also, now for tx_type = DCT_DCT, the regular integer DCT is used, as opposed to the floating point DCT used in conjuction with hybrid transform. Results change somewhat due to the transform change, but are within reasonable limits. The hd/std-hd sets are slightly up, while derf/yt are slightly down. Change-Id: I5776840c2239ca2da31ca6cfd7fd1148dc5f9e0f
2012-10-17Merge "cosmetic: fix '= & ' construct" into experimentalpascal massimino
2012-10-17Merge "consolidate update_mb_segmentation_map data" into experimentalJohn Koleszar
2012-10-17Merge changes Ic711a378,I43a46c36,If19ee74a into experimentalJohn Koleszar
* changes: Move remaining per-frame data into partition 0 Interleave modes/residual per macroblock Force interleaved decoding
2012-10-17cosmetic: fix '= & ' constructJohn Koleszar
remove useless space after address-of operator. Change-Id: I1fb9e82e8d6cf87558fbd454fb5c0f87599ca2ab
2012-10-17Move remaining per-frame data into partition 0John Koleszar
This commit moves a bit of data that ended up packed with the modes/mv/residual partition during the change to interleaved encoding into partition 0 where it belongs. Change-Id: Ic711a378c58d9d6a17254384f492c213a15bad92
2012-10-17Interleave modes/residual per macroblockJohn Koleszar
Packs the bitstream with each mb's residual following its mode/mv information. TODO: There are still a few fields that should be packed into partition 0 but are included in partition 1, due to them being serialized from write_kfmodes/pack_inter_mode_mvs, which execute after the first partition is finalized. These need to be separated out into a separate function, similar to mb_mode_mv_init() in decodemv.c. Change-Id: I43a46c363601ab36954d07ebe498760e1e2e3af4
2012-10-16Force interleaved decodingJohn Koleszar
Rather than decoding all modes/mvs separately, decode them per MB. This forces the mode which was already used form the CONFIG_NEWBESTREFMV and CONFIG_SUPERBLOCKS experiments, and is a precursor to changing to interleaved encoding. Change-Id: If19ee74ac8a987846d1cd0cf2b2e02a82f1a43ad
2012-10-16removed the recon rtcd invoke macro code (unrevert)Jim Bankoski
This reinstates reverted commit 2113a831575d81faeadd9966e256d58b6b2b1633 Change-Id: I9a9af13497d1e58d4f467e3e083fddf06b1b786c
2012-10-15Add and consistently use PLANE_TYPE.Ronald S. Bultje
Change the macros PLANE_TYPE_{Y_NO_DC,Y2,UV,Y_WITH_DC} to a typed enum, and use this typed enum consistently across all places where relevant. In places where the type is implied (e.g. in functions that only handle second order planes or chroma planes), remove it as a function argument and instead hardcode the proper enum in the code directly. Change-Id: I93652b4a36aa43163d49c732b0bf5c4442738c47
2012-10-13Revert "removed the recon. rtcd invoke macro code"Jim Bankoski
This reverts commit 2113a831575d81faeadd9966e256d58b6b2b1633
2012-10-13removed the recon. rtcd invoke macro codeJim Bankoski
Code clean up - removed rtcd Change-Id: Id963ecf53c370b1d99484ef18d6befeed7e0c748
2012-10-12removed the dependency cross key frame boundaryYaowu Xu
This allowed decoding from any key frame after skipping the frames prior. Change-Id: I096fccad5346d75ae50a017c94eb8d772a7e8b00
2012-10-12consolidate update_mb_segmentation_map dataJohn Koleszar
The update_mb_segmentation_map flag was being signalled earlier than other data dependent on that flag. Consolidate this data so it's parsed within the same if-scope as the flag is originally parsed in. Change-Id: I10e90b4f511856445ef75a85a44ff441e1e5e672
2012-10-11Use transform-size selection for i8x8_pred also.Ronald S. Bultje
Change-Id: Iecb282fc89f9b5145ef31c5eda294ad42bc32a5d
2012-10-10Merge of the TX_16X16 experimentDeb Mukherjee
Change-Id: I22aa803ffff330622cdb77277e7b196a9766f882
2012-10-10Merge "Removing dr[16] from VP8D_COMP" into experimentalScott LaVarnway
2012-10-09Removing dr[16] from VP8D_COMPScott LaVarnway
Currently not used. Also using this as a test commit into the experimental branch. Change-Id: I68c479461ae02f1c7a7f75fa02d1fc0db84bf198
2012-10-09Selectable transform size try 2.Ronald S. Bultje
Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16 or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2% and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx) about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%. Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
2012-10-05Mismatch bug-fix when transform expts are offDeb Mukherjee
A variety of issues related to tangling of various hybrid transform experiments. Change-Id: I84dac65ff513f8b024407760df55fffa95e198de
2012-09-27Entropy coding for hybrid transformDeb Mukherjee
Separates the entropy coding context models for 4x4, 8x8 and 16x16 ADST variants. There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%. Results on derf/yt are about the same, probably because there is not enough statistics. Results may improve somewhat once the initial probability tables are updated for the hybrid transforms which is coming soon. Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
2012-09-21Separating 8x8DCT use from hybridtransform8x8Deb Mukherjee
With this change, even if hybridtransform8x8 experiment is off, 8x8 dct is used for the I8x8 mode. However note that the gains observed with the hybridtransform8x8 experiment will now be less, since part of the gain is now merged in. Change-Id: I9afb3880906fd0a1368a374041fc08efcf060c54
2012-09-20fixed inconsistency of transform size decisionYaowu Xu
for MBs using i8x8 prediciton mode when hybridtransform8x8 is not enabled in configure. Change-Id: I3e3c8bb1c0261108c1c71213ca9557b0ce558036
2012-09-12Adds feature for companded MV encodingDeb Mukherjee
The high-precision (1/8) pel bit is turned off if the reference MV is larger than a threshold. The motivation for this patch is the intuition that if motion is likely large (as indicated by the reference), there is likley to be more motion blur, and as a result 1/8 pel precision would be wasteful both in rd sense as well as computationally. The feature is incorporated as part of the newmventropy experiment. There is a modest RD improvement with the patch. Overall the results with the newmventropy experiment with the threshold being 16 integer pels are: derf: +0.279% std-hd: +0.617% hd: +1.299% yt: +0.822% With threshold 8 integer pels are: derf: +0.295% std-hd: +0.623% hd: +1.365% yt: +0.847% Patch: rebased Patch: rebase fixes Change-Id: I4ed14600df3c457944e6541ed407cb6e91fe428b
2012-09-11Cleanups for hybrid transformDeb Mukherjee
Some cleanups on the transform size and type selection logic. Change-Id: If2e9675459482242cf83b4f7de7634505e3f6dac
2012-09-11Merge "Revert "Hybrid transform cleanups"" into experimentalYaowu Xu
2012-09-11Revert "Hybrid transform cleanups"Debargha Mukherjee
This reverts commit c5af82b7ed6d89a4a12003b8d1c6b4befcadce92 There was a mismatch bug introduced by this patch. Hence reverting until it is fixed.
2012-09-10Merge "Hybrid transform cleanups" into experimentalDeb Mukherjee
2012-09-10Hybrid transform cleanupsDeb Mukherjee
Some cleanups that will make it easier to maintain the code and incorporate upcoming changes on entropy coding for the hybrid transforms. Change-Id: I44bdba368f7b8bf203161d7a6d3b1fc2c9e21a8f
2012-09-07Partial merge of NEWBESTREFMV and NEW_MVREF.Paul Wilkins
This commit merges those parts of the CONFIG_NEW_MVREF that specifically relate to choosing a better set of candidate MV references into the NEWBESTREFMV experiment. CONFIG_NEW_MVREF will then be used for changes relating to the explicit coding of a cost optimized MV reference in the bitstream as part of MV coding. Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
2012-09-07MV reference changesPaul Wilkins
Extend experiment to use both vectors from MBs coded using compound prediction as candidates. In final sort only consider best 4 candidates for now but make sure 0,0 is always one of them. Other minor changes to new MV reference code. Pass in Mv list to vp8_find_best_ref_mvs(). Change-Id: Ib96220c33c6b80bd1d5e0fbe8b68121be7997095
2012-09-06New motion vector entropy codingDeb Mukherjee
Adds a new experiment with redesigned/refactored motion vector entropy coding. The patch also takes a first step towards separating the integer and fractional pel components of a MV. However the fractional pel encoding still depends on the integer pel part and so they are not fully independent. Further experiments are in progress to see how much they can be decoupled without affecting performance. All components including entropy coding/decoding, costing for MV search, forward updates and backward updates to probability tables, have been implemented. Results so far: derf: +0.19% std-hd: +0.28% yt: +0.80% hd: +1.15% Patch: Simplifies the fractional pel models: derf: +0.284% std-hd: +0.289% yt: +0.849% hd: +1.254% Patch: Some changes in the models, rebased. derf: +0.330% std-hd: +0.306% yt: +0.816% hd: +1.225% Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
2012-08-30hybrid transform of 16x16 dimensionJingning Han
Enable ADST/DCT of dimension 16x16 for I16X16 modes. This change provides benefits mostly for hd sequences. Set up the framework for selectable transform dimension. Also allowing quantization parameter threshold to control the use of hybrid transform (This is currently disabled by setting threshold always above the quantization parameter. Adaptive thresholding can be built upon this, which will further improve the coding performance.) The coding performance gains (with respect to the codec that has all other configuration settings turned on) are derf: 0.013 yt: 0.086 hd: 0.198 std-hd: 0.501 Change-Id: Ibb4263a61fc74e0b3c345f54d73e8c73552bf926
2012-08-24New Motion Reference SearchPaul Wilkins
Alternative strategy for finding a list of candidate motion vectors to use as reference values in mv coding and as nearest and near. Sort by sad in vp8_find_best_ref_mvs() rather than just pick the best. Allow 0,0 as a best ref option but not a nearest or near unless there are no alternatives. Encode/Decode verified on at least some clips. Some commented out experimental and stats code still in place. Gain over existing code averages about 1% on derf (alll metrics) with improvement on all clips. Other test results pending. The entropy coding of the mode (nearest/near etc) still depends upon and requires the old "findnear" code so this needs looking at and may provide room for further gains. Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
2012-08-21Fix compiler warningsDaniel Kang
Change-Id: I887cdcf90b87736f2a3805420aa41eed93324bee
2012-08-20Fix some compiler warnings.Ronald S. Bultje
Change-Id: Iccb56e3b966d1519ba49dfe4e1396479c6b54a6f
2012-08-20Merge "Superblock coding." into experimentalRonald S. Bultje