summaryrefslogtreecommitdiff
path: root/vp8/common
AgeCommit message (Collapse)Author
2012-10-17Interleave modes/residual per macroblockJohn Koleszar
Packs the bitstream with each mb's residual following its mode/mv information. TODO: There are still a few fields that should be packed into partition 0 but are included in partition 1, due to them being serialized from write_kfmodes/pack_inter_mode_mvs, which execute after the first partition is finalized. These need to be separated out into a separate function, similar to mb_mode_mv_init() in decodemv.c. Change-Id: I43a46c363601ab36954d07ebe498760e1e2e3af4
2012-10-15Merge "Remove test from B_MODE_INFO." into experimentalRonald S. Bultje
2012-10-15Merge "Remove mode_rdopt from MB_MODE_INFO." into experimentalRonald S. Bultje
2012-10-15Merge "Changed to use real pixels only for evaluating MVs" into experimentalYaowu Xu
2012-10-15Changed to use real pixels only for evaluating MVsYaowu Xu
The commit changed to avoid using pixels from extended border in in evaluating and select best reference motion vector. Change-Id: I39b758889373e42ed2889d59744388e5b9c1a20a
2012-10-15Remove test from B_MODE_INFO.Ronald S. Bultje
It is essentially a duplicate of mode for RD-only purposes. Removing it saves us 4 bytes per B_MODE_INFO, or ~0.5MB for a 1080p video encode. Change-Id: I0a54db5f51658b3946d7efb1ca6e8cfbda0cdf88
2012-10-15Remove mode_rdopt from MB_MODE_INFO.Ronald S. Bultje
The variable is essentially a duplicate of mode for RD-only purposes. Removing it gives identical results, and saves 4 bytes per macroblock (i.e. 32.5kB for a 1080p HD video encode). Change-Id: I22d5058fdb80ab0b69862caee825e9d86bb148b3
2012-10-15Add and consistently use PLANE_TYPE.Ronald S. Bultje
Change the macros PLANE_TYPE_{Y_NO_DC,Y2,UV,Y_WITH_DC} to a typed enum, and use this typed enum consistently across all places where relevant. In places where the type is implied (e.g. in functions that only handle second order planes or chroma planes), remove it as a function argument and instead hardcode the proper enum in the code directly. Change-Id: I93652b4a36aa43163d49c732b0bf5c4442738c47
2012-10-14Remove duplicate or unused code in common/invtrans.c.Ronald S. Bultje
Also make some minor stylistic changes to bring the code closer to the style guide. Change-Id: Idafa280724f49868ed6b7d65b7fd9227d781994b
2012-10-14Add a _4x4 sufix to all 4x4-transform-related functions.Ronald S. Bultje
This includes trellis optimization, forward/inverse transform, quantization, tokenization and stuffing functions. Change-Id: Ibd34132e1bf0cd667671a57b3f25b3d361b9bf8a
2012-10-14Replace vp8_inverse_htransform_b() by direct call to vp8_ihtllm_c().Ronald S. Bultje
Change-Id: I55ee7566341b04d7e7340fdab95189f82231a792
2012-10-13Revert "removed the recon. rtcd invoke macro code"Jim Bankoski
This reverts commit 2113a831575d81faeadd9966e256d58b6b2b1633
2012-10-13removed the recon. rtcd invoke macro codeJim Bankoski
Code clean up - removed rtcd Change-Id: Id963ecf53c370b1d99484ef18d6befeed7e0c748
2012-10-12removed the dependency cross key frame boundaryYaowu Xu
This allowed decoding from any key frame after skipping the frames prior. Change-Id: I096fccad5346d75ae50a017c94eb8d772a7e8b00
2012-10-10Merge of the TX_16X16 experimentDeb Mukherjee
Change-Id: I22aa803ffff330622cdb77277e7b196a9766f882
2012-10-10Merge "convert copy16x16 to rtcd" into experimentalPaul Wilkins
2012-10-09convert copy16x16 to rtcdJim Bankoski
Convert copy16x16 from invoke to rtcd. The first in a long string of converts. Change-Id: I296b0aa32f40e9fb649f7a3cb914a4e5300cad63
2012-10-09Selectable transform size try 2.Ronald S. Bultje
Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16 or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2% and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx) about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%. Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
2012-10-05Merge "Mismatch bug-fix when transform expts are off" into experimentalDeb Mukherjee
2012-10-05Mismatch bug-fix when transform expts are offDeb Mukherjee
A variety of issues related to tangling of various hybrid transform experiments. Change-Id: I84dac65ff513f8b024407760df55fffa95e198de
2012-10-05Fix SIMD unsafe use of floating point.Paul Wilkins
This commit fixes unsafe simd / floating point interactions arising from the current hybrid and 16x16 transform implementation. These led to a raft of bugs and issues when the project was built using VS2008 for Win32 though they did not show up with the unix builds. Gerrit makes a meal out of presenting the fix but all I have actually done is indent the body of each function that uses floating point by one level and bracket with emms instructions using the function vp8_clear_system_state(). See below. function () { vp8_clear_system_state(); { ... function body } vp8_clear_system_state(); } This is almost certainly over the top in terms of number of emms instructions but is a temporary measure pending implementation of integer variants of each function to replace the floating point. Limited testing suggests that this fixes the problems that arose for Win32 VS2008 when the hybrid or 16x16 transforms were enabled. Change-Id: I7c9a72bd79315246ed880578dec51e2b7c178442
2012-09-27Entropy coding for hybrid transformDeb Mukherjee
Separates the entropy coding context models for 4x4, 8x8 and 16x16 ADST variants. There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%. Results on derf/yt are about the same, probably because there is not enough statistics. Results may improve somewhat once the initial probability tables are updated for the hybrid transforms which is coming soon. Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
2012-09-21Separating 8x8DCT use from hybridtransform8x8Deb Mukherjee
With this change, even if hybridtransform8x8 experiment is off, 8x8 dct is used for the I8x8 mode. However note that the gains observed with the hybridtransform8x8 experiment will now be less, since part of the gain is now merged in. Change-Id: I9afb3880906fd0a1368a374041fc08efcf060c54
2012-09-20fixed inconsistency of transform size decisionYaowu Xu
for MBs using i8x8 prediciton mode when hybridtransform8x8 is not enabled in configure. Change-Id: I3e3c8bb1c0261108c1c71213ca9557b0ce558036
2012-09-17Added default return value to transform selectorAdrian Grange
The non-void function didn't return a value in the default case. Change-Id: Ie4c965315bedc189d2080dd65cf29d3347661946
2012-09-14Use 3 rows and cols of pixels for ref_mv scoringYaowu Xu
The commit changed to use 3 rows above and 3 cols from left for SAD scoring for selecting the best reference motion vector. The change helped std-hd set by >.2% on psnr/ssim metrics. Change-Id: Ifad3b528d0b4b6e3c22518af789d76eff23c1520
2012-09-12Adds feature for companded MV encodingDeb Mukherjee
The high-precision (1/8) pel bit is turned off if the reference MV is larger than a threshold. The motivation for this patch is the intuition that if motion is likely large (as indicated by the reference), there is likley to be more motion blur, and as a result 1/8 pel precision would be wasteful both in rd sense as well as computationally. The feature is incorporated as part of the newmventropy experiment. There is a modest RD improvement with the patch. Overall the results with the newmventropy experiment with the threshold being 16 integer pels are: derf: +0.279% std-hd: +0.617% hd: +1.299% yt: +0.822% With threshold 8 integer pels are: derf: +0.295% std-hd: +0.623% hd: +1.365% yt: +0.847% Patch: rebased Patch: rebase fixes Change-Id: I4ed14600df3c457944e6541ed407cb6e91fe428b
2012-09-11Cleanups for hybrid transformDeb Mukherjee
Some cleanups on the transform size and type selection logic. Change-Id: If2e9675459482242cf83b4f7de7634505e3f6dac
2012-09-11Merge "Revert "Hybrid transform cleanups"" into experimentalYaowu Xu
2012-09-11Revert "Hybrid transform cleanups"Debargha Mukherjee
This reverts commit c5af82b7ed6d89a4a12003b8d1c6b4befcadce92 There was a mismatch bug introduced by this patch. Hence reverting until it is fixed.
2012-09-10Merge "Hybrid transform cleanups" into experimentalDeb Mukherjee
2012-09-10Hybrid transform cleanupsDeb Mukherjee
Some cleanups that will make it easier to maintain the code and incorporate upcoming changes on entropy coding for the hybrid transforms. Change-Id: I44bdba368f7b8bf203161d7a6d3b1fc2c9e21a8f
2012-09-07Partial merge of NEWBESTREFMV and NEW_MVREF.Paul Wilkins
This commit merges those parts of the CONFIG_NEW_MVREF that specifically relate to choosing a better set of candidate MV references into the NEWBESTREFMV experiment. CONFIG_NEW_MVREF will then be used for changes relating to the explicit coding of a cost optimized MV reference in the bitstream as part of MV coding. Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
2012-09-07MV reference changesPaul Wilkins
Extend experiment to use both vectors from MBs coded using compound prediction as candidates. In final sort only consider best 4 candidates for now but make sure 0,0 is always one of them. Other minor changes to new MV reference code. Pass in Mv list to vp8_find_best_ref_mvs(). Change-Id: Ib96220c33c6b80bd1d5e0fbe8b68121be7997095
2012-09-06New motion vector entropy codingDeb Mukherjee
Adds a new experiment with redesigned/refactored motion vector entropy coding. The patch also takes a first step towards separating the integer and fractional pel components of a MV. However the fractional pel encoding still depends on the integer pel part and so they are not fully independent. Further experiments are in progress to see how much they can be decoupled without affecting performance. All components including entropy coding/decoding, costing for MV search, forward updates and backward updates to probability tables, have been implemented. Results so far: derf: +0.19% std-hd: +0.28% yt: +0.80% hd: +1.15% Patch: Simplifies the fractional pel models: derf: +0.284% std-hd: +0.289% yt: +0.849% hd: +1.254% Patch: Some changes in the models, rebased. derf: +0.330% std-hd: +0.306% yt: +0.816% hd: +1.225% Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
2012-08-30hybrid transform of 16x16 dimensionJingning Han
Enable ADST/DCT of dimension 16x16 for I16X16 modes. This change provides benefits mostly for hd sequences. Set up the framework for selectable transform dimension. Also allowing quantization parameter threshold to control the use of hybrid transform (This is currently disabled by setting threshold always above the quantization parameter. Adaptive thresholding can be built upon this, which will further improve the coding performance.) The coding performance gains (with respect to the codec that has all other configuration settings turned on) are derf: 0.013 yt: 0.086 hd: 0.198 std-hd: 0.501 Change-Id: Ibb4263a61fc74e0b3c345f54d73e8c73552bf926
2012-08-28Disable 16x16 temp buffer for superblocks.Ronald S. Bultje
Change-Id: I3d585bae446c16fcf7a39d72c1bcd6468a7bb1a1
2012-08-24New Motion Reference SearchPaul Wilkins
Alternative strategy for finding a list of candidate motion vectors to use as reference values in mv coding and as nearest and near. Sort by sad in vp8_find_best_ref_mvs() rather than just pick the best. Allow 0,0 as a best ref option but not a nearest or near unless there are no alternatives. Encode/Decode verified on at least some clips. Some commented out experimental and stats code still in place. Gain over existing code averages about 1% on derf (alll metrics) with improvement on all clips. Other test results pending. The entropy coding of the mode (nearest/near etc) still depends upon and requires the old "findnear" code so this needs looking at and may provide room for further gains. Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
2012-08-22Remove duplicate code in C intra prediction.Ronald S. Bultje
Change-Id: If4eb0fd60cc5bc2f32254e82e8d6cfa4120cb558
2012-08-22Merge "remove rotation experiment" into experimentalJohn Koleszar
2012-08-21Merge "SSE2 version of vectorized 8-tap filtering." into experimentalChristian Duvivier
2012-08-21Merge "Fix mismatch caused by a rebase failure." into experimentalRonald S. Bultje
2012-08-21Fix mismatch caused by a rebase failure.Ronald S. Bultje
Change-Id: Ifff660de60fb12d745092eafc17f6a49f6e1fb53
2012-08-21SSE2 version of vectorized 8-tap filtering.Christian Duvivier
About 20% overall encoder speedup (vs. about 30% for sse4 version). Change-Id: Ibf608a6a1bc94b14ec47e8046d3206b275b5a8bd
2012-08-21Merge changes I96cd08c9,If8eeb8ff into experimentalJohn Koleszar
* changes: hybridtransform8x8: fix compilation comp_intra_pred: fix compilation
2012-08-21remove rotation experimentJohn Koleszar
This is being reimplemented more generically in terms of affine transforms. Change-Id: I9300bfde5f8b93c708c64f59427087720f8ed782
2012-08-21hybridtransform8x8: fix compilationJohn Koleszar
corrected ifdefs to include CONFIG_HYBRIDTRANSFORM8X8 for missing definitions Change-Id: I96cd08c98d74b5ba10866f3fa30252073ce92fa5
2012-08-20Fix some compiler warnings.Ronald S. Bultje
Change-Id: Iccb56e3b966d1519ba49dfe4e1396479c6b54a6f
2012-08-20comp_intra_pred: fix compilationJohn Koleszar
Added missing parameters to calls to: vp8_build_intra_predictors_internal vp8_build_intra_predictors_mbuv_internal Change-Id: If8eeb8ff23eff4572397b404fe61be5d0c950bbe
2012-08-20Merge "Superblock coding." into experimentalRonald S. Bultje