summaryrefslogtreecommitdiff
path: root/vp9
diff options
context:
space:
mode:
authorJames Zern <jzern@google.com>2022-04-26 18:42:24 -0700
committerJames Zern <jzern@google.com>2022-04-26 18:44:06 -0700
commit19b45a26c62170c1fb0dfd18a083ddb84ef7e4a4 (patch)
tree3ef5dcc7ada01f04e6f71194cebd8f4252d66d6c /vp9
parentf6de5b51b8338ebd743a465e84d2c4b73cc29082 (diff)
downloadlibvpx-19b45a26c62170c1fb0dfd18a083ddb84ef7e4a4.tar
libvpx-19b45a26c62170c1fb0dfd18a083ddb84ef7e4a4.tar.gz
libvpx-19b45a26c62170c1fb0dfd18a083ddb84ef7e4a4.tar.bz2
libvpx-19b45a26c62170c1fb0dfd18a083ddb84ef7e4a4.zip
vp9,encode_tiles_buffer_alloc: fix allocation check
previously vp9_bitstream_worker_data was checked after it was memset(); this change uses CHECK_MEM_ERROR for consistency to ensure the pointer is checked first Change-Id: I532d0eb0e746dc6b8d694b616eba693c5c0053ac
Diffstat (limited to 'vp9')
-rw-r--r--vp9/encoder/vp9_bitstream.c15
1 files changed, 7 insertions, 8 deletions
diff --git a/vp9/encoder/vp9_bitstream.c b/vp9/encoder/vp9_bitstream.c
index 99cc2ee83..75bd097f2 100644
--- a/vp9/encoder/vp9_bitstream.c
+++ b/vp9/encoder/vp9_bitstream.c
@@ -963,21 +963,20 @@ void vp9_bitstream_encode_tiles_buffer_dealloc(VP9_COMP *const cpi) {
}
}
-static int encode_tiles_buffer_alloc(VP9_COMP *const cpi) {
+static void encode_tiles_buffer_alloc(VP9_COMP *const cpi) {
+ VP9_COMMON *const cm = &cpi->common;
int i;
const size_t worker_data_size =
cpi->num_workers * sizeof(*cpi->vp9_bitstream_worker_data);
- cpi->vp9_bitstream_worker_data = vpx_memalign(16, worker_data_size);
+ CHECK_MEM_ERROR(cm, cpi->vp9_bitstream_worker_data,
+ vpx_memalign(16, worker_data_size));
memset(cpi->vp9_bitstream_worker_data, 0, worker_data_size);
- if (!cpi->vp9_bitstream_worker_data) return 1;
for (i = 1; i < cpi->num_workers; ++i) {
cpi->vp9_bitstream_worker_data[i].dest_size =
cpi->oxcf.width * cpi->oxcf.height;
- cpi->vp9_bitstream_worker_data[i].dest =
- vpx_malloc(cpi->vp9_bitstream_worker_data[i].dest_size);
- if (!cpi->vp9_bitstream_worker_data[i].dest) return 1;
+ CHECK_MEM_ERROR(cm, cpi->vp9_bitstream_worker_data[i].dest,
+ vpx_malloc(cpi->vp9_bitstream_worker_data[i].dest_size));
}
- return 0;
}
static size_t encode_tiles_mt(VP9_COMP *cpi, uint8_t *data_ptr) {
@@ -992,7 +991,7 @@ static size_t encode_tiles_mt(VP9_COMP *cpi, uint8_t *data_ptr) {
cpi->vp9_bitstream_worker_data[1].dest_size >
(cpi->oxcf.width * cpi->oxcf.height)) {
vp9_bitstream_encode_tiles_buffer_dealloc(cpi);
- if (encode_tiles_buffer_alloc(cpi)) return 0;
+ encode_tiles_buffer_alloc(cpi);
}
while (tile_col < tile_cols) {