diff options
author | Daniel Sommermann <dcsommer@gmail.com> | 2020-08-17 09:42:08 -0700 |
---|---|---|
committer | James Zern <jzern@google.com> | 2020-08-19 11:56:25 -0700 |
commit | c413c8f18eb1932b100850505031980e27160d5f (patch) | |
tree | 21df7965ced1437a33b4a2af63f8e7a2ce753dbd /vp9/common/vp9_scale.c | |
parent | ebbe5b82a052a316b0df52a5109071f512b7d23c (diff) | |
download | libvpx-c413c8f18eb1932b100850505031980e27160d5f.tar libvpx-c413c8f18eb1932b100850505031980e27160d5f.tar.gz libvpx-c413c8f18eb1932b100850505031980e27160d5f.tar.bz2 libvpx-c413c8f18eb1932b100850505031980e27160d5f.zip |
Escape number sign in Makefiles
Number signs are handled differently in Makefile variable parsing as
compared to bash variable parsing. See this demo:
```
$ cat Makefile
A=foo#bar
B='foo#bar'
C="foo#bar"
D=foo\#bar
E='foo\#bar'
F="foo\#bar"
$(info $(A))
$(info $(B))
$(info $(C))
$(info $(D))
$(info $(E))
$(info $(F))
$ make
foo
'foo
"foo
foo#bar
'foo#bar'
"foo#bar"
make: *** No targets. Stop.
$ make -v
GNU Make 4.2.1
```
In other words, the `#` character is evaluated first when parsing
Makefiles, causing the rest of the line to become a comment. The effect of
this is that paths that contain embedded `#` symbols are not handled
properly in the vpx build system.
To test this change, clone vpx to a directory containing a `#` symbol and
attempt a build. With this change, it worked for me on Fedora 31, however
without the change the build failed.
Change-Id: Iaee6383e2435049b680484cc5cefdea9f2d9df46
Diffstat (limited to 'vp9/common/vp9_scale.c')
0 files changed, 0 insertions, 0 deletions