diff options
author | Johann <johannkoenig@google.com> | 2011-04-15 10:11:53 -0400 |
---|---|---|
committer | Johann <johannkoenig@google.com> | 2011-04-15 10:11:53 -0400 |
commit | 487c0299c98f421110728e70049623ce30818da1 (patch) | |
tree | c2530e09617bf79131147e91242f46828e378209 /vp8 | |
parent | a3399291ad0350e57cdce62369cb9bf196ec1ebb (diff) | |
download | libvpx-487c0299c98f421110728e70049623ce30818da1.tar libvpx-487c0299c98f421110728e70049623ce30818da1.tar.gz libvpx-487c0299c98f421110728e70049623ce30818da1.tar.bz2 libvpx-487c0299c98f421110728e70049623ce30818da1.zip |
remove dead code, add missing RESTORE_XMM
vp8_filter_block1d16_h4_ssse3 was never called
because UNSHADOW_ARGS moves the stack by 'mov rsp, rbp', the issue was
masked. however, if/when win64 used those registers for persistant data,
issues could/will arise.
Change-Id: I56d6effca0aeba1f86082689771cb10145d39651
Diffstat (limited to 'vp8')
-rw-r--r-- | vp8/common/x86/subpixel_ssse3.asm | 60 |
1 files changed, 1 insertions, 59 deletions
diff --git a/vp8/common/x86/subpixel_ssse3.asm b/vp8/common/x86/subpixel_ssse3.asm index 7f6fd93e4..0ec18de76 100644 --- a/vp8/common/x86/subpixel_ssse3.asm +++ b/vp8/common/x86/subpixel_ssse3.asm @@ -194,10 +194,6 @@ sym(vp8_filter_block1d16_h6_ssse3): mov rdi, arg(2) ;output_ptr -;; -;; cmp esi, DWORD PTR [rax] -;; je vp8_filter_block1d16_h4_ssse3 - mov rsi, arg(0) ;src_ptr movdqa xmm4, XMMWORD PTR [rax] ;k0_k5 @@ -271,61 +267,7 @@ filter_block1d16_h6_rowloop_ssse3: pop rdi pop rsi RESTORE_GOT - UNSHADOW_ARGS - pop rbp - ret - -vp8_filter_block1d16_h4_ssse3: - movdqa xmm5, XMMWORD PTR [rax+256] ;k2_k4 - movdqa xmm6, XMMWORD PTR [rax+128] ;k1_k3 - - mov rsi, arg(0) ;src_ptr - movsxd rax, dword ptr arg(1) ;src_pixels_per_line - movsxd rcx, dword ptr arg(4) ;output_height - movsxd rdx, dword ptr arg(3) ;output_pitch - -filter_block1d16_h4_rowloop_ssse3: - movdqu xmm1, XMMWORD PTR [rsi - 2] - - movdqa xmm2, xmm1 - pshufb xmm1, [GLOBAL(shuf2b)] - pshufb xmm2, [GLOBAL(shuf3b)] - pmaddubsw xmm1, xmm5 - - movdqu xmm3, XMMWORD PTR [rsi + 6] - - pmaddubsw xmm2, xmm6 - movdqa xmm0, xmm3 - pshufb xmm3, [GLOBAL(shuf3b)] - pshufb xmm0, [GLOBAL(shuf2b)] - - paddsw xmm1, [GLOBAL(rd)] - paddsw xmm1, xmm2 - - pmaddubsw xmm0, xmm5 - pmaddubsw xmm3, xmm6 - - psraw xmm1, 7 - packuswb xmm1, xmm1 - lea rsi, [rsi + rax] - paddsw xmm3, xmm0 - paddsw xmm3, [GLOBAL(rd)] - psraw xmm3, 7 - packuswb xmm3, xmm3 - - punpcklqdq xmm1, xmm3 - - movdqa XMMWORD Ptr [rdi], xmm1 - - add rdi, rdx - dec rcx - jnz filter_block1d16_h4_rowloop_ssse3 - - - ; begin epilog - pop rdi - pop rsi - RESTORE_GOT + RESTORE_XMM UNSHADOW_ARGS pop rbp ret |