Further segment feature extensions.

This quite large check in includes the following:

Merge in some code from Ronald (mbgraph.c) that scans a Gf/arf group.
This is used as a basis for a simple segmentation for the normal frames
in a gf/arf group. This code also uses satd functions from Yaowu.

Adds functionality for coding the latest possible position of an EOB for
blocks in the segment. (Currently 0-15 only, hence just for 4x4 dct).
Where the EOB position is 0 this acts like "skip" and the normal coding
of skip at the per mb level is disabled.

Added functions (seg_common.c) for setting and reading segment feature
elements. These may want to be optimized away at some point but while the
mecahnism is in a state of flux they provide a single location for making
changes and keep things a bit cleaner.

This is still proof of concept code. Currently the tested feature set:-

Quantizer,
Loop Filter level,
Reference frame,
Prediction Mode,
EOB end stop.

TBD:-

Add functions for setting and reading the feature data with range
and validity checking.

Handling of signed and unsigned feature data. At the moment all is assumed
to be signed and a sign bit is coded but many cannot be negative.

Correct handling of EOB feature with intra coded blocks.

Testing/trapping of legal/illegal ref frame and mode combinations.

Transform size switch plus merge and test with 8c8 DCT work

Merge and test with Sumans Segmenation coding optimizations

Change-Id: Iee12e83661c7abbd1e0ce6810915eb4ec35e2d8e

1 files changed, 11 insertions, 9 deletions

diff --git a/vp8/encoder/rdopt.c b/vp8/encoder/rdopt.c
index e29f65b73..2e52a00dc 100644
--- a/vp8/encoder/rdopt.c
+++ b/vp8/encoder/rdopt.c
@@ -36,6 +36,10 @@
 #include "dct.h"
 #include "vp8/common/systemdependent.h"
 
+#if CONFIG_SEGFEATURES
+#include "vp8/common/seg_common.h"
+#endif
+
 #if CONFIG_RUNTIME_CPU_DETECT
 #define IF_RTCD(x)  (x)
 #else
@@ -2122,21 +2126,19 @@ void vp8_rd_pick_inter_mode(VP8_COMP *cpi, MACROBLOCK *x, int recon_yoffset, int
 
 #if CONFIG_SEGFEATURES
         // Experimental use of Segment features.
-        if ( !cm->refresh_alt_ref_frame )
+        if ( xd->segmentation_enabled && !cm->refresh_alt_ref_frame )
         {
             unsigned char segment_id = xd->mode_info_context->mbmi.segment_id;
-            int feature_mask = xd->segment_feature_mask[segment_id];
 
-            if ( (feature_mask & (0x01 << SEG_LVL_REF_FRAME)) &&
-                 ( x->e_mbd.mode_info_context->mbmi.ref_frame !=
-                   cpi->segment_feature_data[segment_id][SEG_LVL_REF_FRAME]))
+            if ( segfeature_active( xd, segment_id, SEG_LVL_REF_FRAME )  &&
+                 ( xd->mode_info_context->mbmi.ref_frame !=
+                   xd->segment_feature_data[segment_id][SEG_LVL_REF_FRAME]))
             {
                 continue;
             }
-
-            if ( (feature_mask & (0x01 << SEG_LVL_MODE)) &&
-                 ( this_mode !=
-                   cpi->segment_feature_data[segment_id][SEG_LVL_MODE]))
+            if ( segfeature_active( xd, segment_id, SEG_LVL_MODE )  &&
+                ( this_mode !=
+                  xd->segment_feature_data[segment_id][SEG_LVL_MODE]))
             {
                 continue;
             }