diff options
| author | Timothy B. Terriberry <tterribe@xiph.org> | 2010-10-27 16:04:02 -0700 |
|---|---|---|
| committer | John Koleszar <jkoleszar@google.com> | 2010-10-27 18:08:04 -0700 |
| commit | c4d7e5e67ecfcd9730bd512483390369fc9982db (patch) | |
| tree | f179a9315909b337a5b441d998aff510cea6d547 /vp8/decoder/generic | |
| parent | 2b4913eb0d5722e38d9e28ef458e7e3318e87920 (diff) | |
| download | libvpx-c4d7e5e67ecfcd9730bd512483390369fc9982db.tar libvpx-c4d7e5e67ecfcd9730bd512483390369fc9982db.tar.gz libvpx-c4d7e5e67ecfcd9730bd512483390369fc9982db.tar.bz2 libvpx-c4d7e5e67ecfcd9730bd512483390369fc9982db.zip | |
Eliminate more warnings.
This eliminates a large set of warnings exposed by the Mozilla build
system (Use of C++ comments in ISO C90 source, commas at the end of
enum lists, a couple incomplete initializers, and signed/unsigned
comparisons).
It also eliminates many (but not all) of the warnings expose by newer
GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
without checking the return values).
There are a few spurious warnings left on my system:
../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
uninitialized in this function
gcc seems to be unable to figure out that the value shortcut doesn't
change between the two if blocks that test it here.
../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
expression >= 0 is always true
../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
expression >= 0 is always true
This is true, so far as it goes, but it's comparing against an enum, and the C
standard does not mandate that enums be unsigned, so the checks can't be
removed.
Change-Id: Iaf689ae3e3d0ddc5ade00faa474debe73b8d3395
Diffstat (limited to 'vp8/decoder/generic')
| -rw-r--r-- | vp8/decoder/generic/dsystemdependent.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vp8/decoder/generic/dsystemdependent.c b/vp8/decoder/generic/dsystemdependent.c index 84de7af43..2e284729b 100644 --- a/vp8/decoder/generic/dsystemdependent.c +++ b/vp8/decoder/generic/dsystemdependent.c @@ -18,7 +18,7 @@ extern void vp8_arch_arm_decode_init(VP8D_COMP *pbi); void vp8_dmachine_specific_config(VP8D_COMP *pbi) { - // Pure C: + /* Pure C: */ #if CONFIG_RUNTIME_CPU_DETECT pbi->mb.rtcd = &pbi->common.rtcd; pbi->dequant.block = vp8_dequantize_b_c; @@ -29,7 +29,7 @@ void vp8_dmachine_specific_config(VP8D_COMP *pbi) pbi->dequant.idct_add_uv_block = vp8_dequant_idct_add_uv_block_c; pbi->dboolhuff.start = vp8dx_start_decode_c; pbi->dboolhuff.fill = vp8dx_bool_decoder_fill_c; -#if 0 //For use with RTCD, when implemented +#if 0 /*For use with RTCD, when implemented*/ pbi->dboolhuff.debool = vp8dx_decode_bool_c; pbi->dboolhuff.devalue = vp8dx_decode_value_c; #endif |