diff options
| author | John Koleszar <jkoleszar@google.com> | 2011-08-19 14:06:00 -0400 |
|---|---|---|
| committer | John Koleszar <jkoleszar@google.com> | 2012-01-30 12:06:27 -0800 |
| commit | a910049aea5e2be97b232dbdd7700d078eb7ecd0 (patch) | |
| tree | 756d6b7f6a9e9af9006a6ecee4ad3a4d3c809627 /vp8/common/arm/neon | |
| parent | 57cc35dd603491a90524c04ef23dfbbef3d1af5a (diff) | |
| download | libvpx-a910049aea5e2be97b232dbdd7700d078eb7ecd0.tar libvpx-a910049aea5e2be97b232dbdd7700d078eb7ecd0.tar.gz libvpx-a910049aea5e2be97b232dbdd7700d078eb7ecd0.tar.bz2 libvpx-a910049aea5e2be97b232dbdd7700d078eb7ecd0.zip | |
New RTCD implementation
This is a proof of concept RTCD implementation to replace the current
system of nested includes, prototypes, INVOKE macros, etc. Currently
only the decoder specific functions are implemented in the new system.
Additional functions will be added in subsequent commits.
Overview:
RTCD "functions" are implemented as either a global function pointer
or a macro (when only one eligible specialization available).
Functions which have RTCD specializations are listed using a simple
DSL identifying the function's base name, its prototype, and the
architecture extensions that specializations are available for.
Advantages over the old system:
- No INVOKE macros. A call to an RTCD function looks like an ordinary
function call.
- No need to pass vtables around.
- If there is only one eligible function to call, the function is
called directly, rather than indirecting through a function pointer.
- Supports the notion of "required" extensions, so in combination with
the above, on x86_64 if the best function available is sse2 or lower
it will be called directly, since all x86_64 platforms implement
sse2.
- Elides all references to functions which will never be called, which
could reduce binary size. For example if sse2 is required and there
are both mmx and sse2 implementations of a certain function, the
code will have no link time references to the mmx code.
- Significantly easier to add a new function, just one file to edit.
Disadvantages:
- Requires global writable data (though this is not a new requirement)
- 1 new generated source file.
Change-Id: Iae6edab65315f79c168485c96872641c5aa09d55
Diffstat (limited to 'vp8/common/arm/neon')
| -rw-r--r-- | vp8/common/arm/neon/idct_blk_neon.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/vp8/common/arm/neon/idct_blk_neon.c b/vp8/common/arm/neon/idct_blk_neon.c index cc55843d5..7424b029c 100644 --- a/vp8/common/arm/neon/idct_blk_neon.c +++ b/vp8/common/arm/neon/idct_blk_neon.c @@ -10,7 +10,6 @@ #include "vpx_config.h" #include "vp8/common/idct.h" -#include "vp8/common/dequantize.h" /* place these declarations here because we don't want to maintain them * outside of this scope |