diff options
| author | James Zern <jzern@google.com> | 2022-06-01 18:55:10 -0700 |
|---|---|---|
| committer | James Zern <jzern@google.com> | 2022-06-01 19:03:44 -0700 |
| commit | 3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315 (patch) | |
| tree | 9aa75a22f0866f8a2084c1c742b459de0fa14248 /test | |
| parent | 9d279c88c3e8873c114298d69e919bfef45a1dab (diff) | |
| download | libvpx-3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315.tar libvpx-3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315.tar.gz libvpx-3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315.tar.bz2 libvpx-3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315.zip | |
vp9,encoder: fix some integer sanitizer warnings
the issues fixed in this change are related to implicit conversions
between int / unsigned int:
vp9/encoder/vp9_segmentation.c:42:36: runtime error: implicit conversion
from type 'int' of value -9 (32-bit, signed) to type 'unsigned int'
changed the value to 4294967287 (32-bit, unsigned)
vpx_dsp/x86/sum_squares_sse2.c:36:52: runtime error: implicit conversion
from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type
'int' changed the value to -1 (32-bit, signed)
vpx_dsp/x86/sum_squares_sse2.c:36:67: runtime error: implicit conversion
from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type
'int' changed the value to -1 (32-bit, signed)
vp9/encoder/x86/vp9_diamond_search_sad_avx.c:81:45: runtime error:
implicit conversion from type 'uint32_t' (aka 'unsigned int') of value
4290576316 (32-bit, unsigned) to type 'int' changed the value to
-4390980 (32-bit, signed)
vp9/encoder/vp9_rdopt.c:3472:31: runtime error: implicit conversion from
type 'int' of value -1024 (32-bit, signed) to type 'uint16_t' (aka
'unsigned short') changed the value to 64512 (16-bit, unsigned)
unsigned is forced for masks and int is used with intel intrinsics
Bug: webm:1767
Change-Id: Icfa4179e13bc98a36ac29586b60d65819d3ce9ee
Fixed: webm:1767
Diffstat (limited to 'test')
| -rw-r--r-- | test/resize_test.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/test/resize_test.cc b/test/resize_test.cc index ccee61407..212ff4697 100644 --- a/test/resize_test.cc +++ b/test/resize_test.cc @@ -796,9 +796,8 @@ TEST_P(ResizeCspTest, TestResizeCspWorks) { } VP8_INSTANTIATE_TEST_SUITE(ResizeTest, ONE_PASS_TEST_MODES); -// TODO(https://crbug.com/webm/1767,https://crbug.com/webm/1768): VP9 should -// use ONE_PASS_TEST_MODES for the ResizeTest instantiation after integer -// sanitizer warnings and segfault are fixed. +// TODO(https://crbug.com/webm/1768): VP9 should use ONE_PASS_TEST_MODES for +// the ResizeTest instantiation after segfault is fixed. VP9_INSTANTIATE_TEST_SUITE(ResizeTest, ::testing::Values(::libvpx_test::kRealTime)); VP9_INSTANTIATE_TEST_SUITE(ResizeInternalTest, |