diff options
| author | paulwilkins <paulwilkins@google.com> | 2018-02-06 13:54:25 +0000 |
|---|---|---|
| committer | paulwilkins <paulwilkins@google.com> | 2018-02-06 14:02:33 +0000 |
| commit | c104f4cbdc1c34dcc121340b29aa721d95d18d05 (patch) | |
| tree | cb2447c34c98cbdbe64e9656a50b46c3845fa66d | |
| parent | 0fe4371cc0871b713acf09fea671347ed2d4f98c (diff) | |
| download | libvpx-c104f4cbdc1c34dcc121340b29aa721d95d18d05.tar libvpx-c104f4cbdc1c34dcc121340b29aa721d95d18d05.tar.gz libvpx-c104f4cbdc1c34dcc121340b29aa721d95d18d05.tar.bz2 libvpx-c104f4cbdc1c34dcc121340b29aa721d95d18d05.zip | |
Fix file input pointer bug in allocate_gf_group_bits().
The stats input pointer, when passed in, already points to the
frame after the golden frame so should not be advanced here.
This fix has a small mostly positive effect on results in our test sets
(tested using corpus vbr settings) and gives a gain of almost 0.5%
in overall psnr (plus slightly smaller gains on other metrics) for the
4K set.
The bug also caused a crash in calculate_group_score() in another
patch which allows coding of slides in a slide show as a single
long KF group without ARFs or GFs.
Change-Id: I57a3a24baf442ce55dbc91fba05e056697c63a6f
| -rw-r--r-- | vp9/encoder/vp9_firstpass.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/vp9/encoder/vp9_firstpass.c b/vp9/encoder/vp9_firstpass.c index feff319ee..b049c5eb2 100644 --- a/vp9/encoder/vp9_firstpass.c +++ b/vp9/encoder/vp9_firstpass.c @@ -2237,9 +2237,6 @@ static void allocate_gf_group_bits(VP9_COMP *cpi, int64_t gf_group_bits, } gf_group->arf_update_idx[0] = arf_buffer_indices[0]; gf_group->arf_ref_idx[0] = arf_buffer_indices[0]; - - // Step over the golden frame / overlay frame - if (EOF == input_stats(twopass, &frame_stats)) return; } // Deduct the boost bits for arf (or gf if it is not a key frame) |