diff options
| author | Yunqing Wang <yunqingwang@google.com> | 2015-02-19 15:31:02 -0800 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@gerrit.golo.chromium.org> | 2015-02-19 15:31:02 -0800 |
| commit | 5e57729601d0e1d54cde61bd34e5f1d888aa22c8 (patch) | |
| tree | 53b91b13db06113bbb1baf5e4c06fa3bd1efc6b3 | |
| parent | 216b171d63feddb8328615e6530dabaf3ba84db9 (diff) | |
| parent | 81fc5bf81c4199883a891791a0a5539e029e8077 (diff) | |
| download | libvpx-5e57729601d0e1d54cde61bd34e5f1d888aa22c8.tar libvpx-5e57729601d0e1d54cde61bd34e5f1d888aa22c8.tar.gz libvpx-5e57729601d0e1d54cde61bd34e5f1d888aa22c8.tar.bz2 libvpx-5e57729601d0e1d54cde61bd34e5f1d888aa22c8.zip | |
Merge "Improve skip_txfm thresholds in the non-rd mode selection"
| -rw-r--r-- | test/datarate_test.cc | 2 | ||||
| -rw-r--r-- | vp9/encoder/vp9_pickmode.c | 14 |
2 files changed, 10 insertions, 6 deletions
diff --git a/test/datarate_test.cc b/test/datarate_test.cc index e52934771..94efeae97 100644 --- a/test/datarate_test.cc +++ b/test/datarate_test.cc @@ -540,7 +540,7 @@ TEST_P(DatarateTestVP9Large, ChangingDropFrameThresh) { << " The first dropped frame for drop_thresh " << i << " > first dropped frame for drop_thresh " << i - kDropFrameThreshTestStep; - ASSERT_GE(num_drops_, last_num_drops) + ASSERT_GE(num_drops_, last_num_drops * 0.90) << " The number of dropped frames for drop_thresh " << i << " < number of dropped frames for drop_thresh " << i - kDropFrameThreshTestStep; diff --git a/vp9/encoder/vp9_pickmode.c b/vp9/encoder/vp9_pickmode.c index 46a354700..71cea0e45 100644 --- a/vp9/encoder/vp9_pickmode.c +++ b/vp9/encoder/vp9_pickmode.c @@ -216,6 +216,8 @@ static void model_rd_for_sb_y(VP9_COMP *cpi, BLOCK_SIZE bsize, int64_t dist; struct macroblock_plane *const p = &x->plane[0]; struct macroblockd_plane *const pd = &xd->plane[0]; + const int64_t dc_thr = p->quant_thred[0] >> 6; + const int64_t ac_thr = p->quant_thred[1] >> 6; const uint32_t dc_quant = pd->dequant[0]; const uint32_t ac_quant = pd->dequant[1]; unsigned int var = cpi->fn_ptr[bsize].vf(p->src.buf, p->src.stride, @@ -223,12 +225,14 @@ static void model_rd_for_sb_y(VP9_COMP *cpi, BLOCK_SIZE bsize, *var_y = var; *sse_y = sse; - if (sse < dc_quant * dc_quant >> 6) - x->skip_txfm[0] = 1; - else if (var < ac_quant * ac_quant >> 6) + x->skip_txfm[0] = 0; + // Check if all ac coefficients can be quantized to zero. + if (var < ac_thr || var == 0) { x->skip_txfm[0] = 2; - else - x->skip_txfm[0] = 0; + // Check if dc coefficient can be quantized to zero. + if (sse - var < dc_thr || sse == var) + x->skip_txfm[0] = 1; + } if (cpi->common.tx_mode == TX_MODE_SELECT) { if (sse > (var << 2)) |