From bafcba22ac5eb612dcc32425fce5479d1ee3e79b Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 20 Jun 2017 15:46:28 -0300 Subject: Consolidate Linux openat implementation This patch consolidates the open Linux syscall implementation on sysdeps/unix/sysv/linux/open{64}.c. The changes are: 1. Remove wordsize-64 openat{64}. 2. For architetures that define __OFF_T_MATCHES_OFF64_T openat64 will be default one with alias to required symbols. Otherwise openat64 will pass the required O_LARGEFILE flag on syscall. Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32, arch64-linux-gnu, arm-linux-gnueabihf, and powerpc64le-linux-gnu. * sysdeps/unix/sysv/linux/openat.c (__libc_openat): Build only for !__OFF_T_MATCHES_OFF64_T. * sysdeps/unix/sysv/linux/openat64.c (__libc_openat64): New implementation based on open64. * sysdeps/unix/sysv/linux/wordsize-64/openat.c: Remove file. * sysdeps/unix/sysv/linux/wordsize-64/openat64.c: Likewise. --- sysdeps/unix/sysv/linux/openat.c | 31 ++++++++----------------------- 1 file changed, 8 insertions(+), 23 deletions(-) (limited to 'sysdeps/unix/sysv/linux/openat.c') diff --git a/sysdeps/unix/sysv/linux/openat.c b/sysdeps/unix/sysv/linux/openat.c index 2c620d81cc..158730596d 100644 --- a/sysdeps/unix/sysv/linux/openat.c +++ b/sysdeps/unix/sysv/linux/openat.c @@ -15,31 +15,18 @@ License along with the GNU C Library; if not, see . */ -#include #include #include -#include -#include -#include -#include -#include -#include - -#ifndef OPENAT -# define OPENAT openat -#endif - -#define UNDERIZE(name) UNDERIZE_1 (name) -#define UNDERIZE_1(name) __##name -#define __OPENAT UNDERIZE (OPENAT) +#include +#ifndef __OFF_T_MATCHES_OFF64_T /* Open FILE with access OFLAG. Interpret relative paths relative to the directory associated with FD. If OFLAG includes O_CREAT or O_TMPFILE, a fourth argument is the file protection. */ int -__OPENAT (int fd, const char *file, int oflag, ...) +__libc_openat (int fd, const char *file, int oflag, ...) { mode_t mode = 0; if (__OPEN_NEEDS_MODE (oflag)) @@ -50,12 +37,10 @@ __OPENAT (int fd, const char *file, int oflag, ...) va_end (arg); } - /* We have to add the O_LARGEFILE flag for openat64. */ -#ifdef MORE_OFLAGS - oflag |= MORE_OFLAGS; -#endif - return SYSCALL_CANCEL (openat, fd, file, oflag, mode); } -libc_hidden_def (__OPENAT) -weak_alias (__OPENAT, OPENAT) +weak_alias (__libc_openat, __openat) +libc_hidden_weak (__openat) +weak_alias (__libc_openat, openat) + +#endif -- cgit v1.2.3