From aaacde11f2e814814fdd19dfb683e76f1dede4d5 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 12 Jul 2021 18:43:32 +0200 Subject: Reduce pollution due to dynamic PTHREAD_STACK_MIN used to be a header file with no declarations. GCC's libgomp includes it in a #pragma GCC visibility hidden block. Including from (indirectly) declares everything in with hidden visibility, resulting in linker failures. This commit avoids C declarations in assembler mode and only declares __sysconf in (and not the entire contents of ). The __sysconf symbol is already part of the ABI. PTHREAD_STACK_MIN is no longer defined for __USE_DYNAMIC_STACK_SIZE && __ASSEMBLER__ because there is no possible definition. Additionally, PTHREAD_STACK_MIN is now defined by for __USE_MISC because this is what developers expect based on the macro name. It also helps to avoid libgomp linker failures in GCC because libgomp includes before its visibility hacks. Reviewed-by: Carlos O'Donell --- sysdeps/unix/sysv/linux/bits/local_lim.h | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'sysdeps/unix/sysv/linux/bits/local_lim.h') diff --git a/sysdeps/unix/sysv/linux/bits/local_lim.h b/sysdeps/unix/sysv/linux/bits/local_lim.h index 0b1c7f40be..b8f89236bc 100644 --- a/sysdeps/unix/sysv/linux/bits/local_lim.h +++ b/sysdeps/unix/sysv/linux/bits/local_lim.h @@ -77,14 +77,8 @@ priority level. */ #define AIO_PRIO_DELTA_MAX 20 -/* Minimum size for a thread. We are free to choose a reasonable value. */ -#undef PTHREAD_STACK_MIN -#if defined __USE_DYNAMIC_STACK_SIZE && __USE_DYNAMIC_STACK_SIZE -# include -# define PTHREAD_STACK_MIN sysconf (_SC_THREAD_STACK_MIN) -#else -# include -#endif +/* Arrange for the definition of PTHREAD_STACK_MIN. */ +#include /* Maximum number of timer expiration overruns. */ #define DELAYTIMER_MAX 2147483647 -- cgit v1.2.3-70-g09d2