From e658b54e8e67c00063a0b549fa25b73d8e6d4076 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Fri, 29 Sep 2000 02:56:42 +0000 Subject: Update. * stdio-common/tmpnam.c (tmpnam): Optimize a bit. * sysdeps/posix/getaddrinfo.c (gaih_local): Don't use tmpnam, use underlying functions directly. --- sysdeps/posix/getaddrinfo.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'sysdeps/posix') diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c index fdd8729657..7a84cd3030 100644 --- a/sysdeps/posix/getaddrinfo.c +++ b/sysdeps/posix/getaddrinfo.c @@ -206,7 +206,15 @@ gaih_local (const char *name, const struct gaih_service *service, } else { - if (tmpnam (((struct sockaddr_un *) (*pai)->ai_addr)->sun_path) == NULL) + /* This is a dangerous use of the interface since there is a time + window between the test for the file and the actual creation + (done by the caller) in which a file with the same name could + be created. */ + char *buf = ((struct sockaddr_un *) (*pai)->ai_addr)->sun_path; + + if (__builtin_expect (__path_search (buf, L_tmpnam, NULL, NULL, 0), + 0) != 0 + || __builtin_expect (__gen_tempname (buf, __GT_NOCREATE), 0) != 0) return -EAI_SYSTEM; } -- cgit v1.2.3