From 098a657fe449a217cf65c5270d5fbc8d40b5b4e6 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 26 Apr 2022 09:26:22 -0700 Subject: elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage variables and hidden visibility variables in a shared object (ld.so) need dynamic relocations (usually R_*_RELATIVE). PI (position independent) in the macro name is a misnomer: a code sequence using GOT is typically position-independent as well, but using dynamic relocations does not meet the requirement. Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new ports will define PI_STATIC_AND_HIDDEN. Current ports defining PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure default. No functional change. Reviewed-by: Adhemerval Zanella --- sysdeps/hppa/configure | 3 +++ sysdeps/hppa/configure.ac | 2 ++ 2 files changed, 5 insertions(+) (limited to 'sysdeps/hppa') diff --git a/sysdeps/hppa/configure b/sysdeps/hppa/configure index cf5acf966d..ebb42c592c 100644 --- a/sysdeps/hppa/configure +++ b/sysdeps/hppa/configure @@ -32,6 +32,9 @@ cat >>confdefs.h <<_ACEOF _ACEOF +$as_echo "#define HIDDEN_VAR_NEEDS_DYNAMIC_RELOC 1" >>confdefs.h + + # PIE builds fail on binutils 2.37 and earlier, see: # https://sourceware.org/bugzilla/show_bug.cgi?id=28672 $as_echo "#define PIE_UNSUPPORTED 1" >>confdefs.h diff --git a/sysdeps/hppa/configure.ac b/sysdeps/hppa/configure.ac index 3e1c35bbd9..5e59a63f9a 100644 --- a/sysdeps/hppa/configure.ac +++ b/sysdeps/hppa/configure.ac @@ -20,6 +20,8 @@ fi rm -f conftest*]) AC_DEFINE_UNQUOTED(ASM_LINE_SEP, $libc_cv_asm_line_sep) +AC_DEFINE(HIDDEN_VAR_NEEDS_DYNAMIC_RELOC) + # PIE builds fail on binutils 2.37 and earlier, see: # https://sourceware.org/bugzilla/show_bug.cgi?id=28672 AC_DEFINE(PIE_UNSUPPORTED) -- cgit v1.2.3