From 1eb8930608705702d5746e5491bab4e4429fcb83 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Fri, 22 Jan 2016 09:58:49 -0200 Subject: posix: execvpe cleanup This patch removes all the dynamic allocation on execvpe code and instead use direct stack allocation. This is QoI approach to make it possible use in scenarios where memory is shared with parent (vfork or clone with CLONE_VM). For default process spawn (script file without a shebang), stack allocation is bounded by NAME_MAX plus PATH_MAX plus 1. Large file arguments returns an error (ENAMETOOLONG). This differs than current GLIBC pratice in general, but it used to limit stack allocation for large inputs. Also, path in PATH environment variable larger than PATH_MAX are ignored. The shell direct execution exeception, where execve returns ENOEXEC, might requires a large stack allocation due large input argument list. Tested on i686, x86_64, powerpc64le, and aarch64. * posix/execvpe.c (__execvpe): Remove dynamic allocation. * posix/Makefile (tests): Add tst-execvpe{1,2,3,4,5,6}. * posix/tst-execvp1.c (do_test): Use a macro to call execvp. * posix/tst-execvp2.c (do_test): Likewise. * posix/tst-execvp3.c (do_test): Likewise. * posix/tst-execvp4.c (do_test): Likewise. * posix/tst-execvpe1.c: New file. * posix/tst-execvpe2.c: Likewise. * posix/tst-execvpe3.c: Likewise. * posix/tst-execvpe4.c: Likewise. * posix/tst-execvpe5.c: Likewise. * posix/tst-execvpe6.c: Likewise. --- posix/tst-execvp1.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'posix/tst-execvp1.c') diff --git a/posix/tst-execvp1.c b/posix/tst-execvp1.c index ecc673d124..8b718485d0 100644 --- a/posix/tst-execvp1.c +++ b/posix/tst-execvp1.c @@ -3,6 +3,10 @@ #include #include +#ifndef EXECVP +# define EXECVP(file, argv) execvp (file, argv) +#endif + static int do_test (void) { @@ -19,7 +23,7 @@ do_test (void) char *argv[] = { (char *) "does-not-exist", NULL }; errno = 0; - execvp (argv[0], argv); + EXECVP (argv[0], argv); if (errno != ENOENT) { -- cgit v1.2.3