From b569ae384410aeff8bf3252eca64df1686bcd70a Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Mon, 29 Mar 2004 21:46:58 +0000 Subject: Update. * nis/nss_nis/nis-rpc.c (saveit): Improve memory. No need to allocate multiple blocks. (internal_nis_endrpcent): Adjust accordingly. * nis/nss_nis/nis-proto.c (saveit): Improve memory. No need to allocate multiple blocks. (internal_nis_endprotoent): Adjust accordingly. * nis/nss_nis/nis-initgroups.c (saveit): Improve memory. No need to allocate multiple blocks. (_nss_nis_initgroups_dyn): Adjust accordingly. * nis/nss_nis/nis-ethers.c (saveit): Improve memory. No need to allocate multiple blocks. (internal_nis_endetherent): Adjust accordingly. * nis/nss_nis/nis-service.c (saveit): Improve memory. No need to allocate multiple blocks. (internal_nis_endservent): Adjust accordingly. --- nis/nss_nis/nis-ethers.c | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-) (limited to 'nis/nss_nis/nis-ethers.c') diff --git a/nis/nss_nis/nis-ethers.c b/nis/nss_nis/nis-ethers.c index 713fe31e93..328d61f6c5 100644 --- a/nis/nss_nis/nis-ethers.c +++ b/nis/nss_nis/nis-ethers.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1996-2000, 2001, 2002, 2003 Free Software Foundation, Inc. +/* Copyright (C) 1996-2003, 2004 Free Software Foundation, Inc. This file is part of the GNU C Library. Contributed by Thorsten Kukuk , 1996. @@ -40,8 +40,8 @@ __libc_lock_define_initialized (static, lock) struct response { - char *val; struct response *next; + char val[0]; }; static struct response *start; @@ -56,26 +56,18 @@ saveit (int instatus, char *inkey, int inkeylen, char *inval, if (inkey && inkeylen > 0 && inval && invallen > 0) { + struct response *newp = malloc (sizeof (struct response) + invallen + 1); + if (newp == NULL) + return YP_FALSE; /* We have no error code for out of memory */ + if (start == NULL) - { - start = malloc (sizeof (struct response)); - if (start == NULL) - return YP_FALSE; - next = start; - } + start = newp; else - { - next->next = malloc (sizeof (struct response)); - if (next->next == NULL) - return YP_FALSE; - next = next->next; - } - next->next = NULL; - next->val = malloc (invallen + 1); - if (next->val == NULL) - return YP_FALSE; - strncpy (next->val, inval, invallen); - next->val[invallen] = '\0'; + next->next = newp; + next = newp; + + newp->next = NULL; + *((char *) mempcpy (newp->val, inval, invallen)) = '\0'; } return 0; @@ -86,8 +78,6 @@ internal_nis_endetherent (void) { while (start != NULL) { - if (start->val != NULL) - free (start->val); next = start; start = start->next; free (next); -- cgit v1.2.3