From 6591c3356242ba48627beb29345e4e44242c7068 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Fri, 30 Jan 1998 11:44:34 +0000 Subject: Update. 1998-01-30 19:58 Ulrich Drepper * include/cpio.h: Move to ... * posix/cpio.h: ...here. * locale/programs/ld-collate.c: Fix typo. * signal/signal.h: Declare _sys_siglist with NSIG+1 elements. * stdio-common/tiformat.c: Add checks for %#.0o and friends. * login/utmp_file.c (pututline_file): Don't always report success if similar entry is found. Patch by Mark M. Kettenis. 1998-01-30 16:06 Philip Blundell * manual/Makefile: Don't try to install the info files if makeinfo is not available. 1998-01-30 12:05 Philip Blundell * sysdeps/unix/sysv/linux/bits/ioctls.h: Include a copy of the kernel's network ioctls, rather than using to get them. This way we are sure of maintaining compatibility if the kernel interface should change. 1998-01-30 15:52 Ulrich Drepper * sysdeps/unix/sysv/linux/Dist: Add netrose/rose.h. 1998-01-25 19:54 Philip Blundell * sysdeps/unix/sysv/linux/netrose/rose.h: New file. * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Install it. 1998-01-27 22:29 Zack Weinberg Implement System V pseudoterminal handling. * login/Makefile (routines): Add getpt, grantpt, unlockpt, ptsname. (libutil-routines): Remove pty. Add openpty, forkpty. (distribute): New internal header pty-internal.h. (others): Add the helper program, pt_chown. (install-others): Install it, in $(libexecdir), mode 4755. * login/pty-internal.h: New file. * login/openpty.c: New file. * login/forkpty.c: New file. * login/programs/pt_chown.c: New file. * libc.map: Add getpt, grantpt, unlockpt, ptsname, ptsname_r. * stdlib/stdlib.h: Prototype them. * config.make.in: Define $(libexecdir). * Makeconfig: Define $(inst_libexecdir). * sysdeps/generic/pty.c: Removed. * sysdeps/unix/sysv/linux/pty.c: Removed. * sysdeps/generic/getpt.c: Stub out. * sysdeps/generic/grantpt.c: Likewise. * sysdeps/generic/ptsname.c: Likewise. * sysdeps/generic/unlockpt.c: Likewise. * sysdeps/unix/grantpt.c: New file. * sysdeps/unix/bsd/getpt.c: New file. * sysdeps/unix/bsd/unlockpt.c: New file. * sysdeps/unix/sysv/linux/getpt.c: New file. * sysdeps/unix/sysv/linux/ptsname.c: New file. * sysdeps/unix/sysv/linux/unlockpt.c: New file. 1998-01-29 23:56 Ulrich Drepper * localedata/locales/ru_RU: Fix YESEXPR. Patch by lav@yars.free.net. 1998-01-29 Andreas Jaeger * nss/Makefile (tests): Add rule for test-netdb.c. * nss/test-netdb.c: New file. 1998-01-29 02:38 Ulrich Drepper * elf/dl-open.c (_dl_open): Make sure the variable `reloc' is really kept as a variable. Patch by Richard Henderson, reported by Jakub Jelinek . * elf/rtld.c (dl_main): Call _dl_init_paths before handling preloading. * elf/genrtldtbl.awk: Mark machine dependent directory of generated entries as not existing. 1998-01-26 Andreas Schwab * stdio-common/vfprintf.c (process_arg): Fix printing of octal zero in alternate form with precision of zero, which must produce "0". Add braces to avoid ambiguous `else'. 1998-01-26 Thorsten Kukuk * nis/nss_compat/compat-grp.c: Fix memory leak and trailing null problem with strncpy. * nis/nss_compat/compat-pwd.c: Likewise. * nis/nss_compat/comapt-spwd.c: Likewise. 1998-01-28 Andreas Jaeger * assert/assert.h (assert_perror): Correct test for errnum. Patch by uch@nop.or.jp. [PR libc/437] 1997-12-20 Andreas Schwab * locales/pl_PL: Fix int_curr_symbol. 1998-01-26 Andreas Jaeger * nis/nis_cache.c: Include for declaration of close. 1998-01-06 Andreas Jaeger * stdio-common/test-popen.c: Include . * sysdeps/unix/sysv/linux/if_index.c: Include for close. * inet/getnetgrent_r.c: Include . * db2/db/db_conv.c: Include for memcpy. * gmon/bb_exit_func.c: Include instead of so that memcpy is declared. * iconv/iconv_open.c: Include for alloca. * misc/init-misc.c: Remove unneeded inclusion of . 1998-01-26 Andreas Jaeger * pwd/fgetpwent_r.c (__fgetpwent_r): Correctly handle buffer overflow while reading line with fgets. * grp/fgetgrent_r.c (__fgetgrent_r): Likewise. 1998-01-27 00:46 Ulrich Drepper * sysdeps/unix/sysv/linux/bits/types.h (__ipc_pid_t): Change to unsigned short, not short. Reported by Andreas Jaeger. 1998-01-06 Andreas Jaeger * sysdeps/unix/sysv/linux/mips/syscalls.list: Correct typo (ccept->accept). * sysdeps/generic/inttypes.h: Fix spelling. 1998-01-04 Andreas Jaeger * sysdeps/unix/sysv/linux/arm/Dist: Add bits/mman.h. * sysdeps/unix/sysv/linux/alpha/Dist: Add net/route.h. 1998-01-27 00:30 Ulrich Drepper * stdio-common/printf.h (struct print_info): Add new bitfield is_char. * stdio-common/printf-parse.h (parse_one_spec): Fill in is_char field for hh modifier. * stdio-common/vfprint.c: Use is_char field and do not depend in is_short having the value 2. Bug reported by Andreas Jaeger. 1998-01-05 Andreas Jaeger * libio/freopen.c (freopen): Call _IO_old_freopen only if defined PIC && DO_VERSIONING. 1998-01-24 Andreas Schwab * Rules: Add rules for $(common-objpfx)dummy$o. --- login/Makefile | 16 ++++++--- login/forkpty.c | 56 ++++++++++++++++++++++++++++++ login/openpty.c | 73 +++++++++++++++++++++++++++++++++++++++ login/programs/pt_chown.c | 88 +++++++++++++++++++++++++++++++++++++++++++++++ login/pty-internal.h | 41 ++++++++++++++++++++++ login/utmp_file.c | 10 +++--- 6 files changed, 275 insertions(+), 9 deletions(-) create mode 100644 login/forkpty.c create mode 100644 login/openpty.c create mode 100644 login/programs/pt_chown.c create mode 100644 login/pty-internal.h (limited to 'login') diff --git a/login/Makefile b/login/Makefile index 3842b2f4af..04c6eeb8a4 100644 --- a/login/Makefile +++ b/login/Makefile @@ -1,4 +1,4 @@ -# Copyright (C) 1996, 1997 Free Software Foundation, Inc. +# Copyright (C) 1996, 1997, 1998 Free Software Foundation, Inc. # This file is part of the GNU C Library. # The GNU C Library is free software; you can redistribute it and/or @@ -25,10 +25,14 @@ subdir := login headers := utmp.h bits/utmp.h utmpx.h bits/utmpx.h lastlog.h pty.h routines := getutent getutent_r getutid getutline getutid_r getutline_r \ - utmp_file utmp_daemon utmpname updwtmp + utmp_file utmp_daemon utmpname updwtmp \ + getpt grantpt unlockpt ptsname -others = utmpd utmpdump +CFLAGS-grantpt.c = -DLIBEXECDIR='"$(libexecdir)"' + +others = utmpd utmpdump pt_chown install-sbin = utmpd +install-others = $(inst_libexecdir)/pt_chown utmpd-routines := connection database error request xtmp extra-objs := $(utmpd-routines:=.o) @@ -42,11 +46,15 @@ vpath %.c programs extra-libs := libutil extra-libs-others := $(extra-libs) -libutil-routines:= login login_tty logout logwtmp pty +libutil-routines:= login login_tty logout logwtmp openpty forkpty libutil-map := libutil.map include ../Rules +# pt_chown needs to be setuid root. +$(inst_libexecdir)/pt_chown: $(objpfx)pt_chown + $(INSTALL) -m 4755 -o root $< $@ + $(objpfx)utmpd: $(utmpd-routines:%=$(objpfx)%.o) # Depend on libc.so so a DT_NEEDED is generated in the shared objects. diff --git a/login/forkpty.c b/login/forkpty.c new file mode 100644 index 0000000000..e0e3cce9f9 --- /dev/null +++ b/login/forkpty.c @@ -0,0 +1,56 @@ +/* Copyright (C) 1998 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by Zack Weinberg , 1998. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public + License along with the GNU C Library; see the file COPYING.LIB. If not, + write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +#include +#include +#include +#include +#include + +int +forkpty (amaster, name, termp, winp) + int *amaster; + char *name; + struct termios *termp; + struct winsize *winp; +{ + int master, slave, pid; + + if (openpty (&master, &slave, name, termp, winp) == -1) + return -1; + + switch (pid = fork ()) + { + case -1: + return -1; + case 0: + /* Child. */ + close (master); + if (login_tty (slave)) + _exit (1); + + return 0; + default: + /* Parent. */ + *amaster = master; + close (slave); + + return pid; + } +} diff --git a/login/openpty.c b/login/openpty.c new file mode 100644 index 0000000000..12e82072bc --- /dev/null +++ b/login/openpty.c @@ -0,0 +1,73 @@ +/* Copyright (C) 1998 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by Zack Weinberg , 1998. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public + License along with the GNU C Library; see the file COPYING.LIB. If not, + write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +#include +#include +#include +#include +#include +#include +#include + +#include "pty-internal.h" + +int +openpty (pmast, pslave, pname, tio, wins) + int *pmast; + int *pslave; + char *pname; + struct termios *tio; + struct winsize *wins; +{ + int pfd, tfd; + char name[PTYNAMELEN]; + + pfd = getpt (); + if (pfd == -1) + return -1; + + if (grantpt (pfd)) + goto bail; + + if (unlockpt (pfd)) + goto bail; + + if (!ptsname_r (pfd, name, PTYNAMELEN)) + goto bail; + + tfd = open (name, O_RDWR); + if (tfd == -1) + goto bail; + + /* XXX Should we ignore errors here? */ + if(tio) + tcsetattr (tfd, TCSAFLUSH, tio); + if (wins) + ioctl (tfd, TIOCSWINSZ, wins); + + *pmast = pfd; + *pslave = tfd; + if (pname != NULL) + strcpy (pname, name); + return 0; + +bail: + close (pfd); + return -1; +} diff --git a/login/programs/pt_chown.c b/login/programs/pt_chown.c new file mode 100644 index 0000000000..dbf79fc6ad --- /dev/null +++ b/login/programs/pt_chown.c @@ -0,0 +1,88 @@ +/* Copyright (C) 1998 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by C. Scott Ananian , 1998. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public + License along with the GNU C Library; see the file COPYING.LIB. If not, + write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +/* pt_chmod.c ... securely implement grantpt in user-land. */ + +#include +#include +#include +#include +#include +#include +#include + +#include "pty-internal.h" +#define Str(x) _Str(x) +#define _Str(x) #x + +void +usage (void) +{ + fprintf (stderr, _("usage: pt_chown FD>&%s\n" + "This program is used internally by grantpt(3).\n"), + Str (PTY_FD)); + exit (0); +} + +void +bad_installation (void) +{ + fputs (_("pt_chown: installation problem: " + "This program needs to be setuid root.\n"), stderr); + exit (FAIL_EXEC); +} + +int +main (int argc, char **argv) +{ + struct group *grp; + struct stat s; + char *pty; + gid_t gid; + uid_t uid; + + if (argc != 1) + usage (); + if (geteuid () != 0) + bad_installation (); + + grp = getgrnam (TTY_GROUP); + gid = grp ? grp->gr_gid : getgid (); + uid = getuid (); + + /* Check that fd is a valid pty master -- call ptsname(). */ + pty = ptsname (PTY_FD); + if (pty == NULL) + return errno == EBADF ? FAIL_EBADF : FAIL_EINVAL; + close (PTY_FD); + + /* Check that target file is a character device. */ + if (stat (pty, &s)) + return FAIL_EINVAL; /* This should only fail if pty doesn't exist. */ + if (!S_ISCHR (s.st_mode)) + return FAIL_EINVAL; + + if (chmod (pty, 0620)) + return FAIL_EACCES; /* XXX: Probably not true. */ + + if (chown (pty, uid, gid)) + return FAIL_EACCES; + + return 0; +} diff --git a/login/pty-internal.h b/login/pty-internal.h new file mode 100644 index 0000000000..c1858861ec --- /dev/null +++ b/login/pty-internal.h @@ -0,0 +1,41 @@ +/* Copyright (C) 1998 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by Zack Weinberg , 1998. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public + License along with the GNU C Library; see the file COPYING.LIB. If not, + write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +/* Internal constants used by the pseudoterminal handling code. */ + +#ifndef _PTY_INTERNAL_H +#define _PTY_INTERNAL_H 1 + +/* Length of a buffer to hold a pty name. */ +#define PTYNAMELEN 15 /* "/dev/pts/65535$" */ + +/* Which group should pty slaves belong to: */ +#define TTY_GROUP "tty" + +/* Communication between grantpt and pt_chown. */ +#define PTY_FD 3 +enum /* failure modes */ +{ + FAIL_EBADF = 1, + FAIL_EINVAL, + FAIL_EACCES, + FAIL_EXEC +}; + +#endif diff --git a/login/utmp_file.c b/login/utmp_file.c index bea63644f7..d25dcb8600 100644 --- a/login/utmp_file.c +++ b/login/utmp_file.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1996, 1997 Free Software Foundation, Inc. +/* Copyright (C) 1996, 1997, 1998 Free Software Foundation, Inc. This file is part of the GNU C Library. Contributed by Ulrich Drepper and Paul Janzen , 1996. @@ -390,12 +390,12 @@ pututline_file (const struct utmp *data) } /* Write the new data. */ - if (write (file_fd, data, sizeof (struct utmp)) != sizeof (struct utmp) + if (write (file_fd, data, sizeof (struct utmp)) != sizeof (struct utmp)) + { /* If we appended a new record this is only partially written. Remove it. */ - && found < 0) - { - (void) ftruncate (file_fd, file_offset); + if (found < 0) + (void) ftruncate (file_fd, file_offset); pbuf = NULL; } else -- cgit v1.2.3