From aaacde11f2e814814fdd19dfb683e76f1dede4d5 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 12 Jul 2021 18:43:32 +0200 Subject: Reduce pollution due to dynamic PTHREAD_STACK_MIN used to be a header file with no declarations. GCC's libgomp includes it in a #pragma GCC visibility hidden block. Including from (indirectly) declares everything in with hidden visibility, resulting in linker failures. This commit avoids C declarations in assembler mode and only declares __sysconf in (and not the entire contents of ). The __sysconf symbol is already part of the ABI. PTHREAD_STACK_MIN is no longer defined for __USE_DYNAMIC_STACK_SIZE && __ASSEMBLER__ because there is no possible definition. Additionally, PTHREAD_STACK_MIN is now defined by for __USE_MISC because this is what developers expect based on the macro name. It also helps to avoid libgomp linker failures in GCC because libgomp includes before its visibility hacks. Reviewed-by: Carlos O'Donell --- include/bits/local_lim.h | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 include/bits/local_lim.h (limited to 'include/bits') diff --git a/include/bits/local_lim.h b/include/bits/local_lim.h deleted file mode 100644 index 46d82dc729..0000000000 --- a/include/bits/local_lim.h +++ /dev/null @@ -1,7 +0,0 @@ -/* Don't define PTHREAD_STACK_MIN to sysconf (_SC_THREAD_STACK_MIN) for - glibc build. */ -#if !defined _ISOMAC -# undef __USE_DYNAMIC_STACK_SIZE -#endif - -#include_next -- cgit v1.2.3