From f1ffad98be7ec4111fbd1cd1f58f3e3343257519 Mon Sep 17 00:00:00 2001 From: Stefan Liebler Date: Wed, 26 Aug 2015 10:26:24 +0200 Subject: S390: Optimize strspn and wcsspn. This patch provides optimized versions of strspn and wcsspn with the z13 vector instructions. ChangeLog: * sysdeps/s390/multiarch/strspn-c.c: New File. * sysdeps/s390/multiarch/strspn-vx.S: Likewise. * sysdeps/s390/multiarch/strspn.c: Likewise. * sysdeps/s390/multiarch/wcsspn-c.c: Likewise. * sysdeps/s390/multiarch/wcsspn-vx.S: Likewise. * sysdeps/s390/multiarch/wcsspn.c: Likewise. * wcsmbs/wcsspn.c: Use WCSSPN if defined. * sysdeps/s390/multiarch/Makefile (sysdep_routines): Add strspn and wcsspn functions. * sysdeps/s390/multiarch/ifunc-impl-list.c (__libc_ifunc_impl_list): Add ifunc test for strspn, wcsspn. * string/test-strspn.c: Add wcsspn support. * wcsmbs/test-wcsspn.c: New File. * wcsmbs/Makefile (strop-tests): Add wcsspn. * benchtests/bench-strspn.c: Add wcsspn support. * benchtests/bench-wcsspn.c: New File. * benchtests/Makefile (wcsmbs-bench): Add wcsspn. --- benchtests/Makefile | 2 +- benchtests/bench-strspn.c | 73 +++++++++++++++++++++++++++++++---------------- benchtests/bench-wcsspn.c | 20 +++++++++++++ 3 files changed, 70 insertions(+), 25 deletions(-) create mode 100644 benchtests/bench-wcsspn.c (limited to 'benchtests') diff --git a/benchtests/Makefile b/benchtests/Makefile index 6a0052a255..f00196b55a 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -37,7 +37,7 @@ string-bench := bcopy bzero memccpy memchr memcmp memcpy memmem memmove \ strspn strstr strcpy_chk stpcpy_chk memrchr strsep strtok \ strcoll wcsmbs-bench := wcslen wcsnlen wcscpy wcpcpy wcsncpy wcpncpy wcscat wcsncat \ - wcscmp wcsncmp wcschr wcschrnul wcsrchr + wcscmp wcsncmp wcschr wcschrnul wcsrchr wcsspn string-bench-all := $(string-bench) ${wcsmbs-bench} # We have to generate locales diff --git a/benchtests/bench-strspn.c b/benchtests/bench-strspn.c index 6061f2b5ce..88192dd4c2 100644 --- a/benchtests/bench-strspn.c +++ b/benchtests/bench-strspn.c @@ -17,22 +17,47 @@ . */ #define TEST_MAIN -#define TEST_NAME "strspn" +#ifndef WIDE +# define TEST_NAME "strspn" +#else +# define TEST_NAME "wcsspn" +#endif /* WIDE */ #include "bench-string.h" -typedef size_t (*proto_t) (const char *, const char *); -size_t simple_strspn (const char *, const char *); -size_t stupid_strspn (const char *, const char *); - -IMPL (stupid_strspn, 0) -IMPL (simple_strspn, 0) -IMPL (strspn, 1) +#ifndef WIDE +# define STRSPN strspn +# define CHAR char +# define SIMPLE_STRSPN simple_strspn +# define STUPID_STRSPN stupid_strspn +# define STRLEN strlen +# define STRCHR strchr +# define BIG_CHAR CHAR_MAX +# define SMALL_CHAR 127 +#else +# include +# define STRSPN wcsspn +# define CHAR wchar_t +# define SIMPLE_STRSPN simple_wcsspn +# define STUPID_STRSPN stupid_wcsspn +# define STRLEN wcslen +# define STRCHR wcschr +# define BIG_CHAR WCHAR_MAX +# define SMALL_CHAR 1273 +#endif /* WIDE */ + +typedef size_t (*proto_t) (const CHAR *, const CHAR *); +size_t SIMPLE_STRSPN (const CHAR *, const CHAR *); +size_t STUPID_STRSPN (const CHAR *, const CHAR *); + +IMPL (STUPID_STRSPN, 0) +IMPL (SIMPLE_STRSPN, 0) +IMPL (STRSPN, 1) size_t -simple_strspn (const char *s, const char *acc) +SIMPLE_STRSPN (const CHAR *s, const CHAR *acc) { - const char *r, *str = s; - char c; + const CHAR *r, *str = s; + CHAR c; while ((c = *s++) != '\0') { @@ -46,9 +71,9 @@ simple_strspn (const char *s, const char *acc) } size_t -stupid_strspn (const char *s, const char *acc) +STUPID_STRSPN (const CHAR *s, const CHAR *acc) { - size_t ns = strlen (s), nacc = strlen (acc); + size_t ns = STRLEN (s), nacc = STRLEN (acc); size_t i, j; for (i = 0; i < ns; ++i) @@ -63,7 +88,7 @@ stupid_strspn (const char *s, const char *acc) } static void -do_one_test (impl_t *impl, const char *s, const char *acc, size_t exp_res) +do_one_test (impl_t *impl, const CHAR *s, const CHAR *acc, size_t exp_res) { size_t res = CALL (impl, s, acc), i, iters = INNER_LOOP_ITERS; timing_t start, stop, cur; @@ -92,34 +117,34 @@ static void do_test (size_t align, size_t pos, size_t len) { size_t i; - char *acc, *s; + CHAR *acc, *s; align &= 7; - if (align + pos + 10 >= page_size || len > 240 || ! len) + if ((align + pos + 10) * sizeof (CHAR) >= page_size || len > 240 || ! len) return; - acc = (char *) (buf2 + (random () & 255)); - s = (char *) (buf1 + align); + acc = (CHAR *) (buf2) + (random () & 255); + s = (CHAR *) (buf1) + align; for (i = 0; i < len; ++i) { - acc[i] = random () & 255; + acc[i] = random () & BIG_CHAR; if (!acc[i]) - acc[i] = random () & 255; + acc[i] = random () & BIG_CHAR; if (!acc[i]) - acc[i] = 1 + (random () & 127); + acc[i] = 1 + (random () & SMALL_CHAR); } acc[len] = '\0'; for (i = 0; i < pos; ++i) s[i] = acc[random () % len]; - s[pos] = random () & 255; - if (strchr (acc, s[pos])) + s[pos] = random () & BIG_CHAR; + if (STRCHR (acc, s[pos])) s[pos] = '\0'; else { for (i = pos + 1; i < pos + 10; ++i) - s[i] = random () & 255; + s[i] = random () & BIG_CHAR; s[i] = '\0'; } diff --git a/benchtests/bench-wcsspn.c b/benchtests/bench-wcsspn.c new file mode 100644 index 0000000000..7bdef509d5 --- /dev/null +++ b/benchtests/bench-wcsspn.c @@ -0,0 +1,20 @@ +/* Measure wcsspn functions. + Copyright (C) 2015 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define WIDE 1 +#include "bench-strspn.c" -- cgit v1.2.3