From 520d437b9455560d099fe6bd9664be1f9f76868b Mon Sep 17 00:00:00 2001 From: Siddhesh Poyarekar Date: Tue, 3 Dec 2013 12:26:12 +0530 Subject: [BZ #16195] Fix build warnings from systemtap probes in non-systemtap configurations Joseph pointed out in the bug report (and in an earlier thread) that systemtap probes cause build time warnings like the following: ../sysdeps/ieee754/dbl-64/e_atan2.c:602:4: warning: the address of 'p' will always evaluate as 'true' [-Waddress] due to the fact that we're now passing non-weak variables to LIBC_PROBE in the libm probes. This happens only on configurations that do not enable systemtap. The macro definition of LIBC_PROBE in this case only acts as a sanity checker to ensure that the number parameters passed to LIBC_PROBE is equal to the argument count parameter passed before it. This can be done in a much simpler manner by just adding a macro definition for each number of arguments. I am assuming here that we don't really want to bother with supporting LIBC_PROBE with an indeterminate number of arguments and if there is a need for a probe to have more data than what is currently supported (4 arguments), one could simply add an additional macro here. --- ChangeLog | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index de634b4d41..182051a727 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2013-12-03 Siddhesh Poyarekar + + [BZ #16195] + * include/stap-probe.h [!USE_STAP_PROBE && !__ASSEMBLER__] + (LIBC_PROBE): Change definition to call STAP_PROBE* macros. + (STAP_PROBE0): New macro. + (STAP_PROBE1): Likewise. + (STAP_PROBE2): Likewise. + (STAP_PROBE3): Likewise. + (STAP_PROBE4): Likewise. + 2013-12-02 Ondřej Bílka * manual/llio.texi (Memory-mapped I/O): Add shm_open and shm_close. -- cgit v1.2.3