From 12892ded5d913b3c45ea8f22634afd3b273b473d Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Fri, 2 Aug 2002 01:33:11 +0000 Subject: (xdr_array): Check for overflow on multiplication. --- sunrpc/xdr_array.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sunrpc/xdr_array.c b/sunrpc/xdr_array.c index 461a6ad9d8..9f67e7fe62 100644 --- a/sunrpc/xdr_array.c +++ b/sunrpc/xdr_array.c @@ -45,6 +45,7 @@ static char sccsid[] = "@(#)xdr_array.c 1.10 87/08/11 Copyr 1984 Sun Micro"; #include #include #include +#include #ifdef USE_IN_LIBIO # include @@ -81,7 +82,11 @@ xdr_array (xdrs, addrp, sizep, maxsize, elsize, elproc) return FALSE; } c = *sizep; - if ((c > maxsize) && (xdrs->x_op != XDR_FREE)) + /* + * XXX: Let the overflow possibly happen with XDR_FREE because mem_free() + * doesn't actually use its second argument anyway. + */ + if ((c > maxsize || c > UINT_MAX / elsize) && (xdrs->x_op != XDR_FREE)) { return FALSE; } -- cgit v1.2.3