aboutsummaryrefslogtreecommitdiff
path: root/sysdeps
AgeCommit message (Collapse)Author
2017-08-03tst-tlsopt-powerpc as a shared libAlan Modra
This makes the __tls_get_addr_opt test run as a shared library, and so actually test that DTPMOD64/DTPREL64 pairs are processed by ld.so to support the __tls_get_adfr_opt call stub fast return. After a 2017-01-24 patch (binutils f0158f4416) ld.bfd no longer emitted unnecessary dynamic relocations against local thread variables, instead setting up the __tls_index GOT entries for the call stub fast return. This meant tst-tlsopt-powerpc passed but did not check ld.so relocation support. After a 2017-07-16 patch (binutils 676ee2b5fa) ld.bfd no longer set up the __tls_index GOT entries for the call stub fast return, and tst-tlsopt-powerpc failed. Compiling mod-tlsopt-powerpc.c with -DSHARED exposed a bug in powerpc64/tls-macros.h, which defines a __TLS_GET_ADDR macro that clashes with one defined in dl-tls.h. The tls-macros.h version is only used in that file, so delete it and expand. * sysdeps/powerpc/mod-tlsopt-powerpc.c: Extract from tst-tlsopt-powerpc.c with function name change and no test harness. * sysdeps/powerpc/tst-tlsopt-powerpc.c: Remove body of test. Call tls_get_addr_opt_test. * sysdeps/powerpc/Makefile (LDFLAGS-tst-tlsopt-powerpc): Don't define. (modules-names): Add mod-tlsopt-powerpc. (mod-tlsopt-powerpc.so-no-z-defs): Define. (tst-tlsopt-powerpc): Depend on .so. * sysdeps/powerpc/powerpc64/tls-macros.h (__TLS_GET_ADDR): Don't define. Expand use in TLS_GD and TLS_LD.
2017-08-03Add missing include for pthread_setcancelstateSamuel Thibault
* sysdeps/posix/shm_open.c: Include <pthread.h>.
2017-08-02[hurd]: Add __libc_init_secure stubSamuel Thibault
csu/libc-start.c now insists on calling __libc_init_secure, while the Hurd port already implements it "very early" in dl-sysdep.c and init-first.c * sysdeps/mach/hurd/enbl-secure.c (__libc_init_secure): Define function.
2017-08-02x86-64: Check PIC instead of SHARED in start.SH.J. Lu
Since start.o may be compiled as PIC, we should check PIC instead of SHARED. * sysdeps/x86_64/start.S (_start): Check PIC instead of SHARED.
2017-08-02i386: Check PIC to enable PIC setups in multiarch functionsH.J. Lu
Check PIC, instead of SHARED, to enable PIC setups. * sysdeps/i386/i686/multiarch/memcmp-sse4.S: Check PIC instead of SHARED. * sysdeps/i386/i686/multiarch/memcpy-sse2-unaligned.S: Likewise. * sysdeps/i386/i686/multiarch/memcpy-ssse3-rep.S: Likewise. * sysdeps/i386/i686/multiarch/memcpy-ssse3.S: Likewise. * sysdeps/i386/i686/multiarch/memset-sse2-rep.S: Likewise. * sysdeps/i386/i686/multiarch/memset-sse2.S: Likewise. * sysdeps/i386/i686/multiarch/strcat-sse2.S: Likewise. * sysdeps/i386/i686/multiarch/strcpy-sse2.S: Likewise.
2017-08-02i386: Don't define multiarch __memmove_chk in libc.a [BZ #21791]H.J. Lu
There is no need to define multiarch __memmove_chk in libc.a since they aren't used at all. [BZ #21791] * sysdeps/i386/i686/multiarch/memcpy-sse2-unaligned.S (MEMCPY_CHK): Define only if SHARED is defined. * sysdeps/i386/i686/multiarch/memcpy-ssse3-rep.S (MEMCPY_CHK): Likewise. * sysdeps/i386/i686/multiarch/memcpy-ssse3.S (MEMCPY_CHK): Likewise.
2017-07-28microblaze: Resolve non-relocatable branch in pt-vfork.S (BZ#21779)Nathan Rossi
The relative branch directly to __libc_vfork results in an relocation that cannot be resolved. Specifically a R_MICROBLAZE_64_PCREL relocation is created for this branch, however for MicroBlaze R_MICROBLAZE_64_PCREL type relocations symbols are not resolved. Additionally due to the branch being located in the .text section the instruction cannot be rewritten as the section is not writable, and causes a segfault at runtime when loading libpthread. To resolve this issue, ensure the branch is done using PLT. This removes the need to modify the instruction and trades the R_MICROBLAZE_64_PCREL for a more common R_MICROBLAZE_JUMP via the PLT. [BZ #21779] * sysdeps/unix/sysv/linux/microblaze/pt-vfork.S: Branch using PLT.
2017-07-28Update Microblaze libm-test-ulpsNathan Rossi
* sysdeps/microblaze/libm-test-ulps: Update.
2017-07-28Update Nios II ULPs file.Chung-Lin Tang
2017-07-27Update Alpha libm-test-ulpsAdhemerval Zanella
* sysdeps/alpha/fpu/libm-test-ulps: Update.
2017-07-24tunables: Use direct syscall for access (BZ#21744)Adhemerval Zanella
The function maybe_enable_malloc_check, which is called by __tunables_init, calls __access_noerrno. It isn't problem when symbol is is in ld.so, which has a special version of __access_noerrno without stack protector. But when glibc is built with stack protector, maybe_enable_malloc_check in libc.a can't call the regular version of __access_noerrno with stack protector. This patch changes how Linux defines the __access_noerrno to be an inline call instead and thus preventing defining different build rules for ld/static and shared. H.J. Lu <hongjiu.lu@intel.com> Adhemerval Zanella <adhemerval.zanella@linaro.org> [BZ #21744] * elf/dl-tunables.c: Include not-errno.h header. * include/unistd.h (__access_noerrno): Remove definition. * sysdeps/unix/sysv/linux/access.c (__access_noerrno): Likewise. * sysdeps/generic/not-errno.h: New file. * sysdeps/unix/sysv/linux/not-errno.h: Likewise.
2017-07-24Avoid accessing corrupted stack from __stack_chk_fail [BZ #21752]H.J. Lu
__libc_argv[0] points to address on stack and __libc_secure_getenv accesses environment variables which are on stack. We should avoid accessing stack when stack is corrupted. This patch also renames function argument in __fortify_fail_abort from do_backtrace to need_backtrace to avoid confusion with do_backtrace from enum __libc_message_action. [BZ #21752] * debug/fortify_fail.c (__fortify_fail_abort): Don't pass down __libc_argv[0] if we aren't doing backtrace. Rename do_backtrace to need_backtrace. * sysdeps/posix/libc_fatal.c (__libc_message): Don't call __libc_secure_getenv if we aren't doing backtrace.
2017-07-24Remove extra semicolons in struct pthread_mutex (bug 21804)Andreas Schwab
2017-07-23S390: fix sys/ptrace.h to make it includible again after asm/ptrace.hDmitry V. Levin
sys/ptrace.h on S390 used to be includible both before and after asm/ptrace.h, until commit b08a6a0dea63742313ed3d9577c1e2d83436b196 among other changes introduced PTRACE_SINGLEBLOCK enum constant which is also defined in asm/ptrace.h as a macro, making sys/ptrace.h fail to compile when included after asm/ptrace.h. * sysdeps/unix/sysv/linux/s390/sys/ptrace.h [_LINUX_PTRACE_H || _S390_PTRACE_H]: Undefine all PTRACE_* macro constants defined later as enum constants, except PTRACE_PEEKUSER, PTRACE_POKEUSER, and PTRACE_SEIZE_DEVEL that are not defined by Linux headers.
2017-07-23[BZ 19170]John David Anglin
Revise comment in sysdeps/hppa/dl-trampoline.S
2017-07-21Fix cexpl when compiled with latest GCCSteve Ellcey
* sysdeps/ieee754/ldbl-128/e_expl.c (__ieee754_expl): Call math_force_eval.
2017-07-19Update sparc ulpsAdhemerval Zanella
* sysdeps/sparc/fpu/libm-test-ulps: Update.
2017-07-19alpha: Fix clone exit syscall argument passing (BZ#21512)Adhemerval Zanella
This patch fixes the argument passing for exit syscall after the clone function returns on hppa. This fixes misc/tst-clone2 on alpha-linux-gnu. Checked misc/tst-clone2 on alpha-linux-gnu. [BZ #21512] * sysdeps/unix/sysv/linux/alpha/clone.S (__clone): Fix argument passing to syscall exit.
2017-07-19i386: Test memmove_chk and memset_chk only in libc.so [BZ #21741]H.J. Lu
Since there are no multiarch versions of memmove_chk and memset_chk, test multiarch versions of memmove_chk and memset_chk only in libc.so. [BZ #21741] * sysdeps/i386/i686/multiarch/ifunc-impl-list.c (__libc_ifunc_impl_list): Test memmove_chk and memset_chk only in libc.so.
2017-07-19[AArch64] Update dl-procinfo for new HWCAP flags in Linux 4.12Szabolcs Nagy
Follow up to commit 512d245bc30cca893db6979f42f058e734f345c3. * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.c: (_dl_aarch64_cap_flags): Update. * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h (_DL_HWCAP_COUNT, _DL_HWCAP_LAST): Update.
2017-07-18[AArch64] Fix out of bound array access regressionSzabolcs Nagy
Partially revert ea01a4da219011f4a4db97eef3c5bfc2f6e8fc6b "aarch64: Add hwcap string routines" because _dl_procinfo cannot be future proof and avoid oob access in _dl_hwcap_string.
2017-07-17powerpc: Fix float128 IFUNC relocations [BZ #21707]Tulio Magno Quites Machado Filho
The patch proposed by Peter Bergner [1] to libgcc in order to fix [BZ #21707] adds a dependency on a symbol provided by the loader, forcing the loader to be linked to tests after libgcc was linked. It also requires to read the thread pointer during IRELA relocations. Tested on powerpc, powerpc64, powerpc64le, s390x and x86_64. [1] https://sourceware.org/ml/libc-alpha/2017-06/msg01383.html [BZ #21707] * csu/libc-start.c (LIBC_START_MAIN): Perform IREL{,A} relocations before or after initializing the TCB on statically linked executables. That's a per-architecture definition. * elf/rtld.c (dl_main): Add a comment about thread-local variables initialization. * sysdeps/generic/libc-start.h: New file. Define ARCH_APPLY_IREL and ARCH_SETUP_IREL. * sysdeps/powerpc/Makefile: [$(subdir) = elf && $(multi-arch) != no] (tests-static-internal): Add tst-tlsifunc-static. [$(subdir) = elf && $(multi-arch) != no && $(build-shared) == yes] (tests-internal): Add tst-tlsifunc. * sysdeps/powerpc/tst-tlsifunc.c: New file. * sysdeps/powerpc/tst-tlsifunc-static.c: Likewise. * sysdeps/powerpc/powerpc64le/Makefile (f128-loader-link): New variable. [$(subdir) = math] (test-float128% test-ifloat128%): Force linking to the loader after linking to libgcc. [$(subdir) = wcsmbs || $(subdir) = stdlib] (bug-strtod bug-strtod2) (bug-strtod2 tst-strtod-round tst-wcstod-round tst-strtod6 tst-strrom) (tst-strfrom-locale strfrom-skeleton): Likewise. * sysdeps/unix/sysv/linux/powerpc/libc-start.h: New file. Define ARCH_APPLY_IREL and ARCH_SETUP_IREL.
2017-07-17hppa: Fix clone exit syscall argument passing (BZ#21512)Adhemerval Zanella
This patch fixes the argument passing for exit syscall after the clone function returns on hppa. This fixes misc/tst-clone2 on hppa-linux-gnu. Checked misc/tst-clone2 on hppa-linux-gnu. [BZ #21512] * sysdeps/unix/sysv/linux/hppa/clone.S (__clone): Fix argument passing to syscall exit.
2017-07-17Add HWCAP_ macros from Linux 4.12 to AArch64 bits/hwcap.h.Szabolcs Nagy
This patch adds the HWCAP_JSCVT, HWCAP_FCMA and HWCAP_LRCPC macros from Linux 4.12 to the AArch64 bits/hwcap.h. * sysdeps/unix/sysv/linux/aarch64/bits/hwcap.h (HWCAP_FCMA): New macro. (HWCAP_JSCVT, HWCAP_LRCPC): Likewise.
2017-07-16Return to caller if dl_fixup fails to resolve callee on hppa.John David Anglin
2017-07-16Add CFI annotation.John David Anglin
2017-07-16Fix stack offset for r19 load in __getcontext.John David Anglin
2017-07-16Fix __setcontext return value on hppa.John David Anglin
2017-07-16Fix syscall cancellation on hppa.John David Anglin
2017-07-16Remove _exit entry from sysdeps/unix/sysv/linux/hppa/localplt.data.John David Anglin
2017-07-16Remove extra braces from sysdeps/hppa/__longjmp.c.John David Anglin
2017-07-16Fix [BZ 20098].John David Anglin
2017-07-15Fix [BZ locale/19838].John David Anglin
2017-07-15Fix failing sNaN tests on hppa.John David Anglin
2017-07-13[ARM] Fix ld.so crash when built using Binutils 2.29Jiong Wang
There is bug report that ld.so in GLIBC 2.24 built by Binutils 2.29 will crash on arm-linux-gnueabihf. This is confirmed, and the details is at: https://sourceware.org/bugzilla/show_bug.cgi?id=21725. As analyzed in the PR, the old code was with the assumption that assembler won't set bit0 of thumb function address if it comes from PC-relative instructions and the calculation can be finished during assembling. This assumption however does not hold after PR gas/21458. * sysdeps/arm/dl-machine.h (elf_machine_load_address): Also strip bit 0 of pcrel_address under Thumb mode.
2017-07-12Fix type in sysdeps/hppa/dl-machine.h.John David Anglin
2017-07-11powerpc64le: Iterate over all object suffixes when appending -mfloat128Gabriel F. T. Gomes
On powerpc64le, the compilation of the files related to float128 support requires the option -mfloat128 to be passed to gcc. However, not all possible object suffixes were covered in the Makefile. This patch uses $(all-object-suffixes) in all remaining rules. Tested for powerpc64le. * sysdeps/powerpc/powerpc64le/Makefile: Use $(all-object-suffixes) to iterate over all possible object suffixes. Add a comment explaining the use of sysdep-CFLAGS instead of CFLAGS.
2017-07-11Avoid backtrace from __stack_chk_fail [BZ #12189]H.J. Lu
__stack_chk_fail is called on corrupted stack. Stack backtrace is very unreliable against corrupted stack. __libc_message is changed to accept enum __libc_message_action and call BEFORE_ABORT only if action includes do_backtrace. __fortify_fail_abort is added to avoid backtrace from __stack_chk_fail. [BZ #12189] * debug/Makefile (CFLAGS-tst-ssp-1.c): New. (tests): Add tst-ssp-1 if -fstack-protector works. * debug/fortify_fail.c: Include <stdbool.h>. (_fortify_fail_abort): New function. (__fortify_fail): Call _fortify_fail_abort. (__fortify_fail_abort): Add a hidden definition. * debug/stack_chk_fail.c: Include <stdbool.h>. (__stack_chk_fail): Call __fortify_fail_abort, instead of __fortify_fail. * debug/tst-ssp-1.c: New file. * include/stdio.h (__libc_message_action): New enum. (__libc_message): Replace int with enum __libc_message_action. (__fortify_fail_abort): New hidden prototype. * malloc/malloc.c (malloc_printerr): Update __libc_message calls. * sysdeps/posix/libc_fatal.c (__libc_message): Replace int with enum __libc_message_action. Call BEFORE_ABORT only if action includes do_backtrace. (__libc_fatal): Update __libc_message call.
2017-07-11posix: Add p{read,write}v2 RWF_NOWAIT flag (BZ#21738)Adhemerval Zanella
Linux 4.12 (b745fafaf70c0a98a2e1e7ac8cb14542889ceb0e) adds a new p{read,write}v2 flag RWF_NOWAIT. This patch adds it for linux uio-ext.h header. Checked on x86_64-linux-gnu (on a 4.10 kernel). [BZ #21738] * manual/llio.texi (RWF_NOWAIT): New item. * misc/tst-preadvwritev2-common.c (do_test_with_invalid_flags): Add RWF_NOWAIT check. * sysdeps/unix/sysv/linux/bits/uio-ext.h (RWF_NOWAIT): New flag.
2017-07-11S390: Fix tst-ptrace-singleblock if kernel does not support PTRACE_SINGLEBLOCK.Stefan Liebler
The request PTRACE_SINGLEBLOCK was introduced in Linux 3.15. Thus the ptrace call will fail on older kernels. Thus the test is now testing PTRACE_SINGLEBLOCK with data argument pointing to a buffer on stack which is assumed to fail. If the request would be interpreted as PTRACE_GETREGS, then the ptrace call will not fail and the regs are written to buf. If we run with a kernel with support for PTRACE_SINGLEBLOCK a ptrace call with data=NULL, returns zero with no error. If we run with a kernel without support for PTRACE_SINGLEBLOCK a ptrace call with data=NULL reports an error. In the latter case, the test is just continuing with PTRACE_CONT. ChangeLog: * sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c: Support running on kernels without PTRACE_SINGLEBLOCK.
2017-07-10x86-64: Test memmove_chk and memset_chk only in libc.so [BZ #21741]H.J. Lu
Since there are no multiarch versions of memmove_chk and memset_chk, test multiarch versions of memmove_chk and memset_chk only in libc.so. [BZ #21741] * sysdeps/x86_64/multiarch/ifunc-impl-list.c (__libc_ifunc_impl_list): Test memmove_chk and memset_chk only in libc.so.
2017-07-09Update hppa ulps.John David Anglin
2017-07-09Use generic pthread support on hppa.John David Anglin
2017-07-09x86-64: Update comments in IFUNC selectorsH.J. Lu
* sysdeps/x86_64/multiarch/memcmp.c: Update comments. * sysdeps/x86_64/multiarch/memmove.c: Likewise. * sysdeps/x86_64/multiarch/memrchr.c: Likewise. * sysdeps/x86_64/multiarch/memset.c: Likewise. * sysdeps/x86_64/multiarch/rawmemchr.c: Likewise. * sysdeps/x86_64/multiarch/strchrnul.c: Likewise. * sysdeps/x86_64/multiarch/strlen.c: Likewise. * sysdeps/x86_64/multiarch/strnlen.c: Likewise. * sysdeps/x86_64/multiarch/wcschr.c: Likewise. * sysdeps/x86_64/multiarch/wcscpy.c: Likewise. * sysdeps/x86_64/multiarch/wcslen.c: Likewise. * sysdeps/x86_64/multiarch/wcsnlen.c: Likewise. * sysdeps/x86_64/multiarch/wmemchr.c: Likewise. * sysdeps/x86_64/multiarch/wmemcmp.c: Likewise. * sysdeps/x86_64/multiarch/wmemset.c: Likewise. * sysdeps/x86_64/multiarch/wmemset_chk.c: Likewise.
2017-07-09x86-64: Update comments in ifunc-impl-list.cH.J. Lu
All x86-64 IFUNC selectors are written in C now. Update comments to reflect it. * sysdeps/x86_64/multiarch/ifunc-impl-list.c: Update comments.
2017-07-09Fix BZ #21049.John David Anglin
2017-07-06nptl: Fix typo on __have_pthread_attr_t (BZ#21715)Matthew Krupcale
This patch fixes some build issues when including types/sigevent_t.h along with bits/pthreadtypes.h. Checked on x86_64-linux-gnu and on a build on supported major ABIs. [BZ #21715] * sysdeps/nptl/bits/pthreadtypes.h (__have_pthread_attr_t): Fix typo on definition.
2017-07-06x86-64: Align the stack in __tls_get_addr [BZ #21609]H.J. Lu
This change forces realignment of the stack pointer in __tls_get_addr, so that binaries compiled by GCCs older than GCC 4.9: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58066 continue to work even if vector instructions are used in glibc which require the ABI stack realignment. __tls_get_addr_slow is added to handle the slow paths in the default implementation of__tls_get_addr in elf/dl-tls.c. The new __tls_get_addr calls __tls_get_addr_slow after realigning the stack. Internal calls within ld.so go directly to the default implementation of __tls_get_addr because they do not need stack realignment. [BZ #21609] * sysdeps/x86_64/Makefile (sysdep-dl-routines): Add tls_get_addr. (gen-as-const-headers): Add rtld-offsets.sym. * sysdeps/x86_64/dl-tls.c: New file. * sysdeps/x86_64/rtld-offsets.sym: Likwise. * sysdeps/x86_64/tls_get_addr.S: Likewise. * sysdeps/x86_64/dl-tls.h: Add multiple inclusion guards. * sysdeps/x86_64/tlsdesc.sym (TI_MODULE_OFFSET): New. (TI_OFFSET_OFFSET): Likwise.
2017-07-05posix: Fix default posix_spawn return valueAdhemerval Zanella
This patch fix the return value for error conditions for default posix_spawn (where the errno is expected). It also avoid clobber errno on fork call. Checked on x86_64 (with Linux implementation removed). [BZ# 21697] * sysdeps/posix/spawni.c (__spawni_child): Fix return value. (__spawnix): Do not clober errno.
2017-07-04Single threaded stdio optimizationSzabolcs Nagy
Locking overhead can be significant in some stdio operations that are common in single threaded applications. This patch adds the _IO_FLAGS2_NEED_LOCK flag to indicate if an _IO_FILE object needs to be locked and some of the stdio functions just jump to their _unlocked variant when not. The flag is set on all _IO_FILE objects when the first thread is created. A new GLIBC_PRIVATE libc symbol, _IO_enable_locks, was added to do this from libpthread. The optimization can be applied to more stdio functions, currently it is only applied to single flag check or single non-wide-char standard operations. The flag should probably be never set for files with _IO_USER_LOCK, but that's just a further optimization, not a correctness requirement. The optimization is valid in a single thread because stdio operations are non-as-safe (so lock state is not observable from a signal handler) and stdio locks are recursive (so lock state is not observable via deadlock). The optimization is not valid if a thread may be created while an stdio lock is taken and thus it should be disabled if any user code may run during an stdio operation (interposed malloc, printf hooks, etc). This makes the optimization more complicated for some stdio operations (e.g. printf), but those are bigger and thus less important to optimize so this patch does not try to do that. * libio/libio.h (_IO_FLAGS2_NEED_LOCK, _IO_need_lock): Define. * libio/libioP.h (_IO_enable_locks): Declare. * libio/Versions (_IO_enable_locks): New symbol. * libio/genops.c (_IO_enable_locks): Define. (_IO_old_init): Initialize flags2. * libio/feof.c.c (_IO_feof): Avoid locking when not needed. * libio/ferror.c (_IO_ferror): Likewise. * libio/fputc.c (fputc): Likewise. * libio/putc.c (_IO_putc): Likewise. * libio/getc.c (_IO_getc): Likewise. * libio/getchar.c (getchar): Likewise. * libio/ioungetc.c (_IO_ungetc): Likewise. * nptl/pthread_create.c (__pthread_create_2_1): Enable stdio locks. * libio/iofopncook.c (_IO_fopencookie): Enable locking for the file. * sysdeps/pthread/flockfile.c (__flockfile): Likewise.
generated by cgit v1.2.3-70-g09d2 (git 2.50.0) at 2025-08-05 01:40:34 +0000