aboutsummaryrefslogtreecommitdiff
path: root/stdlib/setenv.c
AgeCommit message (Collapse)Author
2015-01-07setenv fix memory leak when setting large, duplicate string (BZ #17658)Eric Biggers
glibc maintains a binary tree of environment strings it malloc()ed itself. However, it's possible for it to malloc() a string, then find that an identical string is already in the tree. In this case, the memory is leaked and is not freed if the application later calls __libc_freeres(). Fix this by freeing 'new_value' when it's unneeded. Test case: #include <stdlib.h> #include <string.h> int main() { char *p = calloc(100000, 1); memset(p, 'A', 99999); setenv("TESTVAR", p, 1); setenv("TESTVAR", p, 1); free(p); } Leak that was reported by valgrind: 100,008 bytes in 1 blocks are definitely lost in loss record 1 of 1 at 0x4C29F90: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4E6B3D4: __add_to_environ (setenv.c:176) by 0x4C31B8F: setenv (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x400642: main (in /mnt/tmpfs/a.out)
2015-01-02Update copyright dates with scripts/update-copyrights.Joseph Myers
2014-02-11Remove unused variable from stdlib/setenv.cOndřej Bílka
2014-02-10Use glibc_likely instead __builtin_expect.Ondřej Bílka
2014-02-10Fix previous commit.Ondřej Bílka
2014-02-10Deduplicate setenv.Ondřej Bílka
Setenv contained a code path that was redundant as it could be handled in general case.
2014-01-01Update copyright notices with scripts/update-copyrightsAllan McRae
2013-06-08Use (void) in no-arguments function definitions.Joseph Myers
2013-06-07Avoid use of "register" as optimization hint.Joseph Myers
2013-01-02Update copyright notices with scripts/update-copyrights.Joseph Myers
2012-02-09Replace FSF snail mail address with URLs.Paul Eggert
2010-02-02Avoid alloca in setenv for long strings.Ulrich Drepper
2008-12-02* stdlib/setenv.c (unsetenv): Don't search environment if it doesUlrich Drepper
not exist.
2005-12-14Moved to csu/errno-loc.c.Ulrich Drepper
2004-12-22(CFLAGS-tst-align.c): Add -mpreferred-stack-boundary=4.Ulrich Drepper
2007-07-122.5-18.1Jakub Jelinek