| Age | Commit message (Collapse) | Author |
|---|
|
I used these shell commands:
../glibc/scripts/update-copyrights $PWD/../gnulib/build-aux/update-copyright
(cd ../glibc && git commit -am"[this commit message]")
and then ignored the output, which consisted lines saying "FOO: warning:
copyright statement not found" for each of 7061 files FOO.
I then removed trailing white space from math/tgmath.h,
support/tst-support-open-dev-null-range.c, and
sysdeps/x86_64/multiarch/strlen-vec.S, to work around the following
obscure pre-commit check failure diagnostics from Savannah. I don't
know why I run into these diagnostics whereas others evidently do not.
remote: *** 912-#endif
remote: *** 913:
remote: *** 914-
remote: *** error: lines with trailing whitespace found
...
remote: *** error: sysdeps/unix/sysv/linux/statx_cp.c: trailing lines
|
|
I used these shell commands:
../glibc/scripts/update-copyrights $PWD/../gnulib/build-aux/update-copyright
(cd ../glibc && git commit -am"[this commit message]")
and then ignored the output, which consisted lines saying "FOO: warning:
copyright statement not found" for each of 6694 files FOO.
I then removed trailing white space from benchtests/bench-pthread-locks.c
and iconvdata/tst-iconv-big5-hkscs-to-2ucs4.c, to work around this
diagnostic from Savannah:
remote: *** pre-commit check failed ...
remote: *** error: lines with trailing whitespace found
remote: error: hook declined to update refs/heads/master
|
|
|
|
This patch replaces the fork+exec by posix_spawn on wordexp, which
allows a better scability on Linux and simplifies the thread
cancellation handling.
The only change which can not be implemented with posix_spawn the
/dev/null check to certify it is indeed the expected device. I am
not sure how effetive this check is since /dev/null tampering means
something very wrong with the system and this is the least of the
issues. My view is the tests is really out of the place and the
hardening provided is minimum.
If the idea is still to provide such check, I think a possibilty
would be to open /dev/null, check it, add a dup2 file action, and
close the file descriptor.
Checked on powerpc64le-linux-gnu and x86_64-linux-gnu.
* include/spawn.h (__posix_spawn_file_actions_addopen): New
prototype.
* posix/spawn_faction_addopen.c (posix_spawn_file_actions_addopen):
Add internal alias.
* posix/wordexp.c (create_environment, free_environment): New
functions.
(exec_comm_child, exec_comm): Use posix_spawn instead of fork+exec.
* posix/wordexp-test.c: Use libsupport.
|
|
Also, change sources.redhat.com to sourceware.org.
This patch was automatically generated by running the following shell
script, which uses GNU sed, and which avoids modifying files imported
from upstream:
sed -ri '
s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g
s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g
' \
$(find $(git ls-files) -prune -type f \
! -name '*.po' \
! -name 'ChangeLog*' \
! -path COPYING ! -path COPYING.LIB \
! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \
! -path manual/texinfo.tex ! -path scripts/config.guess \
! -path scripts/config.sub ! -path scripts/install-sh \
! -path scripts/mkinstalldirs ! -path scripts/move-if-change \
! -path INSTALL ! -path locale/programs/charmap-kw.h \
! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \
! '(' -name configure \
-execdir test -f configure.ac -o -f configure.in ';' ')' \
! '(' -name preconfigure \
-execdir test -f preconfigure.ac ';' ')' \
-print)
and then by running 'make dist-prepare' to regenerate files built
from the altered files, and then executing the following to cleanup:
chmod a+x sysdeps/unix/sysv/linux/riscv/configure
# Omit irrelevant whitespace and comment-only changes,
# perhaps from a slightly-different Autoconf version.
git checkout -f \
sysdeps/csky/configure \
sysdeps/hppa/configure \
sysdeps/riscv/configure \
sysdeps/unix/sysv/linux/csky/configure
# Omit changes that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines
git checkout -f \
sysdeps/powerpc/powerpc64/ppc-mcount.S \
sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
# Omit change that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline
git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
|
|
* All files with FSF copyright notices: Update copyright dates
using scripts/update-copyrights.
* locale/programs/charmap-kw.h: Regenerated.
* locale/programs/locfile-kw.h: Likewise.
|
|
* All files with FSF copyright notices: Update copyright dates
using scripts/update-copyrights.
* locale/programs/charmap-kw.h: Regenerated.
* locale/programs/locfile-kw.h: Likewise.
|
|
calls with constant strings shows a small (~10%) performance gain, strdup is
typically used in error reporting code, so not performance critical.
Remove the now unused __need_malloc_and_calloc related defines from stdlib.h.
Rename existing uses of str(n)dup to __str(n)dup so it no longer needs to be
redirected to a builtin. Also building GLIBC with -Os now no longer shows
localplt or linkname space failures (partial fix for BZ #15105 and BZ #19463).
[BZ #15105]
[BZ #19463]
* elf/dl-cache.c (_dl_load_cache_lookup): Use __strdup.
* inet/rcmd.c (rcmd_af): Likewise.
* inet/rexec.c (rexec_af): Likewise.
* intl/dcigettext.c (_LIBC): Likewise.
* intl/finddomain.c (_nl_find_domain): Use strdup expansion.
* locale/loadarchive.c (_nl_load_locale_from_archive): Use __strdup.
* locale/setlocale.c (setlocale): Likewise.
* posix/spawn_faction_addopen.c
(posix_spawn_file_actions_addopen): Likewise.
* stdlib/putenv.c (putenv): Use __strndup.
* sunrpc/svc_simple.c (__registerrpc): Use __strdup.
* sysdeps/posix/getaddrinfo.c (gaih_inet): Use __strdup/__strndup.
* include/stdlib.h (__need_malloc_and_calloc): Remove uses.
(__Need_M_And_C) Remove define/undef.
* stdlib/stdlib.h (__need_malloc_and_calloc): Remove uses.
(__malloc_and_calloc_defined): Remove define.
* string/bits/string2.h (__strdup): Remove define.
(strdup): Likewise.
(__strndup): Likewise.
(strndup): Likewise.
|
|
|
|
|
|
|
|
|
|
|
|
This is needed to avoid a PLT call on s390.
|
|
POSIX requires that we make a copy, so we allocate a new string
and free it in posix_spawn_file_actions_destroy.
Reported by David Reid, Alex Gaynor, and Glyph Lefkowitz. This bug
may have security implications.
|
|
|
|
|
|
|
|
2001-07-06 Paul Eggert <eggert@twinsun.com>
* manual/argp.texi: Remove ignored LGPL copyright notice; it's
not appropriate for documentation anyway.
* manual/libc-texinfo.sh: "Library General Public License" ->
"Lesser General Public License".
2001-07-06 Andreas Jaeger <aj@suse.de>
* All files under GPL/LGPL version 2: Place under LGPL version
2.1.
|
|
* Makefile (repertoiremaps): Remove variable.
(distribute): Remove repertoiremaps.
(install-others): Likewise. Add .gz to charmaps.
($(inst_i18ndir)/charmaps/%): Install in gzipped format.
2000-09-30 Bruno Haible <haible@clisp.cons.org>
|
|
* argp/argp-help.c: Unify use of function aliases to make more compact
PLT.
* include/libintl.h: Likewise.
* inet/rcmd.c: Likewise.
* intl/dcigettext.c: Likewise.
* libio/iofputws.c: Likewise.
* libio/iofputws_u.c: Likewise.
* libio/iogetwline.c: Likewise.
* libio/swprintf.c: Likewise.
* malloc/malloc.c: Likewise.
* nss/digits_dots.c: Likewise.
* posix/fnmatch.c: Likewise.
* posix/spawn_faction_addclose.c: Likewise.
* posix/spawn_faction_adddup2.c: Likewise.
* posix/spawn_faction_addopen.c: Likewise.
* posix/spawni.c: Likewise.
* posix/wordexp.c: Likewise.
* posix/spawni.c: Likewise.
* resolv/res_hconf.c: Likewise.
* resolv/res_init.c: Likewise.
* shadow/lckpwdf.c: Likewise.
* signal/sighold.c: Likewise.
* signal/sigrelse.c: Likewise.
* stdio-common/printf-parse.h: Likewise.
* stdio-common/printf-prs.c: Likewise.
* stdio-common/printf_fp.c: Likewise.
* stdio-common/vfprintf.c: Likewise.
* stdio-common/vfscanf.c: Likewise.
* stdlib/rpmatch.c: Likewise.
* sunrpc/create_xid.c: Likewise.
* sunrpc/key_call.c: Likewise.
* sysdeps/generic/setrlimit64.c: Likewise.
* sysdeps/generic/utmp_file.c: Likewise.
* sysdeps/generic/vlimit.c: Likewise.
* sysdeps/posix/posix_fallocate.c: Likewise.
* sysdeps/posix/posix_fallocate64.c: Likewise.
* sysdeps/posix/sigpause.c: Likewise.
* sysdeps/posix/sigset.c: Likewise.
* sysdeps/unix/grantpt.c: Likewise.
* sysdeps/unix/bsd/ualarm.c: Likewise.
* sysdeps/unix/sysv/linux/dl-origin.c: Likewise.
* sysdeps/unix/sysv/linux/getloadavg.c: Likewise.
* sysdeps/unix/sysv/linux/ttyname.c: Likewise.
* sysdeps/unix/sysv/linux/ulimit.c: Likewise.
* time/strftime.c: Likewise.
* wcsmbs/wcscoll.c: Likewise.
* wcsmbs/wcsxfrm.c: Likewise.
* sysdeps/powerpc/fpu_control.h (_FPU_GETCW): Allow gcc to generate
postinc/predec instruction.
|
|
2000-05-29 Ulrich Drepper <drepper@redhat.com>
* posix/Makefile (tests): Add tst-spawn.
(tst-spawn-ARGS): New variable.
* posix/tst-spawn.c: New file.
* posix/spawn_faction_addclose.c: Correctly account for new entry.
* posix/spawn_faction_adddup2.c: Likewise.
* posix/spawn_faction_addopen.c: Likewise.
* posix/spawni.c: Correctly test for success of dup2 calls.
* posix/tst-preadwrite.c: Check success of malloc call.
|
|
2000-04-15 Ulrich Drepper <drepper@redhat.com>
* posix/Makefile (headers): Add spawn.h.
(distribute): Add spawn_int.h.
(routines): Add spawn_faction_init, spawn_faction_destroy,
spawn_faction_addclose, spawn_faction_addopen, spawn_faction_adddup2,
spawnattr_init, spawnattr_destroy, spawnattr_getdefault,
spawnattr_setdefault, spawnattr_getflags, spawnattr_setflags,
spawnattr_getpgroup, spawnattr_setpgroup, spawn, spawnp, and spawni.
* posix/Versions [libc] (GLIBC_2.2): Add posix_spawn_file_actions_init,
posix_spawn_file_actions_destroy, posix_spawn_file_actions_addclose,
posix_spawn_file_actions_addopen, posix_spawn_file_actions_adddup2,
posix_spawnattr_init, posix_spawnattr_destroy,
posix_spawnattr_getdefault, posix_spawnattr_setdefault,
posix_spawnattr_getflags, posix_spawnattr_setflags,
posix_spawnattr_getpgroup, posix_spawnattr_setpgroup, posix_spawn,
and posix_spawnp.
* posix/spawn.c: New file.
* posix/spawn.h: New file.
* posix/spawn_faction_addclose.c: New file.
* posix/spawn_faction_adddup2.c: New file.
* posix/spawn_faction_addopen.c: New file.
* posix/spawn_faction_destroy.c: New file.
* posix/spawn_faction_init.c: New file.
* posix/spawn_int.h: New file.
* posix/spawnattr_destroy.c: New file.
* posix/spawnattr_getdefault.c: New file.
* posix/spawnattr_getflags.c: New file.
* posix/spawnattr_getpgroup.c: New file.
* posix/spawnattr_getschedparam.c: New file.
* posix/spawnattr_getschedpolicy.c: New file.
* posix/spawnattr_getsigmask.c: New file.
* posix/spawnattr_init.c: New file.
* posix/spawnattr_setdefault.c: New file.
* posix/spawnattr_setflags.c: New file.
* posix/spawnattr_setpgroup.c: New file.
* posix/spawnattr_setschedparam.c: New file.
* posix/spawnattr_setschedpolicy.c: New file.
* posix/spawnattr_setsigmask.c: New file.
* posix/spawni.c: New file.
* posix/spawnp.c: New file.
* sysdeps/mach/hurd/bits/posix_opt.h: Add _POSIX_SPAWN.
* sysdeps/unix/sysv/linux/bits/posix_opt.h: Likewise.
|
