aboutsummaryrefslogtreecommitdiff
path: root/nptl/pthread_kill.c
diff options
context:
space:
mode:
Diffstat (limited to 'nptl/pthread_kill.c')
-rw-r--r--nptl/pthread_kill.c26
1 files changed, 17 insertions, 9 deletions
diff --git a/nptl/pthread_kill.c b/nptl/pthread_kill.c
index f1fa2d303f..84b40478aa 100644
--- a/nptl/pthread_kill.c
+++ b/nptl/pthread_kill.c
@@ -16,23 +16,31 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
-#include <errno.h>
-#include <signal.h>
+#include <unistd.h>
#include <pthreadP.h>
-
int
__pthread_kill (pthread_t threadid, int signo)
{
+ /* Disallow sending the signal we use for cancellation, timers,
+ for the setxid implementation. */
+ if (__is_internal_signal (signo))
+ return EINVAL;
+
+ /* Force load of pd->tid into local variable or register. Otherwise
+ if a thread exits between ESRCH test and tgkill, we might return
+ EINVAL, because pd->tid would be cleared by the kernel. */
struct pthread *pd = (struct pthread *) threadid;
-
- /* Make sure the descriptor is valid. */
- if (DEBUGGING_P && INVALID_TD_P (pd))
+ pid_t tid = atomic_forced_read (pd->tid);
+ if (__glibc_unlikely (tid <= 0))
/* Not a valid thread handle. */
return ESRCH;
- return ENOSYS;
+ /* We have a special syscall to do the work. */
+ pid_t pid = __getpid ();
+
+ int val = INTERNAL_SYSCALL_CALL (tgkill, pid, tid, signo);
+ return (INTERNAL_SYSCALL_ERROR_P (val)
+ ? INTERNAL_SYSCALL_ERRNO (val) : 0);
}
strong_alias (__pthread_kill, pthread_kill)
-
-stub_warning (pthread_kill)