diff options
-rw-r--r-- | nptl/pthreadP.h | 3 | ||||
-rw-r--r-- | nptl/pthread_mutex_init.c | 13 | ||||
-rw-r--r-- | sysdeps/aarch64/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/alpha/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/arm/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/csky/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/hppa/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/i386/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/ia64/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/m68k/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/microblaze/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/mips/nptl/pthread-offsets.h | 8 | ||||
-rw-r--r-- | sysdeps/nios2/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/powerpc/nptl/pthread-offsets.h | 8 | ||||
-rw-r--r-- | sysdeps/riscv/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/s390/nptl/pthread-offsets.h | 8 | ||||
-rw-r--r-- | sysdeps/sh/nptl/pthread-offsets.h | 4 | ||||
-rw-r--r-- | sysdeps/sparc/nptl/pthread-offsets.h | 8 | ||||
-rw-r--r-- | sysdeps/x86_64/nptl/pthread-offsets.h | 4 |
19 files changed, 6 insertions, 94 deletions
diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h index bbb2bf0222..9c200673a0 100644 --- a/nptl/pthreadP.h +++ b/nptl/pthreadP.h @@ -617,5 +617,8 @@ check_stacksize_attr (size_t st) _Static_assert (offsetof (type, member) == offset, \ "offset of " #member " field of " #type " != " \ ASSERT_PTHREAD_STRING (offset)) +#define ASSERT_PTHREAD_INTERNAL_MEMBER_SIZE(type, member, mtype) \ + _Static_assert (sizeof (((type) { 0 }).member) != 8, \ + "sizeof (" #type "." #member ") != sizeof (" #mtype "))") #endif /* pthreadP.h */ diff --git a/nptl/pthread_mutex_init.c b/nptl/pthread_mutex_init.c index 20800b80f5..daef8b4bcc 100644 --- a/nptl/pthread_mutex_init.c +++ b/nptl/pthread_mutex_init.c @@ -55,18 +55,11 @@ __pthread_mutex_init (pthread_mutex_t *mutex, ASSERT_TYPE_SIZE (pthread_mutex_t, __SIZEOF_PTHREAD_MUTEX_T); - ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__nusers, - __PTHREAD_MUTEX_NUSERS_OFFSET); + /* __kind is the only field where its offset should be checked to + avoid ABI breakage with static initializers. */ ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__kind, __PTHREAD_MUTEX_KIND_OFFSET); - ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__spins, - __PTHREAD_MUTEX_SPINS_OFFSET); -#if __PTHREAD_MUTEX_LOCK_ELISION - ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__elision, - __PTHREAD_MUTEX_ELISION_OFFSET); -#endif - ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_mutex_t, __data.__list, - __PTHREAD_MUTEX_LIST_OFFSET); + ASSERT_PTHREAD_INTERNAL_MEMBER_SIZE (pthread_mutex_t, __data.__kind, int); imutexattr = ((const struct pthread_mutexattr *) mutexattr ?: &default_mutexattr); diff --git a/sysdeps/aarch64/nptl/pthread-offsets.h b/sysdeps/aarch64/nptl/pthread-offsets.h index 16c6b0d9fd..8208f6f177 100644 --- a/sysdeps/aarch64/nptl/pthread-offsets.h +++ b/sysdeps/aarch64/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 12 #define __PTHREAD_MUTEX_KIND_OFFSET 16 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 24 diff --git a/sysdeps/alpha/nptl/pthread-offsets.h b/sysdeps/alpha/nptl/pthread-offsets.h index 16c6b0d9fd..8208f6f177 100644 --- a/sysdeps/alpha/nptl/pthread-offsets.h +++ b/sysdeps/alpha/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 12 #define __PTHREAD_MUTEX_KIND_OFFSET 16 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 24 diff --git a/sysdeps/arm/nptl/pthread-offsets.h b/sysdeps/arm/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/arm/nptl/pthread-offsets.h +++ b/sysdeps/arm/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/csky/nptl/pthread-offsets.h b/sysdeps/csky/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/csky/nptl/pthread-offsets.h +++ b/sysdeps/csky/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/hppa/nptl/pthread-offsets.h b/sysdeps/hppa/nptl/pthread-offsets.h index 8ae01b9d95..e4e775d7ed 100644 --- a/sysdeps/hppa/nptl/pthread-offsets.h +++ b/sysdeps/hppa/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 32 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 36 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 36 diff --git a/sysdeps/i386/nptl/pthread-offsets.h b/sysdeps/i386/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/i386/nptl/pthread-offsets.h +++ b/sysdeps/i386/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/ia64/nptl/pthread-offsets.h b/sysdeps/ia64/nptl/pthread-offsets.h index 16c6b0d9fd..8208f6f177 100644 --- a/sysdeps/ia64/nptl/pthread-offsets.h +++ b/sysdeps/ia64/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 12 #define __PTHREAD_MUTEX_KIND_OFFSET 16 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 24 diff --git a/sysdeps/m68k/nptl/pthread-offsets.h b/sysdeps/m68k/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/m68k/nptl/pthread-offsets.h +++ b/sysdeps/m68k/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/microblaze/nptl/pthread-offsets.h b/sysdeps/microblaze/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/microblaze/nptl/pthread-offsets.h +++ b/sysdeps/microblaze/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/mips/nptl/pthread-offsets.h b/sysdeps/mips/nptl/pthread-offsets.h index 0ac3eda3fb..e96d34afd7 100644 --- a/sysdeps/mips/nptl/pthread-offsets.h +++ b/sysdeps/mips/nptl/pthread-offsets.h @@ -1,13 +1,5 @@ #if _MIPS_SIM == _ABI64 -# define __PTHREAD_MUTEX_NUSERS_OFFSET 12 # define __PTHREAD_MUTEX_KIND_OFFSET 16 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 24 #else -# define __PTHREAD_MUTEX_NUSERS_OFFSET 16 # define __PTHREAD_MUTEX_KIND_OFFSET 12 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 20 #endif diff --git a/sysdeps/nios2/nptl/pthread-offsets.h b/sysdeps/nios2/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/nios2/nptl/pthread-offsets.h +++ b/sysdeps/nios2/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/powerpc/nptl/pthread-offsets.h b/sysdeps/powerpc/nptl/pthread-offsets.h index bdda1f197e..25b5bf2cbd 100644 --- a/sysdeps/powerpc/nptl/pthread-offsets.h +++ b/sysdeps/powerpc/nptl/pthread-offsets.h @@ -1,15 +1,7 @@ #include <bits/wordsize.h> #if __WORDSIZE == 64 -# define __PTHREAD_MUTEX_NUSERS_OFFSET 12 # define __PTHREAD_MUTEX_KIND_OFFSET 16 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 24 #else -# define __PTHREAD_MUTEX_NUSERS_OFFSET 16 # define __PTHREAD_MUTEX_KIND_OFFSET 12 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 20 #endif diff --git a/sysdeps/riscv/nptl/pthread-offsets.h b/sysdeps/riscv/nptl/pthread-offsets.h index f1640047a0..6fc032fdc2 100644 --- a/sysdeps/riscv/nptl/pthread-offsets.h +++ b/sysdeps/riscv/nptl/pthread-offsets.h @@ -17,8 +17,4 @@ License along with the GNU C Library. If not, see <https://www.gnu.org/licenses/>. */ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 12 #define __PTHREAD_MUTEX_KIND_OFFSET 16 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 24 diff --git a/sysdeps/s390/nptl/pthread-offsets.h b/sysdeps/s390/nptl/pthread-offsets.h index bdda1f197e..25b5bf2cbd 100644 --- a/sysdeps/s390/nptl/pthread-offsets.h +++ b/sysdeps/s390/nptl/pthread-offsets.h @@ -1,15 +1,7 @@ #include <bits/wordsize.h> #if __WORDSIZE == 64 -# define __PTHREAD_MUTEX_NUSERS_OFFSET 12 # define __PTHREAD_MUTEX_KIND_OFFSET 16 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 24 #else -# define __PTHREAD_MUTEX_NUSERS_OFFSET 16 # define __PTHREAD_MUTEX_KIND_OFFSET 12 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 20 #endif diff --git a/sysdeps/sh/nptl/pthread-offsets.h b/sysdeps/sh/nptl/pthread-offsets.h index 9617354dc7..e4e775d7ed 100644 --- a/sysdeps/sh/nptl/pthread-offsets.h +++ b/sysdeps/sh/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 16 #define __PTHREAD_MUTEX_KIND_OFFSET 12 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 20 diff --git a/sysdeps/sparc/nptl/pthread-offsets.h b/sysdeps/sparc/nptl/pthread-offsets.h index bdda1f197e..25b5bf2cbd 100644 --- a/sysdeps/sparc/nptl/pthread-offsets.h +++ b/sysdeps/sparc/nptl/pthread-offsets.h @@ -1,15 +1,7 @@ #include <bits/wordsize.h> #if __WORDSIZE == 64 -# define __PTHREAD_MUTEX_NUSERS_OFFSET 12 # define __PTHREAD_MUTEX_KIND_OFFSET 16 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 24 #else -# define __PTHREAD_MUTEX_NUSERS_OFFSET 16 # define __PTHREAD_MUTEX_KIND_OFFSET 12 -# define __PTHREAD_MUTEX_SPINS_OFFSET 20 -# define __PTHREAD_MUTEX_ELISION_OFFSET 22 -# define __PTHREAD_MUTEX_LIST_OFFSET 20 #endif diff --git a/sysdeps/x86_64/nptl/pthread-offsets.h b/sysdeps/x86_64/nptl/pthread-offsets.h index 16c6b0d9fd..8208f6f177 100644 --- a/sysdeps/x86_64/nptl/pthread-offsets.h +++ b/sysdeps/x86_64/nptl/pthread-offsets.h @@ -1,5 +1 @@ -#define __PTHREAD_MUTEX_NUSERS_OFFSET 12 #define __PTHREAD_MUTEX_KIND_OFFSET 16 -#define __PTHREAD_MUTEX_SPINS_OFFSET 20 -#define __PTHREAD_MUTEX_ELISION_OFFSET 22 -#define __PTHREAD_MUTEX_LIST_OFFSET 24 |