aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog5
-rw-r--r--login/login.c7
-rw-r--r--stdlib/Versions5
3 files changed, 15 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 94ae6c48c4..bd44bd1226 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2002-02-28 Ulrich Drepper <drepper@redhat.com>
+
+ * login/login.c (login): Always initialize ut_line field
+ [PR libc/2991].
+
2002-02-28 Jakub Jelinek <jakub@redhat.com>
* sysdeps/i386/Makefile (sysdep_routines): Add
diff --git a/login/login.c b/login/login.c
index a7a3ff5afa..6efa7627f4 100644
--- a/login/login.c
+++ b/login/login.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 1996, 1997, 1998 Free Software Foundation, Inc.
+/* Copyright (C) 1996, 1997, 1998, 2002 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1996.
@@ -17,6 +17,7 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */
+#include <assert.h>
#include <errno.h>
#include <limits.h>
#include <string.h>
@@ -133,6 +134,10 @@ login (const struct utmp *ut)
if (tty != _tty)
free (tty); /* Free buffer malloced by tty_name. */
}
+ else
+ /* We provide a default value so that the output does not contain
+ an random bytes in this field. */
+ strncpy (copy.ut_line, "???", UT_LINESIZE);
/* Update the WTMP file. Here we have to add a new entry. */
updwtmp (_PATH_WTMP, &copy);
diff --git a/stdlib/Versions b/stdlib/Versions
index 274013f0ed..c2e17e0096 100644
--- a/stdlib/Versions
+++ b/stdlib/Versions
@@ -93,6 +93,9 @@ libc {
GLIBC_PRIVATE {
# functions which have an additional interface since they are
# are cancelable.
- __libc_system; __on_exit;
+ __libc_system;
+
+ # functions used in other libraries.
+ __on_exit;
}
}