diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2019-02-26 02:09:18 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2019-02-26 02:09:18 +0000 |
| commit | e0cb7b6131ee5f2dca2938069b8b9590304e6f6b (patch) | |
| tree | cd451044e2bbc120225db29347b134ff1f3bbe30 /sysdeps/m68k | |
| parent | a04549c19407a29a271779598a9518f9baf959e0 (diff) | |
| download | glibc-e0cb7b6131ee5f2dca2938069b8b9590304e6f6b.tar glibc-e0cb7b6131ee5f2dca2938069b8b9590304e6f6b.tar.gz glibc-e0cb7b6131ee5f2dca2938069b8b9590304e6f6b.tar.bz2 glibc-e0cb7b6131ee5f2dca2938069b8b9590304e6f6b.zip | |
Add and move fall-through comments in system-specific code.
This patch fixes -Wimplicit-fallthrough warnings in system-specific
code that show up building glibc with -Wextra, by adding fall-through
comments, or moving existing such comments to the place required for
them to work (immediately before the case label being fallen through).
Tested with build-many-glibcs.py.
* sysdeps/i386/dl-machine.h (elf_machine_rela): Add fall-through
comments.
* sysdeps/m68k/m680x0/fpu/s_cexp_template.c (s(__cexp)): Likewise.
* sysdeps/m68k/memcopy.h (WORD_COPY_FWD): Likewise.
(WORD_COPY_BWD): Likewise.
* sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise.
* sysdeps/powerpc/powerpc64/dl-machine.h (elf_machine_rela):
Likewise.
* sysdeps/s390/iso-8859-1_cp037_z900.c (TR_LOOP): Likewise.
* sysdeps/mips/dl-machine.h (elf_machine_reloc): Move fall-through
comment.
* sysdeps/mips/dl-trampoline.c (__dl_runtime_resolve): Likewise.
Diffstat (limited to 'sysdeps/m68k')
| -rw-r--r-- | sysdeps/m68k/m680x0/fpu/s_cexp_template.c | 1 | ||||
| -rw-r--r-- | sysdeps/m68k/memcopy.h | 16 |
2 files changed, 17 insertions, 0 deletions
diff --git a/sysdeps/m68k/m680x0/fpu/s_cexp_template.c b/sysdeps/m68k/m680x0/fpu/s_cexp_template.c index d214f5925b..13befb2d29 100644 --- a/sysdeps/m68k/m680x0/fpu/s_cexp_template.c +++ b/sysdeps/m68k/m680x0/fpu/s_cexp_template.c @@ -93,6 +93,7 @@ s(__cexp) (CFLOAT x) break; case 2: __real__ retval = -__real__ retval; + /* Fall through. */ case 3: __imag__ retval = -__imag__ retval; break; diff --git a/sysdeps/m68k/memcopy.h b/sysdeps/m68k/memcopy.h index 66c39649da..aa4a1ab651 100644 --- a/sysdeps/m68k/memcopy.h +++ b/sysdeps/m68k/memcopy.h @@ -39,20 +39,28 @@ do \ { \ ((op_t *) dst_bp)[0] = ((op_t *) src_bp)[0]; \ + /* Fall through. */ \ case 7: \ ((op_t *) dst_bp)[1] = ((op_t *) src_bp)[1]; \ + /* Fall through. */ \ case 6: \ ((op_t *) dst_bp)[2] = ((op_t *) src_bp)[2]; \ + /* Fall through. */ \ case 5: \ ((op_t *) dst_bp)[3] = ((op_t *) src_bp)[3]; \ + /* Fall through. */ \ case 4: \ ((op_t *) dst_bp)[4] = ((op_t *) src_bp)[4]; \ + /* Fall through. */ \ case 3: \ ((op_t *) dst_bp)[5] = ((op_t *) src_bp)[5]; \ + /* Fall through. */ \ case 2: \ ((op_t *) dst_bp)[6] = ((op_t *) src_bp)[6]; \ + /* Fall through. */ \ case 1: \ ((op_t *) dst_bp)[7] = ((op_t *) src_bp)[7]; \ + /* Fall through. */ \ case 0: \ src_bp += 32; \ dst_bp += 32; \ @@ -73,20 +81,28 @@ do \ { \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 7: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 6: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 5: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 4: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 3: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 2: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 1: \ *--__dst_ep = *--__src_ep; \ + /* Fall through. */ \ case 0: \ __nblocks--; \ } \ |