diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2017-10-22 08:01:38 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2017-10-22 08:02:58 -0700 |
commit | fe596486d694e657413d0d4c5a04598674ff71b1 (patch) | |
tree | baa82d03de8d66e51415ff7e0489ef7401126195 /sysdeps/i386/i686 | |
parent | 7eda65f69e0e4533b76ca4614fe516de03fe2b3a (diff) | |
download | glibc-fe596486d694e657413d0d4c5a04598674ff71b1.tar glibc-fe596486d694e657413d0d4c5a04598674ff71b1.tar.gz glibc-fe596486d694e657413d0d4c5a04598674ff71b1.tar.bz2 glibc-fe596486d694e657413d0d4c5a04598674ff71b1.zip |
i386: Replace assembly versions of e_logf with generic e_logf.c
This patch replaces i386 assembly versions of e_logf with generic
e_logf.c. For workload-spec2017.wrf, on Nehalem, it improves
performance by:
Before After Improvement
reciprocal-throughput 73.3865 40.0454 83%
latency 90.0985 54.4479 65%
On Skylake, it improves performance by:
Before After Improvement
reciprocal-throughput 75.1384 22.1452 239%
latency 91.9441 50.7925 81%
On IvyBridge with --disable-multi-arch, it improves performance by:
Before After Improvement
reciprocal-throughput 84.5575 28.7879 193%
latency 103.971 57.5231 80%
* sysdeps/i386/fpu/e_logf.S: Removed.
* sysdeps/i386/fpu/e_logf_data.c: Likewise.
* sysdeps/i386/fpu/w_logf.c: Likewise.
* sysdeps/i386/i686/fpu/e_logf.S: Likewise.
* sysdeps/i386/fpu/libm-test-ulps: Updated for generic e_logf.c.
* sysdeps/i386/i686/fpu/multiarch/libm-test-ulps: Likewise.
* sysdeps/i386/i686/fpu/multiarch/Makefile (libm-sysdep_routines):
Add e_logf-sse2.
(CFLAGS-e_logf-sse2.c): New.
* sysdeps/i386/i686/fpu/multiarch/e_logf-sse2.c: New file.
* sysdeps/i386/i686/fpu/multiarch/e_logf.c: Likewise.
Diffstat (limited to 'sysdeps/i386/i686')
-rw-r--r-- | sysdeps/i386/i686/fpu/e_logf.S | 30 | ||||
-rw-r--r-- | sysdeps/i386/i686/fpu/multiarch/Makefile | 5 | ||||
-rw-r--r-- | sysdeps/i386/i686/fpu/multiarch/e_logf-sse2.c | 3 | ||||
-rw-r--r-- | sysdeps/i386/i686/fpu/multiarch/e_logf.c | 40 | ||||
-rw-r--r-- | sysdeps/i386/i686/fpu/multiarch/libm-test-ulps | 12 |
5 files changed, 52 insertions, 38 deletions
diff --git a/sysdeps/i386/i686/fpu/e_logf.S b/sysdeps/i386/i686/fpu/e_logf.S deleted file mode 100644 index 6fd39d50d3..0000000000 --- a/sysdeps/i386/i686/fpu/e_logf.S +++ /dev/null @@ -1,30 +0,0 @@ -/* - * Written by J.T. Conklin <jtc@netbsd.org>. - * Public domain. - * Adapted for float by Ulrich Drepper <drepper@cygnus.com>. - * - * Adapted for i686 instructions. - */ - -#include <machine/asm.h> - - - .text -ENTRY(__ieee754_logf) - fldln2 // log(2) - flds 4(%esp) // x : log(2) - fucomi %st - jp 3f - fyl2x // log(x) - ret - -3: fstp %st(1) - ret -END (__ieee754_logf) - -ENTRY(__logf_finite) - fldln2 // log(2) - flds 4(%esp) // x : log(2) - fyl2x // log(x) - ret -END(__logf_finite) diff --git a/sysdeps/i386/i686/fpu/multiarch/Makefile b/sysdeps/i386/i686/fpu/multiarch/Makefile index 2723f570af..ee4c3f39e7 100644 --- a/sysdeps/i386/i686/fpu/multiarch/Makefile +++ b/sysdeps/i386/i686/fpu/multiarch/Makefile @@ -1,7 +1,8 @@ ifeq ($(subdir),math) -libm-sysdep_routines += e_exp2f-sse2 e_expf-sse2 s_sinf-sse2 s_cosf-sse2 \ - s_sincosf-sse2 +libm-sysdep_routines += e_exp2f-sse2 e_expf-sse2 e_logf-sse2 \ + s_sinf-sse2 s_cosf-sse2 s_sincosf-sse2 CFLAGS-e_exp2f-sse2.c = -msse2 -mfpmath=sse CFLAGS-e_expf-sse2.c = -msse2 -mfpmath=sse +CFLAGS-e_logf-sse2.c = -msse2 -mfpmath=sse endif diff --git a/sysdeps/i386/i686/fpu/multiarch/e_logf-sse2.c b/sysdeps/i386/i686/fpu/multiarch/e_logf-sse2.c new file mode 100644 index 0000000000..11621fc122 --- /dev/null +++ b/sysdeps/i386/i686/fpu/multiarch/e_logf-sse2.c @@ -0,0 +1,3 @@ +#define __logf __logf_sse2 + +#include <sysdeps/ieee754/flt-32/e_logf.c> diff --git a/sysdeps/i386/i686/fpu/multiarch/e_logf.c b/sysdeps/i386/i686/fpu/multiarch/e_logf.c new file mode 100644 index 0000000000..1414d17d25 --- /dev/null +++ b/sysdeps/i386/i686/fpu/multiarch/e_logf.c @@ -0,0 +1,40 @@ +/* Multiple versions of logf. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <http://www.gnu.org/licenses/>. */ + +extern float __redirect_logf (float); + +#define SYMBOL_NAME logf +#include "ifunc-sse2.h" + +libc_ifunc_redirected (__redirect_logf, __logf, IFUNC_SELECTOR ()); + +#ifdef SHARED +__hidden_ver1 (__logf_ia32, __GI___logf, __redirect_logf) + __attribute__ ((visibility ("hidden"))); + +# include <shlib-compat.h> +versioned_symbol (libm, __logf, logf, GLIBC_2_27); +#else +weak_alias (__logf, logf) +#endif + +strong_alias (__logf, __ieee754_logf) +strong_alias (__logf, __logf_finite) + +#define __logf __logf_ia32 +#include <sysdeps/ieee754/flt-32/e_logf.c> diff --git a/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps b/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps index 2d056a9260..c86294b778 100644 --- a/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps +++ b/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps @@ -2000,9 +2000,9 @@ ldouble: 4 Function: "gamma_downward": double: 4 -float: 4 +float: 5 idouble: 4 -ifloat: 4 +ifloat: 5 ildouble: 7 ldouble: 7 @@ -2186,10 +2186,10 @@ ldouble: 4 Function: "lgamma_downward": double: 4 -float: 4 +float: 5 float128: 8 idouble: 4 -ifloat: 4 +ifloat: 5 ifloat128: 8 ildouble: 7 ldouble: 7 @@ -2625,10 +2625,10 @@ ldouble: 5 Function: "y0_towardzero": double: 2 -float: 2 +float: 3 float128: 3 idouble: 2 -ifloat: 2 +ifloat: 3 ifloat128: 3 ildouble: 5 ldouble: 5 |