diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-02-26 17:18:54 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-02-26 17:18:54 +0000 |
| commit | ec0ce0d3be4ae21add09139c705852ed8bb114c7 (patch) | |
| tree | 5f1fdab17731cca01fd46bcb264a6805a0e9d3fc /sysdeps/i386/fpu/e_asin.S | |
| parent | 380bd0fd2418f8988217de950f8b8ff18af0cb2b (diff) | |
| download | glibc-ec0ce0d3be4ae21add09139c705852ed8bb114c7.tar glibc-ec0ce0d3be4ae21add09139c705852ed8bb114c7.tar.gz glibc-ec0ce0d3be4ae21add09139c705852ed8bb114c7.tar.bz2 glibc-ec0ce0d3be4ae21add09139c705852ed8bb114c7.zip | |
Fix asin missing underflows (bug 16351).
Similar to various other bugs in this area, some asin implementations
do not raise the underflow exception for subnormal arguments, when the
result is tiny and inexact. This patch forces the exception in a
similar way to previous fixes.
Tested for x86_64, x86, powerpc and mips64.
[BZ #16351]
* sysdeps/i386/fpu/e_asin.S (dbl_min): New object.
(MO): New macro.
(__ieee754_asin): Force underflow exception for results with small
absolute value.
* sysdeps/i386/fpu/e_asinf.S (flt_min): New object.
(MO): New macro.
(__ieee754_asinf): Force underflow exception for results with
small absolute value.
* sysdeps/ieee754/dbl-64/e_asin.c: Include <float.h> and <math.h>.
(__ieee754_asin): Force underflow exception for results with small
absolute value.
* sysdeps/ieee754/flt-32/e_asinf.c: Include <float.h>.
(__ieee754_asinf): Force underflow exception for results with
small absolute value.
* sysdeps/ieee754/ldbl-128/e_asinl.c: Include <float.h>.
(__ieee754_asinl): Force underflow exception for results with
small absolute value.
* sysdeps/ieee754/ldbl-128ibm/e_asinl.c: Include <float.h>.
(__ieee754_asinl): Force underflow exception for results with
small absolute value.
* sysdeps/ieee754/ldbl-96/e_asinl.c: Include <float.h>.
(__ieee754_asinl): Force underflow exception for results with
small absolute value.
* sysdeps/x86_64/fpu/multiarch/e_asin.c [HAVE_FMA4_SUPPORT]:
Include <math.h>.
* math/auto-libm-test-in: Do not mark underflow exceptions as
possibly missing for bug 16351.
* math/auto-libm-test-out: Regenerated.
Diffstat (limited to 'sysdeps/i386/fpu/e_asin.S')
| -rw-r--r-- | sysdeps/i386/fpu/e_asin.S | 34 |
1 files changed, 33 insertions, 1 deletions
diff --git a/sysdeps/i386/fpu/e_asin.S b/sysdeps/i386/fpu/e_asin.S index 9a44cb62ac..ea8cb6f1b2 100644 --- a/sysdeps/i386/fpu/e_asin.S +++ b/sysdeps/i386/fpu/e_asin.S @@ -7,8 +7,26 @@ RCSID("$NetBSD: e_asin.S,v 1.4 1995/05/08 23:45:40 jtc Exp $") + .section .rodata.cst8,"aM",@progbits,8 + + .p2align 3 + .type dbl_min,@object +dbl_min: .byte 0, 0, 0, 0, 0, 0, 0x10, 0 + ASM_SIZE_DIRECTIVE(dbl_min) + +#ifdef PIC +# define MO(op) op##@GOTOFF(%ecx) +#else +# define MO(op) op +#endif + + .text + /* asin = atan (x / sqrt((1-x) (1+x))) */ ENTRY(__ieee754_asin) +#ifdef PIC + LOAD_PIC_REG (cx) +#endif fldl 4(%esp) /* x */ fld %st fld1 /* 1 : x : x */ @@ -18,6 +36,20 @@ ENTRY(__ieee754_asin) fmulp /* 1 - x^2 */ fsqrt /* sqrt (1 - x^2) */ fpatan - ret + fldl MO(dbl_min) + fld %st(1) + fabs + fucompp + fnstsw + sahf + jnc 1f + subl $8, %esp + cfi_adjust_cfa_offset (8) + fld %st(0) + fmul %st(0) + fstpl (%esp) + addl $8, %esp + cfi_adjust_cfa_offset (-8) +1: ret END (__ieee754_asin) strong_alias (__ieee754_asin, __asin_finite) |