diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-10-28 00:40:23 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-10-28 00:40:23 +0000 |
| commit | 4725d33eed118d69b8110285f7741cde9ddc8b4f (patch) | |
| tree | be10b6e9854beb628d9b6021dab98ad03efebf4b /stdlib/tst-strtod-round-skeleton.c | |
| parent | 61668b22f5d0efac44bbedad0e738faa6f0820ff (diff) | |
| download | glibc-4725d33eed118d69b8110285f7741cde9ddc8b4f.tar glibc-4725d33eed118d69b8110285f7741cde9ddc8b4f.tar.gz glibc-4725d33eed118d69b8110285f7741cde9ddc8b4f.tar.bz2 glibc-4725d33eed118d69b8110285f7741cde9ddc8b4f.zip | |
Make strtod raise "inexact" exceptions (bug 19380).
The strtod function should raise the "inexact" exception when its
result is inexact, but fails to do so except in the case of underflow
or overflow. This patch fixes it to do so for all inexact results.
tst-strtod-round is extended to test for this exception; the generator
is fixed to properly mark inexact results as such in the case where
the inexactness is from the mpfr_subnormalize step.
Tested for x86_64, x86 and powerpc.
[BZ #19380]
* stdlib/strtod_l.c (round_and_return): Force "inexact" exception
for inexact results.
* stdlib/gen-tst-strtod-round.c (string_to_fp): Return indication
of inexact result where mpfr_subnormalize is the only inexact
step.
* stdlib/tst-strtod-round-data.h: Regenerated.
* stdlib/tst-strtod-round-skeleton.c [!FE_INEXACT] (FE_INEXACT):
Define to 0.
(GEN_ONE_TEST): Test inexact exceptions raised are as expected.
Diffstat (limited to 'stdlib/tst-strtod-round-skeleton.c')
| -rw-r--r-- | stdlib/tst-strtod-round-skeleton.c | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/stdlib/tst-strtod-round-skeleton.c b/stdlib/tst-strtod-round-skeleton.c index 2e99dbdc21..89e09870ca 100644 --- a/stdlib/tst-strtod-round-skeleton.c +++ b/stdlib/tst-strtod-round-skeleton.c @@ -157,8 +157,13 @@ struct test { #define STR(x) STRX (x) #define FNPFXS STR (FNPFX) +#ifndef FE_INEXACT +# define FE_INEXACT 0 +#endif + #define GEN_ONE_TEST(FSUF, FTYPE, FTOSTR, LSUF, CSUF) \ { \ + feclearexcept (FE_INEXACT); \ FTYPE f = STRTO (FSUF) (s, NULL); \ if (f != expected->FSUF \ || (copysign ## CSUF) (1.0 ## LSUF, f) \ @@ -175,6 +180,19 @@ struct test { else \ printf ("ignoring this inexact result\n"); \ } \ + else if (FE_INEXACT != 0) \ + { \ + bool inexact_raised = fetestexcept (FE_INEXACT) != 0; \ + if (inexact_raised != !exact->FSUF) \ + { \ + printf (FNPFXS "to" #FSUF " (" STRM ") inexact %d " \ + "not %d\n", s, inexact_raised, !exact->FSUF); \ + if (EXCEPTION_TESTS (FTYPE)) \ + result = 1; \ + else \ + printf ("ignoring this exception error\n"); \ + } \ + } \ } static int |