diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-01-22 09:58:49 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.com> | 2016-03-07 00:21:37 -0300 |
| commit | 1eb8930608705702d5746e5491bab4e4429fcb83 (patch) | |
| tree | 6cf2a5c4a40c7240cc58c1c4e3347f77b699dd67 /posix/tst-execvpe3.c | |
| parent | f83bb9b8e97656ae0d3e2a31e859363e2d4d5832 (diff) | |
| download | glibc-1eb8930608705702d5746e5491bab4e4429fcb83.tar glibc-1eb8930608705702d5746e5491bab4e4429fcb83.tar.gz glibc-1eb8930608705702d5746e5491bab4e4429fcb83.tar.bz2 glibc-1eb8930608705702d5746e5491bab4e4429fcb83.zip | |
posix: execvpe cleanup
This patch removes all the dynamic allocation on execvpe code and
instead use direct stack allocation. This is QoI approach to make
it possible use in scenarios where memory is shared with parent
(vfork or clone with CLONE_VM).
For default process spawn (script file without a shebang), stack
allocation is bounded by NAME_MAX plus PATH_MAX plus 1. Large
file arguments returns an error (ENAMETOOLONG). This differs than
current GLIBC pratice in general, but it used to limit stack
allocation for large inputs. Also, path in PATH environment variable
larger than PATH_MAX are ignored.
The shell direct execution exeception, where execve returns ENOEXEC,
might requires a large stack allocation due large input argument list.
Tested on i686, x86_64, powerpc64le, and aarch64.
* posix/execvpe.c (__execvpe): Remove dynamic allocation.
* posix/Makefile (tests): Add tst-execvpe{1,2,3,4,5,6}.
* posix/tst-execvp1.c (do_test): Use a macro to call execvp.
* posix/tst-execvp2.c (do_test): Likewise.
* posix/tst-execvp3.c (do_test): Likewise.
* posix/tst-execvp4.c (do_test): Likewise.
* posix/tst-execvpe1.c: New file.
* posix/tst-execvpe2.c: Likewise.
* posix/tst-execvpe3.c: Likewise.
* posix/tst-execvpe4.c: Likewise.
* posix/tst-execvpe5.c: Likewise.
* posix/tst-execvpe6.c: Likewise.
Diffstat (limited to 'posix/tst-execvpe3.c')
| -rw-r--r-- | posix/tst-execvpe3.c | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/posix/tst-execvpe3.c b/posix/tst-execvpe3.c new file mode 100644 index 0000000000..47cdc14e87 --- /dev/null +++ b/posix/tst-execvpe3.c @@ -0,0 +1,20 @@ +/* Check script execution without shebang for execvpe. + Copyright (C) 2016 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <http://www.gnu.org/licenses/>. */ + +#define EXECVP(file, argv) execvpe (file, argv, NULL) +#include <posix/tst-execvp3.c> |