aboutsummaryrefslogtreecommitdiff
path: root/nptl/tst-sem11.c
diff options
context:
space:
mode:
authorCarlos O'Donell <carlos@systemhalted.org>2015-01-21 00:46:16 -0500
committerCarlos O'Donell <carlos@systemhalted.org>2015-01-21 00:46:16 -0500
commit042e1521c794a945edc43b5bfa7e69ad70420524 (patch)
tree74f44d4b065d801cfe6ace654827ca8ef351bff8 /nptl/tst-sem11.c
parenta8db092ec0c6742a9d41e1715946e90d4edfeec1 (diff)
downloadglibc-042e1521c794a945edc43b5bfa7e69ad70420524.tar
glibc-042e1521c794a945edc43b5bfa7e69ad70420524.tar.gz
glibc-042e1521c794a945edc43b5bfa7e69ad70420524.tar.bz2
glibc-042e1521c794a945edc43b5bfa7e69ad70420524.zip
Fix semaphore destruction (bug 12674).
This commit fixes semaphore destruction by either using 64b atomic operations (where available), or by using two separate fields when only 32b atomic operations are available. In the latter case, we keep a conservative estimate of whether there are any waiting threads in one bit of the field that counts the number of available tokens, thus allowing sem_post to atomically both add a token and determine whether it needs to call futex_wake. See: https://sourceware.org/ml/libc-alpha/2014-12/msg00155.html
Diffstat (limited to 'nptl/tst-sem11.c')
-rw-r--r--nptl/tst-sem11.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/nptl/tst-sem11.c b/nptl/tst-sem11.c
index 5248eba05d..1a2dbafd89 100644
--- a/nptl/tst-sem11.c
+++ b/nptl/tst-sem11.c
@@ -34,8 +34,11 @@ main (void)
puts ("sem_init failed");
return 1;
}
-
+#if __HAVE_64B_ATOMICS
+ if ((u.ns.data >> SEM_NWAITERS_SHIFT) != 0)
+#else
if (u.ns.nwaiters != 0)
+#endif
{
puts ("nwaiters not initialized");
return 1;
@@ -68,7 +71,11 @@ main (void)
goto again;
}
+#if __HAVE_64B_ATOMICS
+ if ((u.ns.data >> SEM_NWAITERS_SHIFT) != 0)
+#else
if (u.ns.nwaiters != 0)
+#endif
{
puts ("nwaiters not reset");
return 1;