aboutsummaryrefslogtreecommitdiff
path: root/inet/rcmd.c
diff options
context:
space:
mode:
authorAdhemerval Zanella Netto <adhemerval.zanella@linaro.org>2022-12-27 18:11:42 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-03-27 13:57:55 -0300
commit88677348b4de73874ca7d5a47451f42880f65f07 (patch)
tree9ebe22b88c2487331521737dfdf089f9e3e2439f /inet/rcmd.c
parente4d336f1ace7c7ca535f7f85485373752bc76ed5 (diff)
downloadglibc-88677348b4de73874ca7d5a47451f42880f65f07.tar
glibc-88677348b4de73874ca7d5a47451f42880f65f07.tar.gz
glibc-88677348b4de73874ca7d5a47451f42880f65f07.tar.bz2
glibc-88677348b4de73874ca7d5a47451f42880f65f07.zip
Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions
They are both used by __libc_freeres to free all library malloc allocated resources to help tooling like mtrace or valgrind with memory leak tracking. The current scheme uses assembly markers and linker script entries to consolidate the free routine function pointers in the RELRO segment and to be freed buffers in BSS. This patch changes it to use specific free functions for libc_freeres_ptrs buffers and call the function pointer array directly with call_function_static_weak. It allows the removal of both the internal macros and the linker script sections. Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'inet/rcmd.c')
-rw-r--r--inet/rcmd.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/inet/rcmd.c b/inet/rcmd.c
index 2b95fa11d8..ad8a894907 100644
--- a/inet/rcmd.c
+++ b/inet/rcmd.c
@@ -80,6 +80,7 @@
#include <sys/uio.h>
#include <sigsetops.h>
#include <shlib-compat.h>
+#include <set-freeres.h>
int __ivaliduser (FILE *, uint32_t, const char *, const char *);
@@ -98,7 +99,7 @@ int iruserok (uint32_t raddr, int superuser, const char *ruser,
libc_hidden_proto (iruserok_af)
-libc_freeres_ptr(static char *ahostbuf);
+static char *ahostbuf;
int
rcmd_af (char **ahost, u_short rport, const char *locuser, const char *remuser,
@@ -817,3 +818,5 @@ __validuser2_sa (FILE *hostf, struct sockaddr *ra, size_t ralen,
return retval;
}
+
+weak_alias (ahostbuf, __libc_rcmd_freemem_ptr)