diff options
| author | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-02-05 14:09:24 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-02-10 19:08:33 +0530 |
| commit | 228f30ab4724d4087d5f52018873fde22efea6e2 (patch) | |
| tree | 3b903fb3f04326e26ec6c418303d6ee2f3a150fe /elf | |
| parent | a1b8b06a55c1ee581d5ef860cec214b0c27a66f0 (diff) | |
| download | glibc-228f30ab4724d4087d5f52018873fde22efea6e2.tar glibc-228f30ab4724d4087d5f52018873fde22efea6e2.tar.gz glibc-228f30ab4724d4087d5f52018873fde22efea6e2.tar.bz2 glibc-228f30ab4724d4087d5f52018873fde22efea6e2.zip | |
tunables: Disallow negative values for some tunables
The glibc.malloc.mmap_max tunable as well as al of the INT_32 tunables
don't have use for negative values, so pin the hardcoded limits in the
non-negative range of INT. There's no real benefit in any of those
use cases for the extended range of unsigned, so I have avoided added
a new type to keep things simple.
Diffstat (limited to 'elf')
| -rw-r--r-- | elf/dl-tunables.list | 6 | ||||
| -rw-r--r-- | elf/tst-rtld-list-tunables.exp | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list index 3cf0ad83ec..8ddd4a2314 100644 --- a/elf/dl-tunables.list +++ b/elf/dl-tunables.list @@ -64,6 +64,7 @@ glibc { type: INT_32 env_alias: MALLOC_MMAP_MAX_ security_level: SXID_IGNORE + minval: 0 } arena_max { type: SIZE_T @@ -109,22 +110,27 @@ glibc { skip_lock_busy { type: INT_32 default: 3 + minval: 0 } skip_lock_internal_abort { type: INT_32 default: 3 + minval: 0 } skip_lock_after_retries { type: INT_32 default: 3 + minval: 0 } tries { type: INT_32 default: 3 + minval: 0 } skip_trylock_internal_abort { type: INT_32 default: 3 + minval: 0 } } diff --git a/elf/tst-rtld-list-tunables.exp b/elf/tst-rtld-list-tunables.exp index 4f3f7ee4e3..9f66c52885 100644 --- a/elf/tst-rtld-list-tunables.exp +++ b/elf/tst-rtld-list-tunables.exp @@ -1,7 +1,7 @@ glibc.malloc.arena_max: 0x0 (min: 0x1, max: 0x[f]+) glibc.malloc.arena_test: 0x0 (min: 0x1, max: 0x[f]+) glibc.malloc.check: 0 (min: 0, max: 3) -glibc.malloc.mmap_max: 0 (min: -2147483648, max: 2147483647) +glibc.malloc.mmap_max: 0 (min: 0, max: 2147483647) glibc.malloc.mmap_threshold: 0x0 (min: 0x0, max: 0x[f]+) glibc.malloc.mxfast: 0x0 (min: 0x0, max: 0x[f]+) glibc.malloc.perturb: 0 (min: 0, max: 255) |